Obrazec za dodajanje in urejanje pojma #26

Merged
g1smo merged 41 commits from nuxt-pojem-form into master 2024-01-23 22:37:56 +01:00

Z etherpad integracijo.

WIP!

Z etherpad integracijo. WIP!
g1smo added 2 commits 2023-09-30 20:15:30 +02:00

V .install fajlu je hook scheme nepotreben, ni treba tabele ustvarjat.

V settinga formi pa mislim, da se za key lahko uporabi tip polja password kot je narejeno tukaj https://git.drupalcode.org/project/ohdear_integration/-/blob/1.x/src/Form/SettingsForm.php?ref_type=heads#L53

V .install fajlu je hook scheme nepotreben, ni treba tabele ustvarjat. V settinga formi pa mislim, da se za key lahko uporabi tip polja password kot je narejeno tukaj https://git.drupalcode.org/project/ohdear_integration/-/blob/1.x/src/Form/SettingsForm.php?ref_type=heads#L53
g1smo added 1 commit 2023-11-12 18:40:29 +01:00
g1smo added 1 commit 2023-11-12 19:10:48 +01:00
g1smo added 1 commit 2023-11-12 22:55:56 +01:00
g1smo added 1 commit 2023-11-12 23:09:21 +01:00
g1smo changed title from Obrazec za urejanje pojma to Obrazec za dodajanje in urejanje pojma 2023-11-12 23:10:37 +01:00
Poster
Owner

V .install fajlu je hook scheme nepotreben, ni treba tabele ustvarjat.

V settinga formi pa mislim, da se za key lahko uporabi tip polja password kot je narejeno tukaj https://git.drupalcode.org/project/ohdear_integration/-/blob/1.x/src/Form/SettingsForm.php?ref_type=heads#L53

Urejeno, sem dodal service, requirement in izboljšal obrazec za nastavitve

> V .install fajlu je hook scheme nepotreben, ni treba tabele ustvarjat. > > V settinga formi pa mislim, da se za key lahko uporabi tip polja password kot je narejeno tukaj https://git.drupalcode.org/project/ohdear_integration/-/blob/1.x/src/Form/SettingsForm.php?ref_type=heads#L53 Urejeno, sem dodal service, requirement in izboljšal obrazec za nastavitve
g1smo self-assigned this 2023-11-12 23:11:34 +01:00
jernejm was assigned by g1smo 2023-11-12 23:11:34 +01:00
g1smo changed title from Obrazec za dodajanje in urejanje pojma to WIP: Obrazec za dodajanje in urejanje pojma 2023-11-12 23:13:40 +01:00
g1smo added 1 commit 2023-11-12 23:48:14 +01:00
g1smo added 1 commit 2023-11-13 00:22:41 +01:00
g1smo added 1 commit 2023-11-13 00:24:52 +01:00
g1smo force-pushed nuxt-pojem-form from ea1f55149e to ef936da4bb 2023-12-08 12:45:24 +01:00 Compare
g1smo force-pushed nuxt-pojem-form from ef936da4bb to 33da93a1dd 2023-12-08 13:20:16 +01:00 Compare
g1smo added 1 commit 2023-12-08 15:01:03 +01:00
g1smo added 1 commit 2023-12-15 17:09:01 +01:00
g1smo added 1 commit 2023-12-16 01:53:40 +01:00
g1smo added 1 commit 2023-12-16 02:05:37 +01:00
g1smo added 1 commit 2023-12-16 02:34:36 +01:00
g1smo added 1 commit 2024-01-06 16:40:45 +01:00
jan added 2 commits 2024-01-06 17:54:17 +01:00
g1smo added 1 commit 2024-01-06 17:56:14 +01:00
g1smo added 1 commit 2024-01-06 17:58:30 +01:00
g1smo added 1 commit 2024-01-06 18:05:59 +01:00
jan added 1 commit 2024-01-06 18:48:41 +01:00
jan added 1 commit 2024-01-06 18:50:38 +01:00
g1smo added 1 commit 2024-01-06 18:53:37 +01:00
g1smo added 4 commits 2024-01-06 19:00:44 +01:00
g1smo added 1 commit 2024-01-06 19:58:24 +01:00
g1smo added 1 commit 2024-01-06 20:02:12 +01:00
g1smo added 1 commit 2024-01-06 20:06:17 +01:00
jan added 1 commit 2024-01-07 22:33:32 +01:00
jan added 1 commit 2024-01-08 01:06:03 +01:00
g1smo added 1 commit 2024-01-15 14:37:09 +01:00
jan added 1 commit 2024-01-17 18:37:20 +01:00
g1smo added 1 commit 2024-01-17 19:04:18 +01:00
g1smo added 1 commit 2024-01-17 20:24:24 +01:00
jan added 3 commits 2024-01-17 20:36:50 +01:00
g1smo added 1 commit 2024-01-17 20:37:29 +01:00
g1smo changed title from WIP: Obrazec za dodajanje in urejanje pojma to Obrazec za dodajanje in urejanje pojma 2024-01-17 20:44:49 +01:00
g1smo added 1 commit 2024-01-17 22:21:12 +01:00
g1smo added 1 commit 2024-01-17 22:25:49 +01:00
lio approved these changes 2024-01-23 20:59:49 +01:00
lio left a comment
Owner

Nekaj lepotnih komentarjev in nekaj nerazumljenih vrstic.

Nekaj lepotnih komentarjev in nekaj nerazumljenih vrstic.
@ -1,3 +1,3 @@
_core:
default_config_hash: 2OMXCScXUOLSYID9-phjO4q36nnnaMWNUlDxEqZzG1U
use_admin_theme: true
use_admin_theme: false

mal sumljivo

mal sumljivo
g1smo marked this conversation as resolved
@ -9,3 +9,3 @@
default_config_hash: 12Bd0mJQFIaXAkRfMVCAAcZ0oaxm94PoK8oHR9hkLmY
id: content
label: Vsebine
label: Sadržaj

Ni kul, da je defaultni jezik hrvaski, ali pac?

Ni kul, da je defaultni jezik hrvaski, ali pac?
g1smo marked this conversation as resolved
@ -0,0 +22,4 @@
} catch (ClientException $exception) {
$value = $exception->getCode();
$msg = $exception->getMessage();
$requirements['etherpad_api_status'] = [

a bi bilo treba nastavit $requirements spremenljivko tudi ce je request uspesen in vrnit nek pozitiven rezultat?

a bi bilo treba nastavit $requirements spremenljivko tudi ce je request uspesen in vrnit nek pozitiven rezultat?
Poster
Owner

Je nastavljen višje, če prav razumem, je to samo za feedback če kaj ne štima.

Je nastavljen višje, če prav razumem, je to samo za feedback če kaj ne štima.
g1smo marked this conversation as resolved
@ -0,0 +1,15 @@
etherpad_api.example:

zakaj se imenuje example?

zakaj se imenuje example?
Poster
Owner

Ne se ne. Več.

Ne se ne. Več.
g1smo marked this conversation as resolved
@ -0,0 +3,4 @@
class: Drupal\etherpad_api\PathProcessor\EtherpadAPIPathProcessor
tags:
- { name: path_processor_inbound, priority: 1000 }
etherpad_api.settings:

to sem ugotovil, da je anti-pattern in se ne dela

https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal

to sem ugotovil, da je anti-pattern in se ne dela https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal
Poster
Owner

Baje ni grozno in bom pustil, hvala za info za naprej.

Baje ni grozno in bom pustil, hvala za info za naprej.
g1smo marked this conversation as resolved
@ -0,0 +40,4 @@
*/
public function __construct(ClientInterface $httpClient, ImmutableConfig $config) {
$this->httpClient = $httpClient;
$this->config = $config;

Naceloma ok, ampak config kot property zna bit kdaj rezerviran za kaj drugega in je treba bit pazljiv. Bolje je poimenovat direktno - etherpadApiConfig. oziroma itq je to antipattern in bi bilo treba tukaj injectat config.factory in sele v kodi spodaj dobit vrednosti konfiga

Naceloma ok, ampak config kot property zna bit kdaj rezerviran za kaj drugega in je treba bit pazljiv. Bolje je poimenovat direktno - etherpadApiConfig. oziroma itq je to antipattern in bi bilo treba tukaj injectat config.factory in sele v kodi spodaj dobit vrednosti konfiga
Poster
Owner

Sem ga kar izbacil.

Sem ga kar izbacil.
g1smo marked this conversation as resolved
@ -0,0 +45,4 @@
$this->apiKey = $config->get('key');
}
public function checkToken() {

missing comment

missing comment
g1smo marked this conversation as resolved
@ -0,0 +53,4 @@
}
/**
* Method description.

Wrong comment.

Wrong comment.
g1smo marked this conversation as resolved
@ -0,0 +36,4 @@
$data = array_merge($request->query->all(), $request->request->all());
if ($data['padID']) {
// @TODO prefix v config!
$data['padID'] = 'yufu-' . $data['padID'];

zdi se mi, da bi bilo dobr pogledat, ce prefix ze ni dodan, da ne pride do podvajanja

zdi se mi, da bi bilo dobr pogledat, ce prefix ze ni dodan, da ne pride do podvajanja
g1smo marked this conversation as resolved
@ -0,0 +72,4 @@
$url = rtrim($baseUrl, '/') . "/1.2/checkToken?apikey=$apiKey";
try {
$this->httpClient->request('get', $url);

for test/non-production instances it would be good if wrong key would pass validation, I guess

for test/non-production instances it would be good if wrong key would pass validation, I guess
g1smo marked this conversation as resolved
@ -0,0 +206,4 @@
# for more information about the topic in general.
# Note: By default the configuration is disabled.
cors.config:
enabled: false

we could probably enable this and allow necessary domains

we could probably enable this and allow necessary domains
g1smo marked this conversation as resolved
@ -0,0 +2,4 @@
cors.config:
enabled: true
allowedHeaders: ['x-csrf-token','authorization','content-type','accept','origin','x-requested-with','access-control-allow-origin','x-allowed-header','*']
allowedOrigins: ['*']

tukaj

tukaj
g1smo marked this conversation as resolved
g1smo merged commit 7f26d843bf into master 2024-01-23 22:37:56 +01:00
Sign in to join this conversation.
There is no content yet.