Commit Graph

1330 Commits (0e0c6606a6268ce50fd6eca263392b86ad7592ef)

Author SHA1 Message Date
intrigeri f9a000b24b 2008-09-27 12:40:26 -04:00
Joey Hess 83429adf04 decode utf-8 in recentchanges_link parameter 2008-09-26 15:40:01 -04:00
chrysn 1d12dfc57c update: possible solution 2008-09-26 12:44:09 -04:00
chrysn 947a50fe5d some problem remains 2008-09-26 09:05:01 -04:00
Joey Hess fa763214e3 close bugs for just fixed tag creation issue 2008-09-25 20:27:35 -04:00
Joey Hess 965f7310fe git: Fix handling of utf-8 filenames in recentchanges.
Seems that the problem is that once the \nnn coming from git is converted
to a single character, decode_utf8 decides that this is a standalone
character, and not part of a multibyte utf-8 sequence, and so does nothing.
I tried playing with the utf-8 flag, but that didn't work. Instead, use
decode("utf8"), which doesn't have the same qualms, and successfully
decodes the octets into a utf-8 character.

Rant:

Think for a minute about fact that any and every program that parses git-log,
or git-show, etc output to figure out what files were in a commit needs to
contain this snippet of code, to convert from git-log's wacky output to a
regular character set:

if ($file =~ m/^"(.*)"$/) {
	($file=$1) =~ s/\\([0-7]{1,3})/chr(oct($1))/eg;
}

(And it's only that "simple" if you don't care about filenames with
embedded \n or \t or other control characters.)

Does that strike anyone else as putting the parsing and conversion in the
wrong place (ie, in gitweb, ikiwiki, etc, etc)? Doesn't anyone who actually
uses git with utf-8 filenames get a bit pissed off at seeing \xxx\xxx
instead of the utf-8 in git-commit and other output?
2008-09-25 18:26:42 -04:00
Joey Hess dfe55e8956 Add keepextension parameter to htmlize hook. (Willu) 2008-09-23 13:39:21 -04:00
Joey Hess 9cbcda14ac Print a debug message if a page has multiple source files. 2008-09-23 13:32:41 -04:00
Joey Hess 7280d84c1c merged 2008-09-23 12:47:36 -04:00
http://ptecza.myopenid.com/ 338f0fde60 * Response 2008-09-23 08:34:43 -04:00
chrysn 88beb46def bug report on funny characters in the name 2008-09-23 04:58:35 -04:00
http://smcv.pseudorandom.co.uk/ ba1b9f8562 bug report with patch 2008-09-22 18:36:26 -04:00
http://smcv.pseudorandom.co.uk/ b44ca17f93 2008-09-22 18:29:48 -04:00
http://smcv.pseudorandom.co.uk/ c4fde75f46 Reference patches to beautify redirection URLs 2008-09-22 18:28:39 -04:00
http://www.cse.unsw.edu.au/~willu/ 2f3b93a55a Add second, related, patch. 2008-09-21 06:04:37 -04:00
http://www.cse.unsw.edu.au/~willu/ 57682e72d9 Add patch 2008-09-21 04:30:28 -04:00
http://www.cse.unsw.edu.au/~willu/ e255e8ecbf Add a new bug when using source highlighting 2008-09-21 00:49:11 -04:00
Joey Hess 779c5214f3 progress: Display an error if the progress cannot be parsed, and allow the percent parameter to only optionally end with "%". 2008-09-19 13:09:50 -04:00
http://ptecza.myopenid.com/ b203b58f48 * Addition 2008-09-19 10:13:55 -04:00
http://ptecza.myopenid.com/ f5b0ea73b5 * Response 2008-09-19 09:48:56 -04:00
http://www.cse.unsw.edu.au/~willu/ 68531e1239 Response 2008-09-19 08:28:38 -04:00
http://ptecza.myopenid.com/ 72b8c09843 * More clear about my upgrade 2008-09-19 06:00:29 -04:00
http://ptecza.myopenid.com/ 538168d869 * No progress 2008-09-19 05:43:10 -04:00
Joey Hess fa4f735ad7 response 2008-09-17 13:49:03 -04:00
http://thewordnerd.info/ 65120e433d 2008-09-16 08:19:41 -04:00
http://josephturian.blogspot.com/ 17af48adca 2008-09-15 23:07:19 -04:00
http://josephturian.blogspot.com/ 0254bbb5e8 2008-09-15 23:06:04 -04:00
Joey Hess 293c69ae95 user error 2008-09-15 17:38:25 -04:00
Joey Hess c8f1fe835e fix links 2008-09-14 17:03:34 -04:00
Joey Hess 1e4c9e6733 cannot reproduce 2008-09-14 13:43:27 -04:00
http://madduck.net/ c984a572c8 new bug about parsing recentchanges diffs 2008-09-13 08:29:55 -04:00
Joey Hess 97b71834bb fix IkiWiki::Setup::load docs 2008-09-12 21:20:34 -04:00
bremner ec6cd6fff8 more difficulties with IkiWiki::Setup::load 2008-09-12 21:09:50 -04:00
http://thewordnerd.myopenid.com/ 25629d7621 2008-09-11 20:26:56 -04:00
Joey Hess 9152042aea fix cpan links 2008-09-11 19:40:41 -04:00
jpritikin d02411bac0 2008-09-11 07:13:45 -04:00
Joey Hess 20ad20a87b response 2008-09-10 16:47:19 -04:00
jpritikin 62df83b57c 2008-09-10 12:53:29 -04:00
Joey Hess 7a680431ed Add allow_symlinks_before_srcdir to config so websetup doesn't eat it. 2008-09-09 14:50:37 -04:00
jpritikin 848d0d0a3b 2008-09-09 14:27:47 -04:00
Joey Hess 2b53de66a0 ddate: Stop clobbering timeformat when not enabled. 2008-09-08 19:40:23 -04:00
http://smcv.pseudorandom.co.uk/ f50622f136 amusing collision between ddate and websetup 2008-09-08 18:31:35 -04:00
Joey Hess d2679de965 For fine control over what characters are allowed, unescaped in source filenames, the wiki_file_chars setting is added. For example, set to "-[:alnum:]+/._" to disable colons from being used in source files (which can cause trouble om Windows). 2008-09-04 14:13:10 -04:00
Joey Hess 000c87f510 don't fail if %config is not set 2008-09-01 11:26:03 -04:00
bremner da30f5a8fb workaround 2008-08-31 17:58:42 -04:00
bremner f7ad016a3f report trouble trying to use IkiWiki::Setup::load outside ikiwiki 2008-08-31 15:47:01 -04:00
Joey Hess 75a096d056 Work around perl $_ scoping nonsense that caused breakage when loading external plugins. 2008-08-29 18:40:41 -04:00
chrysn a8d9f1c5cd report bug for </methodResponse> problem (patch included) 2008-08-29 17:43:28 -04:00
Joey Hess 981d0474a1 Ignore failure to install files into /etc, in case install is running as non-root. 2008-08-29 15:53:46 -04:00
Joey Hess ef3d080a9a response 2008-08-29 15:49:52 -04:00
bremner 114db37eb3 patch for install in $HOME 2008-08-29 14:30:38 -04:00
Joey Hess 4d0b142412 response 2008-08-29 13:29:10 -04:00
http://www.cse.unsw.edu.au/~willu/ df641322ed comments 2008-08-29 02:01:04 -04:00
Joey Hess 6efbbf967e response 2008-08-28 16:41:56 -04:00
Joey Hess 0e45a7c776 fix a few direcives 2008-08-26 17:56:23 -04:00
Joey Hess b2d7bbb922 Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
Conflicts:

	doc/bugs/previewing_with_an_edittemplate_reverts_edit_box.mdwn
2008-08-25 20:51:45 -04:00
Joey Hess d06096ad0d edittemplate: Don't wipe out edits on preview. 2008-08-25 20:51:10 -04:00
JoeRayhawk b8c8201876 Signing 2008-08-25 20:29:39 -04:00
JoeRayhawk 3c542cc279 Bug: previewing with an edittemplate reverts edit box 2008-08-25 20:27:00 -04:00
Joey Hess b278218d91 response 2008-08-25 19:31:57 -04:00
Joey Hess d6fd1f1cc8 rename preprocessordirective to directive
Reasons include:
- easier to type
- might want postprocessor directives again sometime, and listdirectives
  can then use the directive/* files for either
- that it's done as a preprocessor step is an internal detail (and not a
  very accurate one, really :-)
2008-08-25 14:19:39 -04:00
Joey Hess 14885af458 cannot reproduce 2008-08-23 15:45:44 -04:00
http://mskala.livejournal.com/ 56c2fca4b0 2008-08-23 14:28:01 -04:00
Joey Hess 9b10f5eab2 map: The fix for #449285 was buggy and broke display of parents in certian circumstances.
The use of $dummy was not sufficient, because it only stuck around for the
first element after a dummy parent, and was then lost. Instead, use a
$addparent that contains the actual dummy parent, so it can be compared
with the new item to see if we're still under that parent or have moved to
another one.
2008-08-23 13:10:49 -04:00
Joey Hess 7071d0b586 remove incorrect comment 2008-08-23 12:19:39 -04:00
Joey Hess bc0e09e6c8 problem with the patch 2008-08-23 12:13:38 -04:00
Joey Hess dec9b4e2c9 Avoid using cp -a (again). (HenrikBrixAndersen) 2008-08-21 16:21:40 -04:00
https://brian.may.myopenid.com/ 2ad40b82f4 add more details 2008-08-21 02:39:31 -04:00
http://thewordnerd.myopenid.com/ 5f7050ed33 2008-08-20 22:20:34 -04:00
http://josephturian.blogspot.com/ 0257186f4d 2008-08-18 20:53:59 -04:00
HenrikBrixAndersen bebfceda30 Add suggestion 2008-08-18 17:22:34 -04:00
http://josephturian.blogspot.com/ 9d9a9076d9 2008-08-18 16:37:31 -04:00
http://josephturian.blogspot.com/ c790e3975e 2008-08-18 12:10:10 -04:00
HenrikBrixAndersen 6f70b29506 Add proposed patch 2008-08-16 09:09:47 -04:00
JoshTriplett b31809a577 2008-08-15 19:50:39 -04:00
http://jcflack.myopenid.com/ 79a3fbb1ab 2008-08-14 16:08:53 -04:00
Joey Hess d875fbb52e response 2008-08-14 14:50:02 -04:00
Joey Hess 5d83e7359d graphviz: Fix breakage of the name of the preprocessor directive. 2008-08-14 14:44:30 -04:00
HenrikBrixAndersen 15424d405b Add wish about not using 'cp -a' 2008-08-13 15:28:33 -04:00
HenrikBrixAndersen e43c3ebece Add graphviz bug 2008-08-13 15:22:09 -04:00
Joey Hess 2aa46a3a8e response 2008-08-12 18:38:49 -04:00
http://edward.myopenid.com/ 0e9deb3a41 create bug report 2008-08-12 17:49:41 -04:00
http://www.cse.unsw.edu.au/~willu/ 9c33352e9b Mark done 2008-08-07 17:18:14 -04:00
Joey Hess 581381e335 inline: Ignore parent dirs when sorting pages by title. 2008-08-07 15:47:59 -04:00
http://www.cse.unsw.edu.au/~willu/ de836d6141 2008-08-07 07:45:05 -04:00
http://www.cse.unsw.edu.au/~willu/ 0455bd68b5 2008-08-07 07:43:53 -04:00
http://www.cse.unsw.edu.au/~willu/ 9f90278d41 2008-08-07 07:42:47 -04:00
http://www.cse.unsw.edu.au/~willu/ 8c355286dc Add patch to bug report 2008-08-07 04:14:53 -04:00
http://www.cse.unsw.edu.au/~willu/ db1ed357fb Note that inline sort by title really sorts by path 2008-08-07 03:43:59 -04:00
http://www.cse.unsw.edu.au/~willu/ 78cf903610 Add note on work-around 2008-08-05 07:06:16 -04:00
http://www.cse.unsw.edu.au/~willu/ ea7bcf6472 Clarify when 'above' and 'below' mean higher and lower on the page, and when they mean printing over the top of other items 2008-08-05 06:54:08 -04:00
http://www.cse.unsw.edu.au/~willu/ 921b28dde3 More information making sidebar and recentchanges work together 2008-08-05 06:46:09 -04:00
http://www.cse.unsw.edu.au/~willu/ 4f58ad1c10 Add screenshots 2008-08-05 00:49:22 -04:00
Joey Hess d1cb73cb55 set background color of floating divs
If a floating div is next to (and in front of) a div that takes up the
whole screen width, and has a background color set, that color can bleed
through into the floating div. One exampe of this is inline's blogpost
form. Avoid it by setting the background color of the floating element.
2008-08-04 15:08:27 -04:00
Joey Hess 86674c9584 done 2008-08-04 14:56:47 -04:00
http://smcv.pseudorandom.co.uk/ eadff687ab 2008-08-03 11:24:20 -04:00
http://www.cse.unsw.edu.au/~willu/ 4cdf41df0c small patch update 2008-08-02 22:20:53 -04:00
http://www.cse.unsw.edu.au/~willu/ 35a3559ebe Add patch to bug report 2008-08-02 22:14:26 -04:00
http://www.cse.unsw.edu.au/~willu/ 6c2163d596 update to actual generated example 2008-08-02 21:52:48 -04:00
http://www.cse.unsw.edu.au/~willu/ b7d7abf2b4 Sidebar layout strange 2008-08-02 19:53:08 -04:00
http://smcv.pseudorandom.co.uk/ 200fb31d04 Suggest how to solve this 2008-08-02 09:48:32 -04:00
Joey Hess bc1c267723 response 2008-08-01 17:39:17 -04:00
http://jcflack.myopenid.com/ 19d8acaa95 2008-08-01 10:55:46 -04:00
Joey Hess 041923a89e Merge branch 'master' into autoconfig
Conflicts:

	IkiWiki/Plugin/git.pm
	debian/changelog
	po/ikiwiki.pot
2008-07-31 19:35:37 -04:00
Joey Hess 71eb56bcac merged 2008-07-31 18:52:30 -04:00
Joey Hess 973e49e31d response 2008-07-31 18:49:40 -04:00
http://smcv.pseudorandom.co.uk/ 53001f9011 2008-07-31 17:26:49 -04:00
Joey Hess 33cd89c68b questions 2008-07-31 16:09:26 -04:00
Joey Hess 17dd9d6212 rename 2008-07-31 15:52:20 -04:00
http://smcv.pseudorandom.co.uk/ fe482079cc 2008-07-30 17:26:30 -04:00
http://smcv.pseudorandom.co.uk/ 0a176059bb 2008-07-30 17:25:36 -04:00
Joey Hess 3b72c23673 rm 2008-07-29 16:55:44 -04:00
HenrikBrixAndersen 17a1999433 Obsolete templates/estseek.conf 2008-07-29 16:51:18 -04:00
Joey Hess 4f06e7402a remove ikiwiki.setup
To generate your own, use ikiwiki -dumpsetup ikiwiki.setup

Update docs.
2008-07-26 22:55:39 -04:00
Joey Hess dd40fbdf03 close 2008-07-26 21:16:09 -04:00
http://ptecza.myopenid.com/ 0815312e1d * Response 2008-07-26 09:07:20 -04:00
Joey Hess 435a8e1ce5 response 2008-07-25 12:51:50 -04:00
Joey Hess 75acf76851 eh 2008-07-25 12:23:10 -04:00
http://ptecza.myopenid.com/ 9cc28ac18c * Bug report 2008-07-25 09:44:24 -04:00
Mathias 65f902df43 2008-07-25 05:32:45 -04:00
Joey Hess 89e0de5bc4 improved, possibly faster getelementsbyclass by willu 2008-07-25 01:43:37 -04:00
http://www.cse.unsw.edu.au/~willu/ f42ad32b0c Suggest improved getElementsByClass() function 2008-07-25 01:34:40 -04:00
Joey Hess 99b59f2d62 toggle: Fix incompatability between javascript and webkit. 2008-07-25 01:24:20 -04:00
http://www.cse.unsw.edu.au/~willu/ f818039140 2008-07-25 00:26:21 -04:00
http://www.cse.unsw.edu.au/~willu/ 27060277cc report bug 2008-07-25 00:25:19 -04:00
Joey Hess 058e7e451c response 2008-07-24 14:33:03 -04:00
Joey Hess a99804c68b forwarded 2008-07-24 13:21:23 -04:00
http://gmcmanus.myopenid.com/ af8e847c7b markdown bugs demonstrated 2008-07-24 06:39:04 -04:00
http://ptecza.myopenid.com/ 4e8877d7b3 * Thanks! It works now. 2008-07-24 06:09:30 -04:00
http://alcopop.org/me/openid/ 6988e1460c example plus address failing 2008-07-24 05:19:46 -04:00
Joey Hess b95669c3c8 Rebuild pages that change their type. (Gabriel McManus) 2008-07-23 16:13:37 -04:00
Joey Hess 7fa3a2f83b response 2008-07-23 15:05:59 -04:00
Joey Hess 1d1767192c attachment: Do not escape _ when determining attachment filenames. 2008-07-23 14:58:39 -04:00
http://ptecza.myopenid.com/ 89ca6143ee * Update 2008-07-23 07:19:24 -04:00
http://ptecza.myopenid.com/ 5467015fbd * Typo 2008-07-23 06:12:12 -04:00
http://ptecza.myopenid.com/ f213303f43 * Bug? 2008-07-23 06:11:18 -04:00
http://www.cse.unsw.edu.au/~willu/ 8ca397c2c6 Report bug in map wrt bare directories 2008-07-22 22:48:19 -04:00
http://gmcmanus.myopenid.com/ b2917c76cb bug when pages changing extension; new patch 2008-07-22 05:33:24 -04:00
http://gmcmanus.myopenid.com/ 602ad172d0 patch to prevent email obfuscation 2008-07-22 05:10:46 -04:00
http://brian.may.myopenid.com/ 4515726bfe response to response 2008-07-22 01:28:20 -04:00
http://gmcmanus.myopenid.com/ 88ff7480e6 bug already noted, so mark as done 2008-07-22 01:22:14 -04:00
http://gmcmanus.myopenid.com/ 2e51d5c74d email obfuscation by Text::Markdown undone by HTML::Scrubber 2008-07-21 23:25:17 -04:00
Joey Hess c2a2f71508 Add allow_symlinks_before_srcdir config setting
can be used to avoid a security check that is a good safe default, but
problimatic overkill in some situations.

I decided to underdocument this, because the option looks ugly, and I don't
want people randomly turning it on because it looks like a good idea. So if
you need it, you'll get an error message mentioning how to fix it.
2008-07-21 18:33:09 -04:00
Joey Hess c2ffd205f3 Really fix bug with links to pages with names containing colons
Previous fix mised a few cases.
2008-07-21 17:27:14 -04:00
Joey Hess 9a8b0744a3 typo 2008-07-21 17:15:12 -04:00
Joey Hess 9187e53575 test 2008-07-21 17:14:43 -04:00
Joey Hess b884cbd00f response 2008-07-21 17:12:17 -04:00
Mathias 652beaf48c 2008-07-21 16:04:17 -04:00
Simon McVittie 404f54ac60 Migrate escaped directives (\[[) in doc/bugs to have \[[! prefix 2008-07-21 12:46:47 +01:00
Simon McVittie 9c02d61d9b Migrate doc/bugs via prefix_directives
This is a partial commit of:
egrep -rl '\[\[[a-z]+ ' doc | xargs --max-args 1 ./ikiwiki-transition
prefix_directives
2008-07-21 12:31:04 +01:00
http://www.cse.unsw.edu.au/~willu/ a90b80a679 close 2008-07-20 18:04:41 -04:00
Joey Hess fcfbf252e2 respinse 2008-07-19 13:36:06 -04:00
Joey Hess b557ba7c46 close bug, add changelog 2008-07-19 13:24:58 -04:00
http://gmcmanus.myopenid.com/ c8995955df new bug and patch 2008-07-19 03:04:47 -04:00
http://smcv.pseudorandom.co.uk/ 1e6b38a335 2008-07-18 22:08:13 -04:00
http://www.cse.unsw.edu.au/~willu/ 15fb518cc2 New bug and patch - close stderr when forking a sub process to run git 2008-07-18 21:03:55 -04:00
Joey Hess 584f3e3061 Add a postscan hook.
* Add a postscan hook.
* search: Use postscan hook, avoid updating index when previewing.
2008-07-17 16:17:15 -04:00
Joey Hess 4bc6f6cb96 web commit by http://jcflack.myopenid.com/ 2008-07-17 10:46:03 -04:00
Joey Hess acb6f66fbe closures 2008-07-14 21:30:59 -04:00
Joey Hess 5d027102f5 fix link 2008-07-14 15:20:37 -04:00
Joey Hess a3c8465565 web commit by http://ptecza.myopenid.com/: * Broken URL 2008-07-14 10:15:37 -04:00
Simon McVittie 30b3b00f4f Mark bug "clear: both for .page*?" as [[done]] 2008-07-13 15:33:44 +01:00
Joey Hess 2d6263b991 web commit by http://smcv.pseudorandom.co.uk/: Patched 2008-07-13 10:31:09 -04:00
Joey Hess 74bc4af998 web commit by http://smcv.pseudorandom.co.uk/: on second thoughts, more changes are desirable 2008-07-13 09:50:33 -04:00
Joey Hess 4ad9680d52 web commit by http://smcv.pseudorandom.co.uk/: suggest solution 2008-07-13 09:45:59 -04:00
Joey Hess e3c0e49774 only htmlize errors when cgi is actually running 2008-07-12 23:23:25 -04:00
Joey Hess 71fba7791f add perlmagick to build deps
needed since the doc wiki is using an [[img]]
2008-07-12 20:20:26 -04:00
Simon McVittie 60dc17c39c Hopefully fix regression tests in non-English environments 2008-07-12 23:00:57 +01:00
Simon McVittie ac8a862a06 Merge branch 'master' of git://git.ikiwiki.info into bugs 2008-07-12 22:56:55 +01:00
Joey Hess 44e42209a8 web commit by http://smcv.pseudorandom.co.uk/: I think I know what's wrong here too 2008-07-12 17:56:38 -04:00
Simon McVittie bed1f1037a Add missing requirement of IkiWiki::render before starting to render things 2008-07-12 22:52:46 +01:00
Joey Hess 99523151a8 web commit by http://smcv.pseudorandom.co.uk/ 2008-07-12 17:48:41 -04:00
Joey Hess 40975cd29d web commit by intrigeri: initial bug submission 2008-07-12 17:47:51 -04:00
Joey Hess ce4c5142b0 web commit by intrigeri: update, found a possible (random) fix 2008-07-12 17:40:25 -04:00
Joey Hess 299fd7fa2e web commit by intrigeri: bug submission 2008-07-12 17:32:13 -04:00
Joey Hess 4f51703fea web commit by intrigeri: bug submission 2008-07-12 17:25:43 -04:00
Joey Hess 52cccc6fd4 remove example (which was lacking escaping) 2008-07-12 12:04:47 -04:00
Joey Hess 6255c88e89 fixed 2008-07-12 12:04:10 -04:00
Joey Hess d36361b010 web commit by http://smcv.pseudorandom.co.uk/ 2008-07-12 12:01:05 -04:00
Joey Hess a0f596b6ed Change deb dependencies to list Text::Markdown before markdown, since the former, while slower, has a much better html parser that avoids numerous bugs. 2008-07-12 10:40:31 -04:00
Joey Hess 0a09638f96 greatly simplified test case 2008-07-12 10:33:41 -04:00
Joey Hess 32a8bf4c36 bug 2008-07-11 06:24:25 -04:00
Joey Hess 76b963deb5 web commit by intrigeri: thanks + note about git collaborative work 2008-07-11 03:16:06 -04:00
Joey Hess 7e29cbfc27 web commit by intrigeri: answer + fix escaping in example wiki page 2008-07-11 03:09:59 -04:00
Joey Hess 0073775dc3 question 2008-07-10 15:39:08 -04:00
Joey Hess 8ba2497a23 escape 2008-07-10 15:38:08 -04:00
Joey Hess 3879c56e71 Fixes creation of pages when clicking on WikiLinks starting with "/". 2008-07-10 15:36:18 -04:00
Joey Hess c52493422b web commit by intrigeri: initial bug submission 2008-07-10 15:02:25 -04:00
Joey Hess ac4a11ba50 web commit by intrigeri: added opinion + patch 2008-07-10 14:56:52 -04:00
Joey Hess 8c48db5be2 web commit by http://ptecza.myopenid.com/: * Confirmation and thanks 2008-07-09 04:27:10 -04:00
Joey Hess 3c82db72c4 remove patch tag 2008-07-09 02:05:57 -04:00
Joey Hess ee5585f7d9 close 2008-07-09 02:02:26 -04:00
Joey Hess 79ffb09ca2 close 2008-07-09 02:02:03 -04:00
Joey Hess 7541622fe9 response 2008-07-08 19:28:20 -04:00
Joey Hess 61479665b4 web commit by AndrewGreenberg: bad formatting on bug report, sorry. 2008-07-08 19:15:40 -04:00
Joey Hess ae4d377946 web commit by AndrewGreenberg: Added nasty URL edit bug in 2.52. 2008-07-08 19:14:11 -04:00
Joey Hess 03d7f84f28 Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
Conflicts:

	doc/bugs/attachment:_failed_to_get_filehandle.mdwn
2008-07-08 18:12:33 -04:00
Joey Hess ad02f69836 attachment: Support perl 5.8's buggy version of CGI.pm.
This is truely horribly disgusting. CGI::tmpFileName, in current perls, is
an undocumented function (which should be a clue..) that takes the original
filename of an uploaded attachment, and returns the name of the tempfile
that CGI has stored it in.

In old perls, though, CGI::tmpFileName does not take a filename. It takes
a key from the object's {'.tmpfiles'} hash. This key is something
crazy like '*Fh::fh00001group' -- apparently the stringification of a
filehandle object.

Just to add to the fun, tmpFileName doesn't take the key, it expects a
refernce to the key. Argh?!

But the fun doesn't stop there, because in perl 5.8, CGI.pm is also broken
in two other ways. The upload() method is supposed to return a filehandle
to the temp file. It doesn't. The param() method is supposed to return
a filehandle to the temp file, that stringifies to the original filename.
It returns just the original filename, no filehandle.

Combine all these bugs, and you end up with this disgusting commit. Since
I have no way to get the filehandle, I *need* to get the tempfile name.
If I had the filehandle, I could probably pass it into tmpFileName, and
it might strigify to the right key name. But I don't, so the only way to
determine the key is to grub through the .tmpfiles hash ourselves.

And finally, one the temp file name is discovered, a filehandle can finally
be obtained by (re)opening it.

I recommend that this commit be reverted when perl 5.8 is a mercifully
faded memory.

I'm really, really, really glad I'm actually being paid for working on
this right now!
2008-07-08 18:10:53 -04:00
Joey Hess 9e51b2ccb5 web commit by http://ptecza.myopenid.com/: * Thanks! 2008-07-08 17:05:33 -04:00
Joey Hess 905d99e248 web commit by HenrikBrixAndersen: This happens on FreeBSD as well 2008-07-08 17:04:28 -04:00
Joey Hess 4a86457750 reproduced 2008-07-08 16:59:21 -04:00
Joey Hess f529518948 response 2008-07-08 16:21:17 -04:00
Joey Hess 8cac2ac23e web commit by http://ptecza.myopenid.com/: * The bug still occurs 2008-07-08 16:11:18 -04:00
Joey Hess 6f3c980e2b undef $fh before opening 2008-07-08 12:16:36 -04:00
Joey Hess 6fc21e9d3d web commit by http://ptecza.myopenid.com/: * Still no success 2008-07-08 11:56:31 -04:00
Joey Hess bae7306828 response 2008-07-08 11:47:03 -04:00
Joey Hess 66f35e30dc another try at dealing with CGI.pm problem
open the temp file if all attempts to get a fd fail
2008-07-08 11:25:30 -04:00
Joey Hess 5ccd0cb518 web commit by http://ptecza.myopenid.com/: * Debugging again 2008-07-08 11:15:48 -04:00
Joey Hess fd6ebaeee7 possible fix 2008-07-08 10:43:45 -04:00
Joey Hess 0ffe0872c1 web commit by http://ptecza.myopenid.com/: * Next debbuging 2008-07-08 10:24:24 -04:00
Joey Hess fac6743cad new thing to try 2008-07-08 10:16:29 -04:00
Joey Hess 0c9a504948 fix fix 2008-07-08 10:05:57 -04:00
Joey Hess f8a86765d2 close 2008-07-08 10:04:43 -04:00
Joey Hess 42dcf37016 web commit by http://ptecza.myopenid.com/: * Missing Apache2 version 2008-07-08 10:00:48 -04:00
Joey Hess 99113e50ef web commit by http://ptecza.myopenid.com/: * Response 2008-07-08 09:58:33 -04:00
Joey Hess 04319b030c split out separate bug 2008-07-08 09:49:29 -04:00
Joey Hess 7e16fa3a1e response 2008-07-08 09:46:29 -04:00
Joey Hess f156308aef attachment: Fix an uninitialised value warning when editing a page that currently has no attachments. 2008-07-08 09:40:46 -04:00
Joey Hess db77e342fa web commit by http://ptecza.myopenid.com/: * Problem with colon in report page name 2008-07-08 06:42:33 -04:00
Joey Hess 7977fe382a web commit by http://ptecza.myopenid.com/: * Problem with uploading attachments 2008-07-08 06:29:20 -04:00
Joey Hess a3f6385448 web commit by http://ptecza.myopenid.com/: * Thanks! 2008-07-08 04:27:12 -04:00
Joey Hess b37a98c207 web commit by http://www.openidfrance.fr/beaufils 2008-07-07 15:11:57 -04:00
Joey Hess f1b86d1016 response 2008-07-07 12:07:47 -04:00
Joey Hess 14d959b246 web commit by http://ptecza.myopenid.com/: * Enabling attachment plugin 2008-07-07 08:44:43 -04:00
Joey Hess 43e0691a50 search: generate configuration files once only when rebuilding (Gabriel McManus) 2008-07-07 01:55:06 -04:00
Joey Hess 85c75c8f9d web commit by http://gmcmanus.myopenid.com/: search: create configuration once only on rebuild 2008-07-07 00:57:39 -04:00
Joey Hess 05124f9a86 editpage escaping fixes
* The editpage form now uses the raw page name, not the page title, in its
  'page' cgi parameter. Using the title was ambiguous and made it
  impossible to tell between some pages, like "foo/bar" and "foo__47__bar",
  sometimes causing the wrong page to be edited.
* This change means that some edit links need to be updated.
  Force a rebuild on upgrade to this version.
* Above change also allowed really fixing escaped slashes from the blogpost
  form.
2008-07-06 15:52:04 -04:00
Joey Hess 4bf7785760 response 2008-07-06 14:07:33 -04:00
Joey Hess 674ed7e706 response 2008-07-06 14:05:01 -04:00
Joey Hess 17bb3cec42 rm 2008-07-06 13:58:47 -04:00
Joey Hess bb3036317d web commit by http://www.openidfrance.fr/beaufils 2008-07-05 22:18:04 -04:00
Joey Hess f0ff71af55 web commit by http://www.openidfrance.fr/beaufils 2008-07-05 22:04:12 -04:00
Joey Hess 8b59050ea7 web commit by http://www.openidfrance.fr/beaufils 2008-07-05 21:52:03 -04:00
Joey Hess f9ddfe56b9 web commit by http://www.openidfrance.fr/beaufils 2008-07-05 21:51:23 -04:00
Joey Hess f5dca442fe web commit by http://www.openidfrance.fr/beaufils 2008-07-05 21:50:47 -04:00
Joey Hess 6a863b58a6 web commit by http://www.openidfrance.fr/beaufils 2008-07-05 21:49:46 -04:00
Joey Hess 4db44caf06 web commit by http://www.openidfrance.fr/beaufils 2008-07-05 21:45:21 -04:00
Joey Hess 4d7ccdc8e5 web commit by http://www.openidfrance.fr/beaufils 2008-07-05 21:44:03 -04:00
Joey Hess 69108f446f web commit by http://tychoish.livejournal.com/: further clarification. 2008-07-04 08:03:54 -04:00
Joey Hess 560372bf94 web commit by http://subvert.org.uk/~bma/ 2008-07-04 03:21:16 -04:00
Joey Hess df736d3089 web commit by http://subvert.org.uk/~bma/ 2008-07-04 03:14:29 -04:00
Joey Hess 2d64fdd22e web commit by http://tychoish.livejournal.com/ 2008-07-03 23:00:37 -04:00
Joey Hess cb06a01b75 web commit by http://jcflack.myopenid.com/ 2008-07-03 18:21:07 -04:00
Joey Hess f7755e5e01 web commit by http://jcflack.myopenid.com/ 2008-07-03 18:20:25 -04:00
Joey Hess 77ebc0ad8c web commit by http://jcflack.myopenid.com/ 2008-07-03 13:40:30 -04:00
Joey Hess 2354613391 response; move to bug report 2008-07-02 16:43:13 -04:00
Joey Hess 19749d0c5b web commit by http://liw.fi/: commented on &uuml; and ikiwiki 2.50 2008-07-01 14:29:35 -04:00
Joey Hess 524ee496e3 remove bad link 2008-06-29 14:18:00 -04:00
Joey Hess 8ab0d60271 web commit by http://ptecza.myopenid.com/: * Plural 2008-06-29 11:15:38 -04:00
Joey Hess c44ae04702 web commit by http://ptecza.myopenid.com/: * Thanks! 2008-06-29 11:02:55 -04:00