attachment: Do not escape _ when determining attachment filenames.

IkiWiki/Plugin/attachment.pm

@@ -102,7 +102,7 @@ sub formbuilder (@) { #{{{
 			}
 		}
 
-		$filename=IkiWiki::titlepage(
+		$filename=IkiWiki::linkpage(
 			IkiWiki::possibly_foolish_untaint(
 				attachment_location($form->field('page')).
 				IkiWiki::basename($filename)));

debian/changelog

@@ -11,6 +11,7 @@ ikiwiki (2.55) UNRELEASED; urgency=low
   * Add allow_symlinks_before_srcdir config setting that can be used to avoid
     a security check that is a good safe default, but problimatic overkill in
     some situations.
+  * attachment: Do not escape _ when determining attachment filenames.
 
  -- Joey Hess <joeyh@debian.org>  Mon, 21 Jul 2008 11:35:46 -0400
 

doc/bugs/attachment:_escaping_underscores_in_filename__63__.mdwn

@@ -15,3 +15,5 @@ Is it a bug or security feature? --[[Paweł|ptecza]]
 >> and `myisam__95__vs__95__ndb.ods` files. When I click "Attachments" link,
 >> I can't see my uploaded files, because there are in another subdirectory
 >> (`myisam__95__vs__95__ndb` instead of `myisam_vs_ndb`).  --[[Paweł|ptecza]]
+
+> [[done]], uses `linkpage` now.