toggle: Fix incompatability between javascript and webkit.

master
Joey Hess 2008-07-25 01:24:20 -04:00
parent f818039140
commit 99b59f2d62
3 changed files with 13 additions and 2 deletions

View File

@ -39,9 +39,9 @@ function toggle(s) {
style.display = "none";
}
function getElementsByClass(class) {
function getElementsByClass(c) {
var ret = new Array();
var pattern = new RegExp("(^|\\s)"+class+"(\\s|$)");
var pattern = new RegExp("(^|\\s)"+c+"(\\s|$)");
var els = document.getElementsByTagName('*');
for (i = 0, j = 0; i < els.length; i++) {
if ( pattern.test(els[i].className) ) {

1
debian/changelog vendored
View File

@ -26,6 +26,7 @@ ikiwiki (2.55) UNRELEASED; urgency=low
* attachment: Do not escape _ when determining attachment filenames.
* Rebuild pages that change their type. (Gabriel McManus)
* monotone: Add support for rename, delete, and also diff. (William Uther)
* toggle: Fix incompatability between javascript and webkit.
-- Joey Hess <joeyh@debian.org> Mon, 21 Jul 2008 11:35:46 -0400

View File

@ -14,3 +14,13 @@ Looking at the Safari Web Inspector, it believes there is a parse error on line
47 function getElementsByClass(class) {
SyntaxError: Parse error
48 var ret = new Array();
> Reproduced in epiphany-webkit on debian.
>
> Also noticed something interesting when I opened the page in vim. It
> highlighted the "class" like a type definition, not a variable. Sure
> enough, replacing with "c" fixed it.
>
> I wonder if webkit is actually in the right here, and using a reseved
> word like, presumably, "class" as a variable name is not legal. As I try
> to ignore javascript as much as possible, I can't say. [[done]] --[[Joey]]