urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
ikiwiki/IkiWiki/Plugin
History
Joey Hess fb3d5b4800 Fixes for behavior changes in perl 5.10's CGI 
Something has changed in CGI.pm in perl 5.10. It used to not care
if STDIN was opened using :utf8, but now it'll mis-encode utf-8 values
when used that way by ikiwiki. Now I have to binmode(STDIN) before
instantiating the CGI object.

In 57bba4dac1, I changed from decoding
CGI::Formbuilder fields to utf-8, to decoding cgi parameters before setting
up the form object. As of perl 5.10, that approach no longer has any effect
(reason unknown). To get correctly encoded values in FormBuilder forms,
they must once again be decoded after the form is set up.

As noted in 57bba4da, this can cause one set of problems for
formbuilder_setup hooks if decode_form_utf8 is called before the hooks, and
a different set if it's called after. To avoid both sets of problems, call
it both before and after. (Only remaining problem is the sheer ugliness and
inefficiency of that..)

I think that these changes will also work with older perl versions, but I
haven't checked.

Also, in the case of the poll plugin, the cgi parameter needs to be
explcitly decoded before it is used to handle utf-8 values. (This may have
always been broken, not sure if it's related to perl 5.10 or not.)
 		2008-05-12 20:44:22 -04:00
..
aggregate.pm aggregate: Add support for web-based triggering of aggregation for people stuck on shared hosting without cron. (Sheesh.) Enabled via the `aggregate_webtrigger` configuration optiom. 2008-05-05 20:20:45 -04:00
amazon_s3.pm paste-o 2008-05-08 16:12:09 -04:00
anonok.pm avoid uninitialised value 2008-05-02 13:01:51 -04:00
brokenlinks.pm * brokenlinks: Don't list the same link multiple times. (%links might 2007-12-16 16:42:18 -05:00
calendar.pm add missing test to avoid uninitialised value when a page with metadata is removed 2008-01-29 17:36:25 -05:00
camelcase.pm * camelcase: Convert to use new linkify and scan hooks rather than the old 2008-02-11 23:04:19 -05:00
conditional.pm * conditional: Improve regexp testing for simple uses of pagespecs 2007-12-28 16:55:20 -05:00
ddate.pm * prettydate,ddate: Don't ignore time formats passed to displaytime 2008-01-28 23:48:27 -05:00
editdiff.pm * Call the formbuilder hook for the edit page. 2007-08-22 21:06:13 +00:00
edittemplate.pm typos 2008-03-21 19:09:29 -04:00
embed.pm * Add embed plugin, which allows embedding content from google maps, video, 2007-08-23 20:14:08 +00:00
external.pm Allow external plugins to return no value 2008-03-21 15:07:10 -04:00
favicon.pm * pagespec_match() has changed to take named parameters, to better allow 2007-04-27 02:55:52 +00:00
fortune.pm * pagespec_match() has changed to take named parameters, to better allow 2007-04-27 02:55:52 +00:00
goodstuff.pm * pagespec_match() has changed to take named parameters, to better allow 2007-04-27 02:55:52 +00:00
googlecalendar.pm * pagespec_match() has changed to take named parameters, to better allow 2007-04-27 02:55:52 +00:00
graphviz.pm revert destpage part of f7bdc2385 2008-03-23 20:01:26 -04:00
haiku.pm * pagespec_match() has changed to take named parameters, to better allow 2007-04-27 02:55:52 +00:00
html.pm * pagespec_match() has changed to take named parameters, to better allow 2007-04-27 02:55:52 +00:00
htmlscrubber.pm Allow colons in URLs after the first slash 2008-02-29 19:29:44 +01:00
htmltidy.pm * htmltidy: Pass --markup yes, in case tidy's config file disabled it. 2008-03-15 13:58:08 -04:00
httpauth.pm * pagespec_match() has changed to take named parameters, to better allow 2007-04-27 02:55:52 +00:00
img.pm img: Support a title attribute, will be passed through to html. Closes: #478718 2008-04-30 12:58:36 -04:00
inline.pm Optimised file statting code when scanning for modified pages; cut the number of system calls in half. (Still room for improvement.) 2008-05-07 14:11:56 -04:00
link.pm * Add the linkify and scan hooks. These hooks can be used to implement 2008-02-11 22:48:27 -05:00
linkmap.pm revert destpage part of f7bdc2385 2008-03-23 20:01:26 -04:00
lockedit.pm fixes 2008-01-07 16:37:19 -05:00
map.pm * map: Fix handling of common prefix to handle the case where it's 2007-12-28 17:22:17 -05:00
mdwn.pm test for Text::Markdown::[Mm]arkdown and use the available one 2008-03-04 20:29:52 -05:00
meta.pm Close meta tag for redir properly. 2008-03-21 00:24:06 -04:00
mirrorlist.pm * pagespec_match() has changed to take named parameters, to better allow 2007-04-27 02:55:52 +00:00
more.pm * Add a destpage parameter to the filter hook. 2007-05-17 19:55:11 +00:00
opendiscussion.pm * opendiscussion: allow editing of the toplevel discussion page 2008-01-07 16:10:32 -05:00
openid.pm optimisation, only load openid module when signing in 2008-03-19 21:12:18 -04:00
orphans.pm * pagespec_match() has changed to take named parameters, to better allow 2007-04-27 02:55:52 +00:00
otl.pm * pagespec_match() has changed to take named parameters, to better allow 2007-04-27 02:55:52 +00:00
pagecount.pm * pagespec_match() has changed to take named parameters, to better allow 2007-04-27 02:55:52 +00:00
pagestats.pm formatting 2007-05-12 19:28:03 +00:00
pagetemplate.pm * pagetemplate: don't display template name 2007-08-05 18:22:21 +00:00
passwordauth.pm * Change formbuilder hook to not be responsible for displaying a form, 2007-12-12 03:15:30 -05:00
pingee.pm pinger/pingee now tested and working 2008-05-06 19:06:53 -04:00
pinger.pm pinger/pingee now tested and working 2008-05-06 19:06:53 -04:00
poll.pm Fixes for behavior changes in perl 5.10's CGI 2008-05-12 20:44:22 -04:00
polygen.pm * pagespec_match() has changed to take named parameters, to better allow 2007-04-27 02:55:52 +00:00
postsparkline.pm only use half the max size 2007-10-25 00:28:40 -04:00
prettydate.pm * prettydate,ddate: Don't ignore time formats passed to displaytime 2008-01-28 23:48:27 -05:00
rawhtml.pm * pagespec_match() has changed to take named parameters, to better allow 2007-04-27 02:55:52 +00:00
recentchanges.pm * Fix expiry of old recentchanges changeset pages. 2008-03-14 18:55:17 -04:00
recentchangesdiff.pm truncate recentchangesdiffs after 200 lines 2008-03-12 15:45:10 -04:00
search.pm * The search plugin needs to override <base> to point to the directory 2008-02-14 15:20:49 -05:00
shortcut.pm Fix ugly display when editing a page that has vanished. 2008-05-02 13:02:07 -04:00
sidebar.pm * Add a destpage parameter to the filter hook. 2007-05-17 19:55:11 +00:00
signinedit.pm fixes 2008-01-07 16:37:19 -05:00
skeleton.pm * Add the linkify and scan hooks. These hooks can be used to implement 2008-02-11 22:48:27 -05:00
smiley.pm process smilies in a sanitize hook 2008-03-21 03:16:28 -04:00
sparkline.pm revert destpage part of f7bdc2385 2008-03-23 20:01:26 -04:00
table.pm * mdwn: When htmlizing text, if it's a single line with no newline, 2008-01-09 14:35:23 -05:00
tag.pm patch from madduck to fix thinko 2007-09-24 16:41:29 +00:00
template.pm * template: Remove bogus htmlize pass added in 2.16. 2008-01-09 14:17:25 -05:00
testpagespec.pm * Add all=no option to conditional, can be used to form conditionals that do 2007-05-09 00:31:49 +00:00
teximg.pm revert destpage part of f7bdc2385 2008-03-23 20:01:26 -04:00
textile.pm * pagespec_match() has changed to take named parameters, to better allow 2007-04-27 02:55:52 +00:00
toc.pm toc: Add the table of contents at sanitize time, rather than at format time. This allows the toc to be displayed when previewing an edit. It also avoids headers in the page template from showing up in the toc. 2008-04-26 15:13:01 -04:00
toggle.pm * Fix some issues with toggles in preview mode. 2007-10-29 17:16:10 -04:00
typography.pm exit with error if Text::Typography cannot be loaded 2007-06-05 19:06:54 +00:00
version.pm add missing test to avoid uninitialised value when a page with metadata is removed 2008-01-29 17:36:25 -05:00
wikitext.pm * pagespec_match() has changed to take named parameters, to better allow 2007-04-27 02:55:52 +00:00