Commit Graph

9262 Commits (e0e94d47162840b01677f4a97c5f581d194ff0fb)

Author SHA1 Message Date
intrigeri e0e94d4716 po(formbuilder): stop hunting down non-existent cases
After some thinking about it, I can't find why the type of a page being created
in the CGI could be restricted to po. So the previous case seems enough.

Signed-off-by: intrigeri <intrigeri@boum.org>
2009-01-26 22:54:40 +01:00
intrigeri fcaa7f6237 Merge commit 'upstream/master' into prv/po 2009-01-26 22:51:50 +01:00
intrigeri dfc50165dd po and doc/todo/need_global_renamepage_hook: response
Signed-off-by: intrigeri <intrigeri@boum.org>
2009-01-26 22:32:59 +01:00
Joey Hess 309719de76 new bug report 2009-01-26 14:21:49 -05:00
Joey Hess 96073d77af review 2009-01-26 14:13:52 -05:00
Joey Hess cf374e97cf add mising hooks and fix syntax error 2009-01-26 14:00:28 -05:00
Joey Hess 73f0011836 remove unnecessary returns
check_canremove/canrename is called only for its side effect (of failing if
removal is not allowed), its return value is never used and returning
something makes that unclear
2009-01-26 13:55:32 -05:00
Joey Hess 53be24789e don't add new exported warning function
Nothing in the po plugin actually uses this function.

The benefit of adding the function in general is debatable, but I'd
prefer to keep the changes involved in merging po at a minimum.
2009-01-26 13:37:57 -05:00
Joey Hess 9750f929ad remove redundant use
use is file-scoped so warnings and strict are already enabled
inside the second package, and IkiWiki is already loaded
(though not imported into this context)
2009-01-26 13:35:50 -05:00
Joey Hess 9e3dc0af60 non-code changes 2009-01-26 13:33:02 -05:00
Joey Hess aff9bf5a7a more unnecessary parens 2009-01-26 13:28:57 -05:00
Joey Hess 093f8534f1 avoid keeping running if a DOS attack is possible 2009-01-26 13:25:05 -05:00
Joey Hess 98f0d672df remove unnecessary parens 2009-01-26 13:24:33 -05:00
Joey Hess c5642119f7 another useless use of scalar
scalar(undef) is undef, so using scalar here had no effect.
Instead make the function return "", probably avoiding an uninitialized
value warning.
2009-01-26 13:21:33 -05:00
Joey Hess 68869d664b remove useless uses of scalar
if (scalar @array) is written idiomatically in perl as
if (@array).
2009-01-26 13:20:56 -05:00
Joey Hess 526d9dbe10 improve some english
I'm still not happy with the clarity of this warning message.
I don't understand when it could happen or why a warning is needed.
2009-01-26 13:15:29 -05:00
Joey Hess 8e738066bc avoid standalone -e or foo syntax
I prefer to use either of the other two syntaxes perl offers, and not this
one.
2009-01-26 13:10:37 -05:00
Joey Hess 66bc27b485 avoid mixing english with translation
"google search" is english which would get mixed in with translated text.
Instead, usr just the plugin name.
2009-01-26 13:08:25 -05:00
Joey Hess 12eb056b33 Merge branch 'master' into po 2009-01-26 13:05:38 -05:00
qiang 9b436a0347 2009-01-26 05:35:55 -05:00
Joey Hess ce39f8e000 git: Fix malformed utf8 recieved from git.
If git log outputs malformed utf8 in, eg, usernames, detect it and fix it
up. This avoids commits such as f71abc92aa
breaking things.
2009-01-25 23:13:14 -05:00
Joey Hess 51cd34afff update 2009-01-25 23:02:11 -05:00
Joey Hess ff9a61b481 update 2009-01-25 22:59:20 -05:00
Joey Hess 0c287d85bb typo 2009-01-25 22:44:38 -05:00
Joey Hess 42b3e13739 format moderation queue only at end, avoid O(N^3) bug
It was calling format hooks for each comment on the page.
When relativedate is enabled, that made it insert <script> tags
for each comment. And the browser loaded the same script over and over,
which was slow on its own. But that was nothing compared to running
the onload even over and over.. especially since the hook system
added a new call to the hook each time it loaded.

For a page with 10 comments, that caused the relativedate DOM parsing
code to run 1000 times, I think. Anyway, it was sloow. Now it runs once.
2009-01-25 22:30:28 -05:00
Joey Hess 9d4f396b13 add reject all marked defer checkbox 2009-01-25 22:25:45 -05:00
Joey Hess 4e21af7671 sort comment queue by time, newest first 2009-01-25 19:45:56 -05:00
Joey Hess 7a7e28c55f add a button to prefs page for comment moderation 2009-01-25 19:04:45 -05:00
Joey Hess 9a5085e512 clean up comment preview
Remove actions from it, and avoid a broken title link.
2009-01-25 18:56:47 -05:00
Joey Hess 35ea80bdfe Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info 2009-01-25 18:50:35 -05:00
Joey Hess 731fc9e7a2 comments: Add a moderation web interface. 2009-01-25 18:49:57 -05:00
Joey Hess 2ecb9e8e79 remove hr under comment actions
The horizontal line was only meant to be displayed under
the actions at the top of a page.
2009-01-25 18:35:18 -05:00
Joey Hess 8129266dad add alt tag 2009-01-25 17:51:00 -05:00
GuenterLadwig 4f098cfd05 2009-01-25 16:41:24 -05:00
GuenterLadwig d5cd831218 2009-01-25 16:40:29 -05:00
GnterLadwig f71abc92aa 2009-01-25 16:37:32 -05:00
GnterLadwig fe8dc7fa42 2009-01-25 16:34:27 -05:00
Joey Hess c154fa5d6c comments: If comment content checks fail, store the comment (in .ikiwiki/comments_pending) for moderator review. 2009-01-25 15:42:13 -05:00
Joey Hess 0cfb159bb0 Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info 2009-01-25 14:40:32 -05:00
Joey Hess ee74e61ffc blogspam: Fix use of blogspam_options and blogspam_server config settings. 2009-01-25 14:37:04 -05:00
Rocco 31a6f1735c vote for Template::Toolkit 2009-01-25 03:39:52 -05:00
Joey Hess caa6a784b0 clarify description of verbose
It enables debug prints, so not just during building, but at runtime.
2009-01-24 13:04:59 -05:00
http://joey.kitenet.net/ a6eb921b9d 2009-01-24 12:43:32 -05:00
qiang 1f87dd2c7d 2009-01-24 12:37:53 -05:00
Joey Hess 7bdc8896df typo 2009-01-23 20:08:52 -05:00
Joey Hess a471ac68c8 Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info 2009-01-23 16:54:13 -05:00
Joey Hess 1c369f1440 mention identica group 2009-01-23 16:46:49 -05:00
qiang 54265c655c 2009-01-23 04:50:07 -05:00
qiang 4a74d70ff5 2009-01-23 04:44:24 -05:00
justin 65af0cceaa followup on pagespec negation 2009-01-22 21:29:53 -05:00