Commit Graph

7997 Commits (cd305909d37546d1f75365f9e92995429927e91a)

Author SHA1 Message Date
Joey Hess 965f7310fe git: Fix handling of utf-8 filenames in recentchanges.
Seems that the problem is that once the \nnn coming from git is converted
to a single character, decode_utf8 decides that this is a standalone
character, and not part of a multibyte utf-8 sequence, and so does nothing.
I tried playing with the utf-8 flag, but that didn't work. Instead, use
decode("utf8"), which doesn't have the same qualms, and successfully
decodes the octets into a utf-8 character.

Rant:

Think for a minute about fact that any and every program that parses git-log,
or git-show, etc output to figure out what files were in a commit needs to
contain this snippet of code, to convert from git-log's wacky output to a
regular character set:

if ($file =~ m/^"(.*)"$/) {
	($file=$1) =~ s/\\([0-7]{1,3})/chr(oct($1))/eg;
}

(And it's only that "simple" if you don't care about filenames with
embedded \n or \t or other control characters.)

Does that strike anyone else as putting the parsing and conversion in the
wrong place (ie, in gitweb, ikiwiki, etc, etc)? Doesn't anyone who actually
uses git with utf-8 filenames get a bit pissed off at seeing \xxx\xxx
instead of the utf-8 in git-commit and other output?
2008-09-25 18:26:42 -04:00
test1 d6d3f3a36b 2008-09-25 18:17:05 -04:00
Joey Hess a4215312d0 response 2008-09-25 17:11:29 -04:00
Joey Hess e1ba137317 attachment: Add admin() pagespec to test if the uploading user is a wiki admin. 2008-09-25 16:49:30 -04:00
Joey Hess 093e815440 aggregate: Avoid uninitialized value warnings for pages with no recorded ctime.
I saw this in the wild, apparently a page was not present on disk, but was
in the aggregate db, and not marked as expired either. Not sure how that
happened, but such pages should get marked as expired since they have an
effectively zero ctime.
2008-09-25 15:38:51 -04:00
Joey Hess 4c6d359b5f Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info 2008-09-25 14:40:50 -04:00
Joey Hess 3f5ba52ee0 recentchanges: Fix redirects to non-page files. 2008-09-25 13:46:12 -04:00
http://ptecza.myopenid.com/ 0720a6f5fb * Response to response to response ;) 2008-09-25 04:42:05 -04:00
Joey Hess 9e55aa7f17 Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info 2008-09-24 21:29:29 -04:00
Joey Hess 3f35e2abbe document silent=yes parameter. 2008-09-24 21:28:59 -04:00
http://www.cse.unsw.edu.au/~willu/ 8e68780b96 Response to response 2008-09-24 21:03:08 -04:00
Joey Hess 9b4c4835c1 add news item for ikiwiki 2.65 2008-09-24 18:49:05 -04:00
Joey Hess b127e86b35 releasing version 2.65 2008-09-24 18:14:09 -04:00
http://ptecza.myopenid.com/ 8b762f8868 * Response 2008-09-24 04:52:26 -04:00
http://www.cse.unsw.edu.au/~willu/ 3c65e5dc93 Add alternate patch 2008-09-24 00:45:03 -04:00
http://www.cse.unsw.edu.au/~willu/ 6036a954a0 Comments 2008-09-23 22:39:21 -04:00
http://www.cse.unsw.edu.au/~willu/ a6769bf663 Response 2008-09-23 22:13:07 -04:00
Joey Hess bc10e4dd01 Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info 2008-09-23 19:34:14 -04:00
Joey Hess e00df8575f rename: Hide type field from rename form when renaming attachments. 2008-09-23 19:31:34 -04:00
Joey Hess e33bbb24e8 changelog 2008-09-23 19:28:05 -04:00
Joey Hess 40dc92a67b multiple rename support is working
most edge cases seem handled too
2008-09-23 19:21:05 -04:00
http://ptecza.myopenid.com/ 9a7a83caa1 * Ping 2008-09-23 18:01:41 -04:00
Joey Hess 544da9b0da Merge branch 'master' into tova 2008-09-23 17:42:38 -04:00
Joey Hess 8e0180d8ca rename, remove: Don't rely on a form parameter to tell whether the page should be treated as an attachment. 2008-09-23 17:41:05 -04:00
Joey Hess cf4db49567 factor out fixlinks 2008-09-23 17:26:46 -04:00
Joey Hess 9b57602394 factor out do_rename 2008-09-23 17:04:01 -04:00
Joey Hess 9cbc46f49a add checkbox to rename subpages too 2008-09-23 16:56:57 -04:00
Joey Hess dfa9556480 responses 2008-09-23 16:17:09 -04:00
Joey Hess 8494104b39 layout 2008-09-23 14:57:13 -04:00
Joey Hess dfe55e8956 Add keepextension parameter to htmlize hook. (Willu) 2008-09-23 13:39:21 -04:00
Joey Hess 9cbcda14ac Print a debug message if a page has multiple source files. 2008-09-23 13:32:41 -04:00
Joey Hess c4777e30a9 allow setup file to enable verbose mode 2008-09-23 13:24:20 -04:00
Joey Hess a32c0ecd51 include perl error in warning about openid
it may be some other module missing, this way you can tell by reading the
log
2008-09-23 12:59:43 -04:00
Joey Hess 7280d84c1c merged 2008-09-23 12:47:36 -04:00
Simon McVittie c7804cafa5 Fix typo in skeleton.pm.example: sessionncgi (with extra n)
(cherry picked from commit 72ffc85d6acb8b99839ac98a2c23dbef410b5666)
2008-09-23 12:47:02 -04:00
http://ptecza.myopenid.com/ 338f0fde60 * Response 2008-09-23 08:34:43 -04:00
chrysn 88beb46def bug report on funny characters in the name 2008-09-23 04:58:35 -04:00
http://smcv.pseudorandom.co.uk/ ba1b9f8562 bug report with patch 2008-09-22 18:36:26 -04:00
http://smcv.pseudorandom.co.uk/ b44ca17f93 2008-09-22 18:29:48 -04:00
http://smcv.pseudorandom.co.uk/ c4fde75f46 Reference patches to beautify redirection URLs 2008-09-22 18:28:39 -04:00
http://smcv.pseudorandom.co.uk/ 2587137775 interesting, I could use this for photo galleries 2008-09-22 18:11:18 -04:00
chrysn b42fdcbaa3 added wishlist item with work-in-progress plugin 2008-09-22 13:12:38 -04:00
http://dmarti.myopenid.com/ cd5e1e76f6 2008-09-22 13:10:05 -04:00
Blanko 3816df7d18 Adding two CSS / themes 2008-09-22 10:31:21 -04:00
http://smcv.pseudorandom.co.uk/ 8ff9430a7d Reference and describe my implementation 2008-09-21 18:12:08 -04:00
Simon McVittie 7f82594410 remove: redirect via urlto(), avoiding mentions of index.html 2008-09-21 18:26:48 +01:00
Simon McVittie 02923917c8 recentchanges: construct redirections via urlto(), avoiding mentions of index.html 2008-09-21 18:26:48 +01:00
Simon McVittie 97e3263ad1 poll: Use urlto to produce redirection URLs, avoiding mentions of index.html 2008-09-21 18:26:48 +01:00
Simon McVittie e73987b01d editpage: beautify redirection URLs, avoiding exposing the implementation detail that index.html exists 2008-09-21 18:26:42 +01:00
http://www.cse.unsw.edu.au/~willu/ 2f3b93a55a Add second, related, patch. 2008-09-21 06:04:37 -04:00