Commit Graph

9014 Commits (80a630a3fb64c4fe9ef7ac6d38962c2959c05fbd)

Author SHA1 Message Date
http://dtrt.org/ faa01bd432 Sort paramater not a problem; Revised steps to reprodce 2008-12-20 19:36:15 -05:00
Joey Hess 6042e607f3 alternate idea 2008-12-20 18:51:09 -05:00
Joey Hess f8cc87e8ee remove signin icons, use title 2008-12-20 18:46:56 -05:00
Joey Hess b7531acb59 tweak author display
Put the icon after the name, mostly because it scans better on
non-graphical browsers where the alt text is displayed. And because the
name is really the more important part.
2008-12-20 18:36:16 -05:00
Joey Hess 8dbb30d346 my try at improving comment styling
Makes it look more like a blog, but not enough to be confusing, and with
nothing as large as in a blog. Removal of the vertical line under the
subject imho makes it easier to scan through comments as each box is a new
one. Bolding the subject seems to make it stand out enough, especially as
its a link now. (Also considered increasing its font size to 110%.)
2008-12-20 18:30:14 -05:00
Joey Hess 7bf121889b note new bug 2008-12-20 18:18:19 -05:00
Joey Hess 1c918a4ec6 response 2008-12-20 18:14:49 -05:00
Joey Hess 5d5732d673 Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info 2008-12-20 18:07:45 -05:00
http://dtrt.org/ dd4dff0350 Workaround and possible cause 2008-12-20 18:06:21 -05:00
Joey Hess 0f03af3816 Merge commit 'smcv/comments' 2008-12-20 17:58:56 -05:00
Joey Hess 92b48bab99 Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info 2008-12-20 17:58:01 -05:00
http://smcv.pseudorandom.co.uk/ 4b3d3f519d 2008-12-20 13:03:44 -05:00
Simon McVittie f94665800c comment.tmpl: make anon/OpenID/signed-in icons independent of smileys 2008-12-20 17:39:55 +00:00
Simon McVittie 045cbb2a14 comments_display: display (?) for anon users, {x} for OpenIDs and {*} for local logins
This is a mockup of Joey's idea; to do it properly, the icons should
move to the basewiki or to a comments underlay, and {x} should be
replaced with an OpenID logo (if one with clear licensing even exists).
2008-12-20 17:34:55 +00:00
Simon McVittie 9e889c39ed comments: Rename COMMENTURL to ADDCOMMENTURL to avoid confusion with COMMENTAUTHORURL
Also refactor page.tmpl to use if/else rather than unless/if.
2008-12-20 17:34:55 +00:00
Simon McVittie 8ed94c0a18 comments: pass COMMENTOPENID to templates 2008-12-20 17:34:55 +00:00
Simon McVittie 8a9f4e225f comments: remove linkuser(), it's been integrated into preprocess() now 2008-12-20 17:34:55 +00:00
Simon McVittie f4e69ed815 _comment directive: if the user looks like an OpenID, store that 2008-12-20 17:34:54 +00:00
Joey Hess ce58338e3d haskell 2008-12-20 11:30:48 -05:00
Joey Hess 6828cd84a1 note 2008-12-20 11:04:45 -05:00
brush 4176c3483d minor edits 2008-12-20 05:58:00 -05:00
brush 39e5de4e33 added details on cgi wrapper creation 2008-12-20 05:56:04 -05:00
http://weakish.int.eu.org/ 80884d33e0 initial page 2008-12-20 04:20:58 -05:00
http://weakish.int.eu.org/ 3d7d29791e vimperator can do this, too. 2008-12-20 04:18:56 -05:00
Joey Hess 61f8ea7f1d avoid uninitialized value
This can happen when a new field,
such as the new lasttry, is added.
2008-12-19 17:57:09 -05:00
Joey Hess 301733ba13 fix comment permalink to always point to comment parent page 2008-12-19 17:33:40 -05:00
Joey Hess 0b002b79b7 update 2008-12-19 17:26:41 -05:00
Joey Hess 4ed092c05b typos 2008-12-19 17:07:54 -05:00
Joey Hess fb8161b845 simplify and compact the comment edit form
Mostly to make it more visually similar to the page edit form.

I'm a bit uncertian about the placement of the page type selector,
and about removing the "Page type". May rethink that.
2008-12-19 14:29:54 -05:00
Joey Hess d0f2ac685b remove 'signed in as foo'
I think users should know who they're signed in as; the edit pages don't
say so there's no reason to here. Also, the user id was not displayed
pretty.
2008-12-19 14:21:48 -05:00
Joey Hess 091c7fd25b add link from comment subject to its permalink 2008-12-19 14:20:07 -05:00
Joey Hess 29cb9027f4 fiddle with comment css classes 2008-12-19 14:14:20 -05:00
Joey Hess 4bdeec4961 remove cruft
wtf does it do? absolutely nothing
2008-12-19 14:09:39 -05:00
Joey Hess 79a787a466 rename comments_form to editcomment 2008-12-19 14:07:22 -05:00
Joey Hess ddabb010b2 rename comments_display to comment 2008-12-19 14:03:26 -05:00
Joey Hess f7fc062a12 replace discussion links on pages with comments link
The thinking here is that having both a Discussion page and comments for
the same page is redundant, and certianly not what you want if you enable
comments for a page. At first I considered making configurable via pagespec
what pages got discussion links. But that would mean testing a new pagespec
for every page, and a redundant config setting to keep in sync. So intead,
take a lead from my previous change to make inlined pages have a comments
link, and change the discussion link at the top of regular pages to link to
their comments.

(Implementation is a bit optimised to avoid redundant pagespec checking.)
2008-12-19 13:55:41 -05:00
Víctor Moral 2c06f5f275 updated spanish translation 2008-12-19 12:45:36 -05:00
Joey Hess 7521dd6c75 jump to comment after posting
Jumping to the just posted comment was the imputus, but I killed a number
of birds here.

Added a INLINEPAGE template variable, which can be used to add anchors to
any inline template.

To keep that sufficiently general, it is the full page name, so the
comment anchors and links changed form.

Got rid of the FIXMEd hardcoded html anchor div.

More importantly, the anchor is now to the very top of the comment, not the
text below. So you can see the title, and how it attributes you.

Avoid changing the permalink of pages that are not really comments, but
happen to contain the _comment directive. I think that behavior was a bug,
though not a likely one to occur since _comment should only really be used
on comment pages.
2008-12-18 20:58:16 -05:00
Joey Hess d7855474fd document how to make a global comments feed 2008-12-18 20:20:42 -05:00
Joey Hess 1d82ac40d4 responses 2008-12-18 20:10:42 -05:00
Joey Hess 7fc83fbd15 Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info 2008-12-18 18:00:03 -05:00
smcv@ a115ff254d Update todo/comments with today's fixes, and thoughts about the remaining items 2008-12-18 21:10:08 +00:00
Joey Hess 65c4ae1ac1 clarify 2008-12-18 14:49:24 -05:00
justin 8414a62e7f 2008-12-18 14:20:59 -05:00
Joey Hess b2439a3e51 pagespec thoughts 2008-12-18 12:53:47 -05:00
Joey Hess 835801a6ff note about comments feed 2008-12-18 12:32:23 -05:00
Joey Hess f3bec255e4 aggregate: If a feed fails to be downloaded, try again immediatly next time aggregation is run, even if the usual time has not passed. Closes: #508622 (Michael Gold) 2008-12-17 21:27:28 -05:00
Joey Hess 385123006e close 2008-12-17 21:17:42 -05:00
Joey Hess 1074d38f0d deletion 2008-12-17 20:40:46 -05:00
Joey Hess 81165dd2e0 jump to comments anchor after post
Not ideal, it would be nicer to jump to the actual comment posted, but no
anchor is available.
2008-12-17 20:29:55 -05:00