Joey Hess
4ee754536d
remove: Fix problem removing pages with utf-8 in the name.
2009-12-14 17:26:48 -05:00
intrigeri
78a095aa42
only pass named parameters to the canremove hook
...
Signed-off-by: intrigeri <intrigeri@boum.org>
2009-01-26 23:07:19 +01:00
Joey Hess
73f0011836
remove unnecessary returns
...
check_canremove/canrename is called only for its side effect (of failing if
removal is not allowed), its return value is never used and returning
something makes that unclear
2009-01-26 13:55:32 -05:00
Joey Hess
12eb056b33
Merge branch 'master' into po
2009-01-26 13:05:38 -05:00
Joey Hess
3547a2a347
fix removal form display
...
The form was misdisplayed when displayed via comment removal.
2009-01-20 11:12:49 -05:00
intrigeri
741b26aa17
remove: implemented a new canremove hook; use it in the po plugin
...
Signed-off-by: intrigeri <intrigeri@boum.org>
2009-01-01 16:44:39 +01:00
Joey Hess
678d467a40
finalise version 3.00 of the plugin api
2008-12-23 16:34:19 -05:00
Joey Hess
bb93fccf06
Coding style change: Remove explcit vim folding markers.
2008-12-17 15:22:16 -05:00
Joey Hess
4669eab596
more work on untrusted committers
...
Wired up check_canedit and check_canremove, still need to deal with
check_canattach, and test.
2008-10-23 16:29:50 -04:00
Joey Hess
fea76a11bc
remove: Avoid $_ breakage. (Stupid, stupid perl.)
...
This avoids another one of those $_ scoping issues where a deep call to a
function that changes $_ clobbers the array that is being looped over.
2008-10-06 16:10:47 -04:00
Joey Hess
3b47dae9ca
remove, rename: Allow acting on attachments as a page is being created.
2008-10-02 12:53:53 -04:00
Joey Hess
9ec9d6901d
Export pagetitle, titlepage, linkpage.
2008-09-27 14:27:42 -04:00
Joey Hess
316ef6571b
pagetype is exported
2008-09-27 13:34:46 -04:00
Joey Hess
7351d545d9
Merge commit 'smcv/beautify'
...
Conflicts:
IkiWiki/Plugin/recentchanges.pm
Note that smcv's approach of using urlto also gets the url right when
redirecting to a non-html file, which is a better approach than my recent
fix to recentchanges
2008-09-27 13:00:48 -04:00
Joey Hess
8e0180d8ca
rename, remove: Don't rely on a form parameter to tell whether the page should be treated as an attachment.
2008-09-23 17:41:05 -04:00
Simon McVittie
7f82594410
remove: redirect via urlto(), avoiding mentions of index.html
2008-09-21 18:26:48 +01:00
Joey Hess
39195de96e
add plugin safe/rebuild info (part 2 of 3)
...
(brain.. melting..)
2008-08-03 17:20:21 -04:00
Joey Hess
762bf0b887
foldage
2008-07-23 19:25:46 -04:00
Joey Hess
cbddb5a4b8
add rcs_commit_staged and rcs_rename
...
Implemented for git and svn so far.
Note that rcs_commit_staged does assume that the rcs has the ability to
"stage" multiple changes for a later commit. Support for this varies, but
all we really care about is staging removals and renames, which, AFAIK, all
modern rcs's support.
2008-07-22 16:14:33 -04:00
Joey Hess
cbf1c8b810
rename checks improvements
2008-07-22 14:01:23 -04:00
Joey Hess
569d31d875
permission checking improvements
...
Break out into function so it can be done up-front before confirmation too.
2008-07-22 13:29:54 -04:00
Joey Hess
0c9fe2f99c
use check_canattach
...
As noted, this may be overkill..
2008-07-21 22:44:19 -04:00
Joey Hess
96c529826d
skeleton rename plugin
2008-07-21 22:30:43 -04:00
Joey Hess
ed05e40566
error if nothing selected
2008-07-21 22:11:24 -04:00
Joey Hess
6e243a45e5
probably redundant symlink check
2008-07-21 21:57:58 -04:00
Joey Hess
7910f1c352
remove debugging
2008-07-21 16:53:46 -04:00
Joey Hess
d9af10a1be
typos
2008-07-21 16:21:59 -04:00
Joey Hess
90de84b442
typos
2008-07-21 16:21:46 -04:00
Joey Hess
b182f5e573
need to untaint..
2008-07-21 16:20:02 -04:00
Joey Hess
2461ce0de6
a few bugfixes
...
Including a check the the file is in the srcdir, as opposed to some other
directory.
2008-07-21 16:18:28 -04:00
Joey Hess
af9c5e4bba
support for removing attachments
2008-07-21 15:02:29 -04:00
Joey Hess
a1df39ed4a
simplified confirmation form
...
also, there's no titlepage conversion issues
2008-07-21 14:22:57 -04:00
Joey Hess
b1b5860b29
touchups
2008-07-21 14:03:39 -04:00
Joey Hess
494e7ab8ba
redirect after removal
2008-07-21 13:53:34 -04:00
Joey Hess
c924c76bd8
basically, removal works
...
Still need to consider all the edge cases..
2008-07-21 13:50:12 -04:00
Joey Hess
a204f86786
form tweaks; use title
2008-07-21 13:31:58 -04:00
Joey Hess
b286ce04cb
implemented form state saving and retrieval
...
This is overkill for delete, since it's only used on Cancel. But it will be
crucial for rename, so as to restore any pending edits after renaming a
page.
2008-07-21 13:23:07 -04:00
Joey Hess
8e7b31a19c
basic removal form skeleton
2008-07-21 12:54:23 -04:00