urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

use check_canattach 

As noted, this may be overkill..
master
Joey Hess 2008-07-21 22:44:19 -04:00
parent f9cbe871ad
commit 0c9fe2f99c
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
IkiWiki/Plugin/remove.pm
View File

@ -129,9 +129,6 @@ sub sessioncgi ($$) { #{{{
error(sprintf(gettext("%s does not exist"),
htmllink("", "", $page, noimageinline => 1)));
}
# Must be editiable.
IkiWiki::check_canedit($page, $q, $session);
# Must exist on disk, and be a regular file.
my $file=$pagesources{$page};
@ -141,12 +138,20 @@ sub sessioncgi ($$) { #{{{
elsif (-l "$config{srcdir}/$file" && ! -f _) {
error(sprintf(gettext("%s is not a file"), $file));
}
# Must be editiable.
IkiWiki::check_canedit($page, $q, $session);
# This is sorta overkill, but better safe
# than sorry. If a user can't upload an
# attachment, don't let them delete it.
if ($q->param("attachment")) {
IkiWiki::Plugin::attachment::check_canattach($session, $page, $file);
}
push @files, IkiWiki::possibly_foolish_untaint($file);
}
# TODO check attachment limits.
# Do removal, and update the wiki.
require IkiWiki::Render;
if ($config{rcs}) {