Commit Graph

5376 Commits (50a5ab3c4e1db5beb18d86873143e7715fd5b27e)

Author SHA1 Message Date
Joey Hess 90f63e0f53 testing 2008-07-08 22:30:43 -04:00
Joey Hess 744ead213a testing 2008-07-08 22:29:24 -04:00
Joey Hess 6e5c6bc4c3 testing 2008-07-08 22:27:38 -04:00
Joey Hess 3d2309b60b testing 2008-07-08 22:26:37 -04:00
Joey Hess 849792d4d8 response 2008-07-08 20:47:29 -04:00
Joey Hess b774349f39 web commit by https://id.mayfirst.org/jamie/ 2008-07-08 20:42:28 -04:00
Joey Hess 479407da4d web commit by https://id.mayfirst.org/jamie/ 2008-07-08 20:41:45 -04:00
Joey Hess 7541622fe9 response 2008-07-08 19:28:20 -04:00
Joey Hess 61479665b4 web commit by AndrewGreenberg: bad formatting on bug report, sorry. 2008-07-08 19:15:40 -04:00
Joey Hess ae4d377946 web commit by AndrewGreenberg: Added nasty URL edit bug in 2.52. 2008-07-08 19:14:11 -04:00
Joey Hess 3e8abb8b53 response 2008-07-08 18:35:48 -04:00
Joey Hess 2897749a80 web commit by mrled 2008-07-08 18:13:49 -04:00
Joey Hess 03d7f84f28 Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
Conflicts:

	doc/bugs/attachment:_failed_to_get_filehandle.mdwn
2008-07-08 18:12:33 -04:00
Joey Hess ad02f69836 attachment: Support perl 5.8's buggy version of CGI.pm.
This is truely horribly disgusting. CGI::tmpFileName, in current perls, is
an undocumented function (which should be a clue..) that takes the original
filename of an uploaded attachment, and returns the name of the tempfile
that CGI has stored it in.

In old perls, though, CGI::tmpFileName does not take a filename. It takes
a key from the object's {'.tmpfiles'} hash. This key is something
crazy like '*Fh::fh00001group' -- apparently the stringification of a
filehandle object.

Just to add to the fun, tmpFileName doesn't take the key, it expects a
refernce to the key. Argh?!

But the fun doesn't stop there, because in perl 5.8, CGI.pm is also broken
in two other ways. The upload() method is supposed to return a filehandle
to the temp file. It doesn't. The param() method is supposed to return
a filehandle to the temp file, that stringifies to the original filename.
It returns just the original filename, no filehandle.

Combine all these bugs, and you end up with this disgusting commit. Since
I have no way to get the filehandle, I *need* to get the tempfile name.
If I had the filehandle, I could probably pass it into tmpFileName, and
it might strigify to the right key name. But I don't, so the only way to
determine the key is to grub through the .tmpfiles hash ourselves.

And finally, one the temp file name is discovered, a filehandle can finally
be obtained by (re)opening it.

I recommend that this commit be reverted when perl 5.8 is a mercifully
faded memory.

I'm really, really, really glad I'm actually being paid for working on
this right now!
2008-07-08 18:10:53 -04:00
Joey Hess 9e51b2ccb5 web commit by http://ptecza.myopenid.com/: * Thanks! 2008-07-08 17:05:33 -04:00
Joey Hess 905d99e248 web commit by HenrikBrixAndersen: This happens on FreeBSD as well 2008-07-08 17:04:28 -04:00
Joey Hess 4a86457750 reproduced 2008-07-08 16:59:21 -04:00
Joey Hess f529518948 response 2008-07-08 16:21:17 -04:00
Joey Hess 5a9faa0aff rm 2008-07-08 16:18:11 -04:00
Joey Hess 8cac2ac23e web commit by http://ptecza.myopenid.com/: * The bug still occurs 2008-07-08 16:11:18 -04:00
Joey Hess ac69ab522c add dist-bugs 2008-07-08 14:18:09 -04:00
Joey Hess dd8be0ab32 merge 2008-07-08 13:47:02 -04:00
Joey Hess e0855f84d3 response 2008-07-08 13:46:01 -04:00
Joey Hess b2d983c670 web commit by mrled 2008-07-08 13:16:11 -04:00
Joey Hess 23e95143b8 web commit by mrled 2008-07-08 13:08:46 -04:00
Joey Hess d7380c1afa web commit by mrled 2008-07-08 13:04:23 -04:00
Joey Hess 03639ff4d0 web commit by mrled 2008-07-08 13:03:46 -04:00
Joey Hess 1f192b330e web commit by mrled 2008-07-08 13:02:25 -04:00
Joey Hess 6f3c980e2b undef $fh before opening 2008-07-08 12:16:36 -04:00
Joey Hess 6fc21e9d3d web commit by http://ptecza.myopenid.com/: * Still no success 2008-07-08 11:56:31 -04:00
Joey Hess bae7306828 response 2008-07-08 11:47:03 -04:00
Joey Hess 66f35e30dc another try at dealing with CGI.pm problem
open the temp file if all attempts to get a fd fail
2008-07-08 11:25:30 -04:00
Joey Hess 5ccd0cb518 web commit by http://ptecza.myopenid.com/: * Debugging again 2008-07-08 11:15:48 -04:00
Joey Hess fd6ebaeee7 possible fix 2008-07-08 10:43:45 -04:00
Joey Hess 0ffe0872c1 web commit by http://ptecza.myopenid.com/: * Next debbuging 2008-07-08 10:24:24 -04:00
Joey Hess fac6743cad new thing to try 2008-07-08 10:16:29 -04:00
Joey Hess 0c9a504948 fix fix 2008-07-08 10:05:57 -04:00
Joey Hess f8a86765d2 close 2008-07-08 10:04:43 -04:00
Joey Hess 42dcf37016 web commit by http://ptecza.myopenid.com/: * Missing Apache2 version 2008-07-08 10:00:48 -04:00
Joey Hess 99113e50ef web commit by http://ptecza.myopenid.com/: * Response 2008-07-08 09:58:33 -04:00
Joey Hess 04319b030c split out separate bug 2008-07-08 09:49:29 -04:00
Joey Hess 7e16fa3a1e response 2008-07-08 09:46:29 -04:00
Joey Hess f156308aef attachment: Fix an uninitialised value warning when editing a page that currently has no attachments. 2008-07-08 09:40:46 -04:00
Joey Hess eb4a6fb01a Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info 2008-07-08 09:37:58 -04:00
Joey Hess 67e4a21bd6 web commit by http://jcflack.myopenid.com/ 2008-07-08 09:29:19 -04:00
Joey Hess db77e342fa web commit by http://ptecza.myopenid.com/: * Problem with colon in report page name 2008-07-08 06:42:33 -04:00
Joey Hess 7977fe382a web commit by http://ptecza.myopenid.com/: * Problem with uploading attachments 2008-07-08 06:29:20 -04:00
Joey Hess a3f6385448 web commit by http://ptecza.myopenid.com/: * Thanks! 2008-07-08 04:27:12 -04:00
Joey Hess d1d0c6667d add an interesting ikiwiki site I stumbled across 2008-07-08 02:42:12 -04:00
Joey Hess ff5ebd4b8d test 2008-07-07 19:15:14 -04:00
Joey Hess 611bf8edb6 response 2008-07-07 16:41:52 -04:00
Joey Hess 9de2ebb983 move to todo 2008-07-07 16:40:48 -04:00
Joey Hess 488f92426d clarify how an item is wishlisted 2008-07-07 16:40:28 -04:00
Joey Hess b5eaf7bff5 undo wishlist changes
You don't want to post new wishlist items, really, as they're lower
priority than just todo items. :-) Anyway, I want to keep wishlist and
todos both under todo/ so that they can easily be changed from one state to
another. And the inline caused items to be created under wishlist/ , but
didn't actually inline them.
2008-07-07 16:38:19 -04:00
Joey Hess d5ad2c6522 web commit by http://dmarti.myopenid.com/ 2008-07-07 15:15:35 -04:00
Joey Hess b37a98c207 web commit by http://www.openidfrance.fr/beaufils 2008-07-07 15:11:57 -04:00
Joey Hess dd8712fe2a web commit by http://dmarti.myopenid.com/ 2008-07-07 15:03:57 -04:00
Joey Hess 9205e0ff82 resp 2008-07-07 14:46:15 -04:00
Joey Hess 8d81dee411 web commit by http://jcflack.myopenid.com/ 2008-07-07 14:00:46 -04:00
Joey Hess 9a61666a35 testing 2008-07-07 13:32:18 -04:00
Joey Hess aa67a17336 example of how to limit to specific directory 2008-07-07 12:12:48 -04:00
Joey Hess ea7c1374fb new idea 2008-07-07 12:11:49 -04:00
Joey Hess f4f3063aca typo the second 2008-07-07 12:08:45 -04:00
Joey Hess f1b86d1016 response 2008-07-07 12:07:47 -04:00
Joey Hess d657aa8a9e typo 2008-07-07 12:07:12 -04:00
Joey Hess 14d959b246 web commit by http://ptecza.myopenid.com/: * Enabling attachment plugin 2008-07-07 08:44:43 -04:00
Joey Hess 43e0691a50 search: generate configuration files once only when rebuilding (Gabriel McManus) 2008-07-07 01:55:06 -04:00
Joey Hess 2aac9cdb30 Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info 2008-07-07 01:51:49 -04:00
Joey Hess 85c75c8f9d web commit by http://gmcmanus.myopenid.com/: search: create configuration once only on rebuild 2008-07-07 00:57:39 -04:00
Joey Hess 7ff928b721 wishlist 2008-07-06 19:27:57 -04:00
Joey Hess 474f51a7a2 add news item for ikiwiki 2.52 2008-07-06 19:24:48 -04:00
Joey Hess 2f3a279f68 add virus checking to attachments plugin 2008-07-06 17:36:26 -04:00
Joey Hess 05124f9a86 editpage escaping fixes
* The editpage form now uses the raw page name, not the page title, in its
  'page' cgi parameter. Using the title was ambiguous and made it
  impossible to tell between some pages, like "foo/bar" and "foo__47__bar",
  sometimes causing the wrong page to be edited.
* This change means that some edit links need to be updated.
  Force a rebuild on upgrade to this version.
* Above change also allowed really fixing escaped slashes from the blogpost
  form.
2008-07-06 15:52:04 -04:00
Joey Hess f6b86bfa5b delete duplicate page, move comment to correct place 2008-07-06 14:10:31 -04:00
Joey Hess 4bf7785760 response 2008-07-06 14:07:33 -04:00
Joey Hess 674ed7e706 response 2008-07-06 14:05:01 -04:00
Joey Hess 3ec9621734 remove; user also has a bbb page 2008-07-06 13:59:35 -04:00
Joey Hess 17bb3cec42 rm 2008-07-06 13:58:47 -04:00
Joey Hess 33e9442f4a Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info 2008-07-06 13:58:47 -04:00
Joey Hess c1687b1f1e typo 2008-07-06 12:27:57 -04:00
Joey Hess bb3036317d web commit by http://www.openidfrance.fr/beaufils 2008-07-05 22:18:04 -04:00
Joey Hess f0ff71af55 web commit by http://www.openidfrance.fr/beaufils 2008-07-05 22:04:12 -04:00
Joey Hess 50c813c715 web commit by http://www.openidfrance.fr/beaufils 2008-07-05 22:03:05 -04:00
Joey Hess 2d17c87fd9 web commit by http://www.openidfrance.fr/beaufils 2008-07-05 22:01:49 -04:00
Joey Hess 2f8e4500f9 web commit by http://www.openidfrance.fr/beaufils 2008-07-05 22:00:39 -04:00
Joey Hess c2937e14ed web commit by http://www.openidfrance.fr/beaufils 2008-07-05 21:55:55 -04:00
Joey Hess 316bee3786 web commit by http://www.openidfrance.fr/beaufils 2008-07-05 21:52:57 -04:00
Joey Hess 8b59050ea7 web commit by http://www.openidfrance.fr/beaufils 2008-07-05 21:52:03 -04:00
Joey Hess f9ddfe56b9 web commit by http://www.openidfrance.fr/beaufils 2008-07-05 21:51:23 -04:00
Joey Hess f5dca442fe web commit by http://www.openidfrance.fr/beaufils 2008-07-05 21:50:47 -04:00
Joey Hess 6a863b58a6 web commit by http://www.openidfrance.fr/beaufils 2008-07-05 21:49:46 -04:00
Joey Hess 4db44caf06 web commit by http://www.openidfrance.fr/beaufils 2008-07-05 21:45:21 -04:00
Joey Hess 4d7ccdc8e5 web commit by http://www.openidfrance.fr/beaufils 2008-07-05 21:44:03 -04:00
Joey Hess 69108f446f web commit by http://tychoish.livejournal.com/: further clarification. 2008-07-04 08:03:54 -04:00
Joey Hess 560372bf94 web commit by http://subvert.org.uk/~bma/ 2008-07-04 03:21:16 -04:00
Joey Hess df736d3089 web commit by http://subvert.org.uk/~bma/ 2008-07-04 03:14:29 -04:00
Joey Hess d426894c99 web commit by http://tychoish.livejournal.com/ 2008-07-03 23:14:47 -04:00
Joey Hess 2d64fdd22e web commit by http://tychoish.livejournal.com/ 2008-07-03 23:00:37 -04:00
Joey Hess cb06a01b75 web commit by http://jcflack.myopenid.com/ 2008-07-03 18:21:07 -04:00
Joey Hess f7755e5e01 web commit by http://jcflack.myopenid.com/ 2008-07-03 18:20:25 -04:00
Joey Hess f4e06ba343 web commit by http://jcflack.myopenid.com/ 2008-07-03 18:12:01 -04:00
Joey Hess bb7ef14a2b update 2008-07-03 13:42:49 -04:00
Joey Hess 3e11f8b6aa argh 2008-07-03 13:42:25 -04:00
Joey Hess 77ebc0ad8c web commit by http://jcflack.myopenid.com/ 2008-07-03 13:40:30 -04:00
Joey Hess 8526fd8293 web commit by http://alcopop.org/me/openid/: nudge headers down to h2 2008-07-03 11:41:36 -04:00
Joey Hess f0d9bf00dc web commit by bremner: mention mnemosyne-blog 2008-07-03 03:40:56 -04:00
Joey Hess ca6d9da279 link to pagespec/attachment 2008-07-02 18:22:49 -04:00
Joey Hess 2888b03556 move attachment pagespec extensions docs to its own page
in the basewiki, so I can link to it there
2008-07-02 18:22:49 -04:00
Joey Hess 84e6c4fa66 add mimetype checking 2008-07-02 18:22:49 -04:00
Joey Hess 190d328e40 web commit by Petteri: Added debian.fi 2008-07-02 17:48:16 -04:00
Joey Hess cea18902a1 test 2 2008-07-02 17:45:29 -04:00
Joey Hess fc95aab71c test commit 2008-07-02 17:39:33 -04:00
Joey Hess f8e33430d8 update 2008-07-02 16:47:29 -04:00
Joey Hess 2354613391 response; move to bug report 2008-07-02 16:43:13 -04:00
Joey Hess c987aee47a Merge branch 'tova' 2008-07-02 16:38:13 -04:00
Joey Hess aaca4902dd update 2008-07-02 16:37:17 -04:00
Joey Hess ba707cdcd9 add user and ip support to attachment pagespecs 2008-07-02 16:33:35 -04:00
Joey Hess 895faed642 toggle: Add support for toggles that are open by default.
Also fix to work in preview mode.
2008-07-02 16:02:01 -04:00
Joey Hess 33b60e67a7 web commit by http://jcflack.myopenid.com/ 2008-07-02 15:26:52 -04:00
Joey Hess acc5db090e web commit by http://jcflack.myopenid.com/ 2008-07-02 09:30:36 -04:00
Joey Hess 16b22252a0 response 2008-07-01 18:45:54 -04:00
Joey Hess 96da041907 Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info into tova 2008-07-01 18:41:47 -04:00
Joey Hess 8c6577c3dc web commit by http://jcflack.myopenid.com/ 2008-07-01 17:55:16 -04:00
Joey Hess 0ffcafc130 attachment doc updates 2008-07-01 17:54:23 -04:00
Joey Hess 19749d0c5b web commit by http://liw.fi/: commented on ü and ikiwiki 2.50 2008-07-01 14:29:35 -04:00
Joey Hess b01ee9b3b3 add an ispage limit 2008-06-30 23:17:01 -04:00
Joey Hess 0a37c45f32 basic attachment plugin, unfinished
Currently includes UI, and a few tests of the attachment, as well as the
framework to extend pagespecs to test attachments. Does not actually save
the file yet.
2008-06-30 22:58:33 -04:00
Joey Hess 23eb492c60 web commit by https://id.mayfirst.org/jamie/ 2008-06-30 15:37:38 -04:00
Joey Hess ed88d219d7 web commit by https://id.mayfirst.org/jamie/: woops - forgot the patch 2008-06-30 15:34:13 -04:00
Joey Hess 6cc12f559a web commit by https://id.mayfirst.org/jamie/ 2008-06-30 15:29:26 -04:00
Joey Hess b64ca35f8a web commit by https://id.mayfirst.org/jamie/ 2008-06-30 15:19:22 -04:00
Joey Hess c6d04bfd35 web commit by https://id.mayfirst.org/jamie/: Moving discussion to discussion page. 2008-06-30 15:18:44 -04:00
Joey Hess 822495d23f add news item for ikiwiki 2.51 2008-06-29 14:19:03 -04:00
Joey Hess 524ee496e3 remove bad link 2008-06-29 14:18:00 -04:00
Joey Hess b219656aef remove map, was added for testing and committed by accident 2008-06-29 14:15:33 -04:00
Joey Hess 8ab0d60271 web commit by http://ptecza.myopenid.com/: * Plural 2008-06-29 11:15:38 -04:00
Joey Hess c44ae04702 web commit by http://ptecza.myopenid.com/: * Thanks! 2008-06-29 11:02:55 -04:00
Joey Hess 4a46e91147 web commit by http://hendry.iki.fi/: feeds === sitemaps 2008-06-29 07:58:44 -04:00
Joey Hess 3bd4592326 web commit by bremner: response to Joey, segue into musing about replacing tagged addresses with pseudoheaders 2008-06-29 06:12:48 -04:00
Joey Hess b66f9a1981 call format hooks when generating page previews
* toc: Revert change in 2.45 that made it run at sanitize time. This breaks
  use of toc in a sidebar.
* Call format hooks when generating page previews, thus fixing toc display
  there, as well as fixing inlins to again display in page previews, since
  it's started using format hooks. This also allows several other things,
  like embed, that use format hooks, to work during page preview time.
* Format hooks should not rely on getting an entire html document, as they
  will only get the body during page preview.
* toggle: Deal with preview mode when adding javascript.
2008-06-28 23:08:24 -04:00
Joey Hess f8fe1247bd bug 2008-06-28 22:46:12 -04:00
Joey Hess 9c41769673 idea 2008-06-28 20:50:48 -04:00
Joey Hess f26a6e152f web commit by http://bremner.myopenid.com/: cosmetic changes 2008-06-28 18:10:13 -04:00
Joey Hess 17e96f6248 web commit by http://bremner.myopenid.com/: musings about encodings 2008-06-28 18:03:52 -04:00
Joey Hess 20359c493c patch review 2008-06-28 17:16:08 -04:00
Joey Hess 00503f25cd smiley: Generate links relative to the destpage. (Fixes a reversion from 2.41.) 2008-06-28 16:58:43 -04:00
Joey Hess 1ab9eb3420 web commit by simon: link fix 2008-06-28 16:51:57 -04:00
Joey Hess c19fa8fbb0 response 2008-06-28 16:51:18 -04:00
Joey Hess 4bd101204e web commit by simon: link fix 2008-06-28 16:50:59 -04:00
Joey Hess a43b5ecf0a rm 2008-06-28 16:43:46 -04:00