Commit Graph

8929 Commits (31a6f1735cf98a565a82b7cc720d6b2e8e49ad13)

Author SHA1 Message Date
http://smcv.pseudorandom.co.uk/ 94cdf076ed trivial bug with patch 2008-12-21 12:23:34 -05:00
Simon McVittie ca1437c9e1 Another comments improvement 2008-12-21 17:18:43 +00:00
Simon McVittie 9e5f504e1a rssitem.tmpl: include comments URL (HTML only) 2008-12-21 17:16:24 +00:00
Simon McVittie 3feebe31b6 atomitem.tmpl: include comments URLs (HTML and Atom versions) 2008-12-21 17:16:12 +00:00
Simon McVittie d0d598e429 comments: substitute commentsurl and atomcommentsurl for use in feeds 2008-12-21 17:15:49 +00:00
http://smcv.pseudorandom.co.uk/ bd376db3a8 Mention a patch to improve OpenID display 2008-12-21 11:43:43 -05:00
Simon McVittie f0c76aa51c Add a regression test for &openiduser 2008-12-21 16:37:20 +00:00
Simon McVittie 801dc76bf0 openid: in &openiduser, allow subdirectory-style providers to end with '/'
This improves the display of OpenIDs like 'http://id.mayfirst.org/jamie/'
(taking an example from the IkiWiki commit log).
2008-12-21 16:36:22 +00:00
Simon McVittie e0cd19f30b openid: in &openiduser, let domain-style providers have arbitrarily many subdomains
This leads to better display for OpenIDs like smcv.pseudorandom.co.uk
and thm.id.fedoraproject.org (to take a couple of examples from the
IkiWiki commit history).
2008-12-21 16:36:10 +00:00
Simon McVittie 7bdeee2032 Record another couple of pending bugfixes 2008-12-21 15:39:40 +00:00
Simon McVittie c42f174e65 beautify_urlpath: add a regression test 2008-12-21 15:24:53 +00:00
Simon McVittie 5b1cf21a35 beautify_urlpath: if path already starts with ./, don't add another ./ 2008-12-21 15:24:42 +00:00
Simon McVittie 0844bd0b15 beautify_urlpath: add ./ before checking for /index.html
This fixes a bug: when a page links to its own #comments anchor you would
get a link like "index.html#comments" rather than "./#comments".
2008-12-21 15:23:59 +00:00
Simon McVittie 95b3bbbf7c comments: run pagetemplate hooks
This fixes the bug that comments are always said to be from an anonymous
user at an unknown IP address.
2008-12-21 15:08:14 +00:00
Simon McVittie bc66a00b90 comments: linkify and preprocess preview with correct 'page' param 2008-12-21 15:07:36 +00:00
Simon McVittie cdccf7a80c Merge commit 'origin/comments' into comments-joey 2008-12-21 10:17:45 +00:00
Simon McVittie bd80ca37d5 todo/comments: Properly escape inline HTML 2008-12-21 10:17:23 +00:00
Simon McVittie 2884d20950 todo/comments: reorganise by status 2008-12-21 10:11:48 +00:00
Simon McVittie ee24feece0 comments: note fixed things and recommend merging origin/comments 2008-12-21 10:08:53 +00:00
http://smcv.pseudorandom.co.uk/ c85e7c1bf4 fix markdown 2008-12-21 04:31:49 -05:00
Joey Hess c84fcdd32a meta: Process meta date during scan pass so that the date will always affect sorting in inlines. 2008-12-21 01:52:08 -05:00
Joey Hess da947bea4b analysis 2008-12-21 01:41:00 -05:00
Joey Hess 5c669ab226 comment layout change
I saw a layout similar to this on blogger, and I sorta like it

The dash avoids parens sitting next to each other in some cases.
2008-12-21 01:04:19 -05:00
Joey Hess 7304d6bd72 Merge branch 'master' into comments 2008-12-21 01:04:03 -05:00
http://dtrt.org/ fc077f6956 Response; added shell code and html formating to reproduction steps 2008-12-20 22:28:20 -05:00
Joey Hess c53a3a1d3e avoid storing transient state in pagestate
None of the comment state needs to be stored through the a later run of
ikiwiki, so move it all from pagestate to a more transient storage.

This is assuming that we'll never want to add pagespecs to search against
the comment state. Pagespecs like author() are why the meta plugin does
store its meta data in pagestate -- the data can be needed later to match
against.
2008-12-20 20:55:38 -05:00
Joey Hess 155ebc3dbd response 2008-12-20 20:27:42 -05:00
http://dtrt.org/ faa01bd432 Sort paramater not a problem; Revised steps to reprodce 2008-12-20 19:36:15 -05:00
Joey Hess 6042e607f3 alternate idea 2008-12-20 18:51:09 -05:00
Joey Hess f8cc87e8ee remove signin icons, use title 2008-12-20 18:46:56 -05:00
Joey Hess b7531acb59 tweak author display
Put the icon after the name, mostly because it scans better on
non-graphical browsers where the alt text is displayed. And because the
name is really the more important part.
2008-12-20 18:36:16 -05:00
Joey Hess 8dbb30d346 my try at improving comment styling
Makes it look more like a blog, but not enough to be confusing, and with
nothing as large as in a blog. Removal of the vertical line under the
subject imho makes it easier to scan through comments as each box is a new
one. Bolding the subject seems to make it stand out enough, especially as
its a link now. (Also considered increasing its font size to 110%.)
2008-12-20 18:30:14 -05:00
Joey Hess 7bf121889b note new bug 2008-12-20 18:18:19 -05:00
Joey Hess 1c918a4ec6 response 2008-12-20 18:14:49 -05:00
Joey Hess 5d5732d673 Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info 2008-12-20 18:07:45 -05:00
http://dtrt.org/ dd4dff0350 Workaround and possible cause 2008-12-20 18:06:21 -05:00
Joey Hess 0f03af3816 Merge commit 'smcv/comments' 2008-12-20 17:58:56 -05:00
Joey Hess 92b48bab99 Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info 2008-12-20 17:58:01 -05:00
http://smcv.pseudorandom.co.uk/ 4b3d3f519d 2008-12-20 13:03:44 -05:00
Simon McVittie f94665800c comment.tmpl: make anon/OpenID/signed-in icons independent of smileys 2008-12-20 17:39:55 +00:00
Simon McVittie 045cbb2a14 comments_display: display (?) for anon users, {x} for OpenIDs and {*} for local logins
This is a mockup of Joey's idea; to do it properly, the icons should
move to the basewiki or to a comments underlay, and {x} should be
replaced with an OpenID logo (if one with clear licensing even exists).
2008-12-20 17:34:55 +00:00
Simon McVittie 9e889c39ed comments: Rename COMMENTURL to ADDCOMMENTURL to avoid confusion with COMMENTAUTHORURL
Also refactor page.tmpl to use if/else rather than unless/if.
2008-12-20 17:34:55 +00:00
Simon McVittie 8ed94c0a18 comments: pass COMMENTOPENID to templates 2008-12-20 17:34:55 +00:00
Simon McVittie 8a9f4e225f comments: remove linkuser(), it's been integrated into preprocess() now 2008-12-20 17:34:55 +00:00
Simon McVittie f4e69ed815 _comment directive: if the user looks like an OpenID, store that 2008-12-20 17:34:54 +00:00
Joey Hess ce58338e3d haskell 2008-12-20 11:30:48 -05:00
Joey Hess 6828cd84a1 note 2008-12-20 11:04:45 -05:00
brush 4176c3483d minor edits 2008-12-20 05:58:00 -05:00
brush 39e5de4e33 added details on cgi wrapper creation 2008-12-20 05:56:04 -05:00
http://weakish.int.eu.org/ 80884d33e0 initial page 2008-12-20 04:20:58 -05:00