c945952381
attachment: Support adding attachments to pages even as they are being created.
2008-10-02 12:48:06 -04:00
9ec9d6901d
Export pagetitle, titlepage, linkpage.
2008-09-27 14:27:42 -04:00
316ef6571b
pagetype is exported
2008-09-27 13:34:46 -04:00
e1ba137317
attachment: Add admin() pagespec to test if the uploading user is a wiki admin.
2008-09-25 16:49:30 -04:00
b9efeba972
humansize moved to filecheck
...
It's not used there, but it makes sense to keep it there as it's the
inverse of parsesize.
2008-08-27 15:31:48 -04:00
78e34fbdc2
filecheck: New plugin factoring out the PageSpec additions that were originally part of the attachment plugin.
2008-08-25 19:52:34 -04:00
d50376a05d
default to looking at page source file if no file is specified
...
This will allow these pagespecs to be used a bit more generally.
2008-08-12 15:34:47 -04:00
6fb6d51524
fix inverted test
2008-08-06 01:15:48 -04:00
3905645342
add plugin safe/rebuild info (part 3 of 3)
2008-08-03 19:36:11 -04:00
903213e63f
add plugin safe/rebuild info (part 1 of 2)
...
too many plugins.. brain exploding..
2008-08-03 16:40:12 -04:00
0f06504422
remove description_html, add link
2008-08-03 14:36:17 -04:00
4708aeceb3
websetup form display done
2008-08-02 16:41:37 -04:00
190a845fe1
hide deprecated values if empty after save
2008-08-01 17:39:17 -04:00
bb394fdae8
admin prefs move to setup file, stage 1
...
The locked pages configuration is moving to a locked_pages option in the
setup file, and the allowed attachments configuration to
allowed_attachments. The admin prefs page can still be used for these, but
that's depreacted and will only be shown if there's currently a value.
2008-08-01 16:45:04 -04:00
42ac4ec009
remove default values in getsetup
...
They were a bit confusing, since they did not actually set the default, and
example values are sufficient.
2008-07-26 21:07:15 -04:00
8051316904
add missing setup options, tweak others' display
2008-07-26 19:28:15 -04:00
d0bd30824e
Merge branch 'master' into autoconfig
2008-07-25 19:27:15 -04:00
b7bf566f55
attachment: Use relative paths when inserting links.
2008-07-25 19:22:29 -04:00
1f8b0460c3
added getsetup hooks for all plugins up to recentchanges
2008-07-25 18:05:55 -04:00
762bf0b887
foldage
2008-07-23 19:25:46 -04:00
335a6a59e6
Merge branch 'master' into tova
2008-07-23 15:00:07 -04:00
1d1767192c
attachment: Do not escape _ when determining attachment filenames.
2008-07-23 14:58:39 -04:00
9776bbf853
Don't allow uploading an attachment with the same name as an existing page, to avoid confusion.
2008-07-22 17:12:20 -04:00
bac47cdecd
make message a bit more generic
2008-07-22 15:06:59 -04:00
ac1226031e
avoid uninitialised value
2008-07-22 13:23:11 -04:00
f9cbe871ad
factor out check_canattach
...
Other plugins will need to use this.
2008-07-21 22:41:31 -04:00
06709cdf31
improve error message if virus checker fails w/o output
2008-07-09 16:53:03 -04:00
ad02f69836
attachment: Support perl 5.8's buggy version of CGI.pm.
...
This is truely horribly disgusting. CGI::tmpFileName, in current perls, is
an undocumented function (which should be a clue..) that takes the original
filename of an uploaded attachment, and returns the name of the tempfile
that CGI has stored it in.
In old perls, though, CGI::tmpFileName does not take a filename. It takes
a key from the object's {'.tmpfiles'} hash. This key is something
crazy like '*Fh::fh00001group' -- apparently the stringification of a
filehandle object.
Just to add to the fun, tmpFileName doesn't take the key, it expects a
refernce to the key. Argh?!
But the fun doesn't stop there, because in perl 5.8, CGI.pm is also broken
in two other ways. The upload() method is supposed to return a filehandle
to the temp file. It doesn't. The param() method is supposed to return
a filehandle to the temp file, that stringifies to the original filename.
It returns just the original filename, no filehandle.
Combine all these bugs, and you end up with this disgusting commit. Since
I have no way to get the filehandle, I *need* to get the tempfile name.
If I had the filehandle, I could probably pass it into tmpFileName, and
it might strigify to the right key name. But I don't, so the only way to
determine the key is to grub through the .tmpfiles hash ourselves.
And finally, one the temp file name is discovered, a filehandle can finally
be obtained by (re)opening it.
I recommend that this commit be reverted when perl 5.8 is a mercifully
faded memory.
I'm really, really, really glad I'm actually being paid for working on
this right now!
2008-07-08 18:10:53 -04:00
2e5785907d
explicitly set form type to multipart
...
This is the default in unstable's formbuilder, but not in stable's,
and CGI multipart is needed for fule uploads.
2008-07-08 17:18:02 -04:00
22839215fb
check for tempfile being empty
2008-07-08 16:21:01 -04:00
6f3c980e2b
undef $fh before opening
2008-07-08 12:16:36 -04:00
66f35e30dc
another try at dealing with CGI.pm problem
...
open the temp file if all attempts to get a fd fail
2008-07-08 11:25:30 -04:00
71f10579c0
attachment: Support old versions of CGI.pm that lack an upload method.
2008-07-08 10:42:58 -04:00
f156308aef
attachment: Fix an uninitialised value warning when editing a page that currently has no attachments.
2008-07-08 09:40:46 -04:00
2f3a279f68
add virus checking to attachments plugin
2008-07-06 17:36:26 -04:00
788c1e9eca
avoid uninitialised value warnings
2008-07-06 17:35:50 -04:00
4e949e8a31
link to pagespec/attachment
2008-07-02 18:07:34 -04:00
efd5f9ffb3
factor out glob2re
2008-07-02 17:33:37 -04:00
b941827420
add mimetype checking
2008-07-02 17:30:00 -04:00
ba707cdcd9
add user and ip support to attachment pagespecs
2008-07-02 16:33:35 -04:00
1289beb53b
xhtml fixes
2008-07-02 16:08:48 -04:00
d593533af5
attachments interface visibility toggling
2008-07-02 15:42:32 -04:00
ed25c2abf2
fixes
2008-07-01 20:35:54 -04:00
883da338a4
some fit and finish fixes
2008-07-01 19:05:15 -04:00
0abaf5aaae
only show one sig fig
2008-07-01 18:41:30 -04:00
e8a13c32ba
display human sizes
2008-07-01 18:40:42 -04:00
8441d31535
add both kinds of links
2008-07-01 18:08:31 -04:00
c1e9e121b7
basic attachment list
2008-07-01 17:19:38 -04:00
14cb2b0869
save attachments when page is saved too
...
A user might specify an attachment, but not click the upload button,
and just save the whole page instead.
2008-07-01 16:13:47 -04:00
1405006fbf
check attachments in and refresh
2008-07-01 15:35:01 -04:00
e87c3ae6df
add allowed attachments field to admin prefs
2008-07-01 14:02:30 -04:00
d7ca2f8f9b
fix expensive move code path
2008-07-01 13:48:07 -04:00
7cd40ea4eb
better approach for cgi upload disabling
...
Make it a config setting, this way subtle load order issues don't come into
play. (As much?)
2008-07-01 13:43:32 -04:00
5aee8d937d
bugfixes
2008-07-01 13:39:02 -04:00
a78a981792
attachment location
...
Put the attachment in a subdir of the page it's attached to,
unless that page is an "index" page.
2008-07-01 13:31:09 -04:00
de6ed410bc
reorder
...
canedit should fail first as it's a less expensive and harder to pass test
2008-07-01 13:22:11 -04:00
dbf23748dd
call check_canedit
...
Needed to prevent uploads of locked pages as attachments.
2008-07-01 13:20:42 -04:00
cec45b69da
bugfix; support pagetype of "0"
2008-07-01 00:43:19 -04:00
4fa115fdb5
copy the attachment into srcdir
2008-07-01 00:42:42 -04:00
49514f39f6
fix some messages
2008-06-30 23:32:08 -04:00
b01ee9b3b3
add an ispage limit
2008-06-30 23:17:01 -04:00
622033f5d6
minor improvements
2008-06-30 23:04:37 -04:00
0a37c45f32
basic attachment plugin, unfinished
...
Currently includes UI, and a few tests of the attachment, as well as the
framework to extend pagespecs to test attachments. Does not actually save
the file yet.
2008-06-30 22:58:33 -04:00
Joey Hess