urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

web commit by http://madduck.myopenid.com/: add patch/git commit

master
Joey Hess 2008-02-29 13:32:19 -05:00
parent 8ebf6acd80
commit 6a60c225fe
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
doc/bugs/No_link_for_blog_items_when_filename_contains_a_colon.mdwn
View File

@ -2,7 +2,9 @@ Since upgrading from Ikiwiki 2.20 to 2.32.3 (from Debian Lenny), I don't get hyp
EDIT: I just found that in this wiki under <http://ikiwiki.info/bugs/done/> the entry "mailto: links not properly generated in rss/atom feeds" also doesn't have a hyperlink - at least it's not a problem with my config only ;-) EDIT: I just found that in this wiki under <http://ikiwiki.info/bugs/done/> the entry "mailto: links not properly generated in rss/atom feeds" also doesn't have a hyperlink - at least it's not a problem with my config only ;-)
[[madduck]]: I traced this down to `htmlscrubber`. If disabled, it works. If enabled, then `$safe_url_regexp` determines the URL unsafe because of the colon and hence removes the `src` attribute. [[madduck]]: I traced this down to `htmlscrubber`. If disabled, it works. If
enabled, then `$safe_url_regexp` determines the URL unsafe because of the
colon and hence removes the `src` attribute.
Digging into this, I find that [[rfc 3986]] pretty much discourages colons in Digging into this, I find that [[rfc 3986]] pretty much discourages colons in
filenames: filenames:
@ -17,4 +19,8 @@ by `../` anyway, so that makes them okay again.
The solution still seems not to use colons. The solution still seems not to use colons.
In any case, `htmlscrubber` should get a new regexp, courtesy of dato: `[^:]+($|\/)`. I have tested and verified this. In any case, `htmlscrubber` should get a new regexp, courtesy of dato:
`[^:]+($|\/)`. I have tested and verified this.
[Commit/patch
be0b4f60](http://git.madduck.net/v/code/ikiwiki.git?a=commit;h=be0b4f603f918444b906e42825908ddac78b7073) fixes this.