From 6a60c225fea0524a4d722553d05d85641742b565 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 29 Feb 2008 13:32:19 -0500 Subject: [PATCH] web commit by http://madduck.myopenid.com/: add patch/git commit --- ..._for_blog_items_when_filename_contains_a_colon.mdwn | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/doc/bugs/No_link_for_blog_items_when_filename_contains_a_colon.mdwn b/doc/bugs/No_link_for_blog_items_when_filename_contains_a_colon.mdwn index 8f320ec3b..5c32bc591 100644 --- a/doc/bugs/No_link_for_blog_items_when_filename_contains_a_colon.mdwn +++ b/doc/bugs/No_link_for_blog_items_when_filename_contains_a_colon.mdwn @@ -2,7 +2,9 @@ Since upgrading from Ikiwiki 2.20 to 2.32.3 (from Debian Lenny), I don't get hyp EDIT: I just found that in this wiki under the entry "mailto: links not properly generated in rss/atom feeds" also doesn't have a hyperlink - at least it's not a problem with my config only ;-) -[[madduck]]: I traced this down to `htmlscrubber`. If disabled, it works. If enabled, then `$safe_url_regexp` determines the URL unsafe because of the colon and hence removes the `src` attribute. +[[madduck]]: I traced this down to `htmlscrubber`. If disabled, it works. If +enabled, then `$safe_url_regexp` determines the URL unsafe because of the +colon and hence removes the `src` attribute. Digging into this, I find that [[rfc 3986]] pretty much discourages colons in filenames: @@ -17,4 +19,8 @@ by `../` anyway, so that makes them okay again. The solution still seems not to use colons. -In any case, `htmlscrubber` should get a new regexp, courtesy of dato: `[^:]+($|\/)`. I have tested and verified this. +In any case, `htmlscrubber` should get a new regexp, courtesy of dato: +`[^:]+($|\/)`. I have tested and verified this. + +[Commit/patch +be0b4f60](http://git.madduck.net/v/code/ikiwiki.git?a=commit;h=be0b4f603f918444b906e42825908ddac78b7073) fixes this.