urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

web commit by cjb: Suggested patch for 302 redirect after page creation when using bzr

master
Joey Hess 2008-04-10 00:07:59 -04:00
parent 914a5645a5
commit 675236d251
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
doc/todo/quieten-bzr.mdwn 100644
View File

@ -0,0 +1,20 @@
The _bzr_ plug echoes "added: somefile.mdwn" when it adds somefile.mdwn to the repository. As a result, the redirect performed after a new article is created fails because the _bzr_ output comes before the HTTP headers.
The fix is simply to call `bzr` with the _--quiet_ switch. Something like this applied to _bzr.pm_ works for me:
46c46
< my @cmdline = ("bzr", $config{srcdir}, "update");
---
> my @cmdline = ("bzr", "update", "--quiet", $config{srcdir});
74c74
< my @cmdline = ("bzr", "commit", "-m", $message, "--author", $user,
---
> my @cmdline = ("bzr", "commit", "--quiet", "-m", $message, "--author", $user,
86c86
< my @cmdline = ("bzr", "add", "$config{srcdir}/$file");
---
> my @cmdline = ("bzr", "add", "--quiet", "$config{srcdir}/$file");
94a95,97
> eval q{use CGI 'escapeHTML'};
> error($@) if $@;
>