From 675236d251cfbfa698470392f627e62591cd726b Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Thu, 10 Apr 2008 00:07:59 -0400 Subject: [PATCH] web commit by cjb: Suggested patch for 302 redirect after page creation when using bzr --- doc/todo/quieten-bzr.mdwn | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 doc/todo/quieten-bzr.mdwn diff --git a/doc/todo/quieten-bzr.mdwn b/doc/todo/quieten-bzr.mdwn new file mode 100644 index 000000000..78f9c0b55 --- /dev/null +++ b/doc/todo/quieten-bzr.mdwn @@ -0,0 +1,20 @@ +The _bzr_ plug echoes "added: somefile.mdwn" when it adds somefile.mdwn to the repository. As a result, the redirect performed after a new article is created fails because the _bzr_ output comes before the HTTP headers. + +The fix is simply to call `bzr` with the _--quiet_ switch. Something like this applied to _bzr.pm_ works for me: + + 46c46 + < my @cmdline = ("bzr", $config{srcdir}, "update"); + --- + > my @cmdline = ("bzr", "update", "--quiet", $config{srcdir}); + 74c74 + < my @cmdline = ("bzr", "commit", "-m", $message, "--author", $user, + --- + > my @cmdline = ("bzr", "commit", "--quiet", "-m", $message, "--author", $user, + 86c86 + < my @cmdline = ("bzr", "add", "$config{srcdir}/$file"); + --- + > my @cmdline = ("bzr", "add", "--quiet", "$config{srcdir}/$file"); + 94a95,97 + > eval q{use CGI 'escapeHTML'}; + > error($@) if $@; + >