Issue with ul and div tag closure when returning empty map

master
harishcm 2009-07-20 10:40:29 -04:00 committed by Joey Hess
parent 9fb0d03c5a
commit 3fef1fbd0d
1 changed files with 23 additions and 0 deletions

View File

@ -18,3 +18,26 @@ We'd also very much like to have an option to display the title of the page inst
There's a patch implementing this in [[!debbug 484510]]. It needs a few fixes There's a patch implementing this in [[!debbug 484510]]. It needs a few fixes
before I merge it. Now applied. --[[Joey]] before I merge it. Now applied. --[[Joey]]
----
I noticed that when the pagespec returns no map items, the map plugin does not close off the ul and div tags. Below is a simple patch
that seems to work on the examples I tried. I am a beginner so please help me out here. Thanks. --[[harishcm]]
--- a/map.pm
+++ b/map.pm
@@ -81,6 +81,13 @@
my $openli=0;
my $addparent="";
my $map = "<div class='map'>\n<ul>\n";
+
+ # Return properly closed $map if %mapitems is empty
+ if (!scalar(keys %mapitems)) {
+ $map .= "</ul>\n</div>\n";
+ return $map;
+ }
+
foreach my $item (sort keys %mapitems) {
my @linktext = (length $mapitems{$item} ? (linktext => $mapitems{$item}) : ());
$item=~s/^\Q$common_prefix\E\///