From 3fef1fbd0d555497988e719a680be38df11a5397 Mon Sep 17 00:00:00 2001 From: harishcm Date: Mon, 20 Jul 2009 10:40:29 -0400 Subject: [PATCH] Issue with ul and div tag closure when returning empty map --- doc/plugins/map/discussion.mdwn | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/doc/plugins/map/discussion.mdwn b/doc/plugins/map/discussion.mdwn index c724a6492..c031ab14c 100644 --- a/doc/plugins/map/discussion.mdwn +++ b/doc/plugins/map/discussion.mdwn @@ -18,3 +18,26 @@ We'd also very much like to have an option to display the title of the page inst There's a patch implementing this in [[!debbug 484510]]. It needs a few fixes before I merge it. Now applied. --[[Joey]] + +---- + +I noticed that when the pagespec returns no map items, the map plugin does not close off the ul and div tags. Below is a simple patch +that seems to work on the examples I tried. I am a beginner so please help me out here. Thanks. --[[harishcm]] + + --- a/map.pm + +++ b/map.pm + @@ -81,6 +81,13 @@ + my $openli=0; + my $addparent=""; + my $map = "
\n\n
\n"; + + return $map; + + } + + + foreach my $item (sort keys %mapitems) { + my @linktext = (length $mapitems{$item} ? (linktext => $mapitems{$item}) : ()); + $item=~s/^\Q$common_prefix\E\/// +