2008-08-29 02:02:55 +02:00
|
|
|
First, thanks again for making this plugin.
|
|
|
|
|
|
|
|
I don't know if this is a problem for [[plugins/attachment]], but there seems to
|
|
|
|
be no way to detect text/plain using File::MimeInfo::Magic::magic().
|
|
|
|
There is a heuristic ::default that decides between text/plain and application/octet-stream.
|
|
|
|
|
|
|
|
Would you be receptive to a patch that e.g. called File::MimeInfo::Magic::default()
|
|
|
|
if ::magic() returns undef? --[[DavidBremner]]
|
2008-08-29 02:18:05 +02:00
|
|
|
|
|
|
|
> Yes, that looks to be ok. --[[Joey]]
|
2008-08-30 16:08:09 +02:00
|
|
|
|
|
|
|
>> OK, here is such a patch. One modification of previous behaviour is that
|
|
|
|
>> that if default returns undef, this is returned. As far as I understand
|
|
|
|
>> the code/doc for File::MimeInfo, under is used only as an error return
|
|
|
|
>> for ::default
|
|
|
|
|
2008-09-01 21:00:15 +02:00
|
|
|
>>> Applied
|