2008-08-29 02:02:55 +02:00
|
|
|
First, thanks again for making this plugin.
|
|
|
|
|
|
|
|
|
|
I don't know if this is a problem for [[plugins/attachment]], but there seems to
|
|
|
|
|
be no way to detect text/plain using File::MimeInfo::Magic::magic().
|
|
|
|
|
There is a heuristic ::default that decides between text/plain and application/octet-stream.
|
|
|
|
|
|
|
|
|
|
Would you be receptive to a patch that e.g. called File::MimeInfo::Magic::default()
|
|
|
|
|
if ::magic() returns undef? --[[DavidBremner]]
|
2008-08-29 02:18:05 +02:00
|
|
|
|
|
|
|
|
> Yes, that looks to be ok. --[[Joey]]
|
2008-08-30 16:08:09 +02:00
|
|
|
|
|
|
|
|
>> OK, here is such a patch. One modification of previous behaviour is that
|
|
|
|
|
>> that if default returns undef, this is returned. As far as I understand
|
|
|
|
|
>> the code/doc for File::MimeInfo, under is used only as an error return
|
|
|
|
|
>> for ::default
|
|
|
|
|
<pre>
|
|
|
|
|
From 84f40d7fa822c6cc09506cca2dbf38a8b19f8bb7 Mon Sep 17 00:00:00 2001
|
|
|
|
|
From: David Bremner <bremner@unb.ca>
|
|
|
|
|
Date: Fri, 29 Aug 2008 20:46:20 -0300
|
|
|
|
|
Subject: [PATCH] call File::MimeInfo::default if ::magic() returns undef
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
IkiWiki/Plugin/filecheck.pm | 2 +-
|
|
|
|
|
1 files changed, 1 insertions(+), 1 deletions(-)
|
|
|
|
|
|
|
|
|
|
diff --git a/IkiWiki/Plugin/filecheck.pm b/IkiWiki/Plugin/filecheck.pm
|
|
|
|
|
index 9c7a8db..a94c02b 100644
|
|
|
|
|
--- a/IkiWiki/Plugin/filecheck.pm
|
|
|
|
|
+++ b/IkiWiki/Plugin/filecheck.pm
|
|
|
|
|
@@ -127,7 +127,7 @@ sub match_mimetype ($$;@) { #{{{
|
|
|
|
|
}
|
|
|
|
|
my $mimetype=File::MimeInfo::Magic::magic($file);
|
|
|
|
|
if (! defined $mimetype) {
|
|
|
|
|
- $mimetype="unknown";
|
|
|
|
|
+ $mimetype=File::MimeInfo::Magic::default($file);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
my $regexp=IkiWiki::glob2re($wanted);
|
|
|
|
|
--
|
|
|
|
|
1.5.6.3
|
|
|
|
|
</pre>
|
