g1smo
/
qmk_firmware
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix non-functional RGBLIGHT_EFFECT_TWINKLE on ARM (#19335)

master
Joshua Diamond 2022-12-15 03:18:54 -05:00 committed by GitHub
parent 8e50f1c5f5
commit 571a9794af
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
quantum/rgblight/rgblight.c
View File

@ -1480,6 +1480,8 @@ void rgblight_effect_twinkle(animation_status_t *anim) {
return (v * scale) >> 8; return (v * scale) >> 8;
} }
const uint8_t trigger = scale((uint16_t)0xFF * RGBLIGHT_EFFECT_TWINKLE_PROBABILITY, 127 + rgblight_config.val / 2);
for (uint8_t i = 0; i < rgblight_ranges.effect_num_leds; i++) { for (uint8_t i = 0; i < rgblight_ranges.effect_num_leds; i++) {
TwinkleState *t = &(led_twinkle_state[i]); TwinkleState *t = &(led_twinkle_state[i]);
HSV * c = &(t->hsv); HSV * c = &(t->hsv);
@ -1498,7 +1500,7 @@ void rgblight_effect_twinkle(animation_status_t *anim) {
t->life--; t->life--;
uint8_t unscaled = frac(breathe_calc(frac(t->life, t->max_life)) - bottom, top - bottom); uint8_t unscaled = frac(breathe_calc(frac(t->life, t->max_life)) - bottom, top - bottom);
c->v = scale(rgblight_config.val, unscaled); c->v = scale(rgblight_config.val, unscaled);
} else if (rand() < scale((uint16_t)RAND_MAX * RGBLIGHT_EFFECT_TWINKLE_PROBABILITY, 127 + rgblight_config.val / 2)) { } else if ((rand() % 0xFF) < trigger) {
// This LED is off, but was randomly selected to start brightening // This LED is off, but was randomly selected to start brightening
if (random_color) { if (random_color) {
c->h = rand() % 0xFF; c->h = rand() % 0xFF;