use replace() over rename() to have cross-platform overwriting (#8148)

2020-02-11 10:37:15 +01:00 · 2020-02-11 10:37:15 +01:00 · 310b2f1be4
parent 1fed214490
commit 310b2f1be4
1 changed files with 1 additions and 1 deletions
--- a/lib/python/milc.py
+++ b/lib/python/milc.py
@ -571,7 +571,7 @@ class MILC(object):

        # Move the new config file into place atomically
        if os.path.getsize(tmpfile.name) > 0:
-            os.rename(tmpfile.name, str(self.config_file))
+            os.replace(tmpfile.name, str(self.config_file))
        else:
            self.log.warning('Config file saving failed, not replacing %s with %s.', str(self.config_file), tmpfile.name)