* [Keymap] merge jdelkins userspace and associated keymaps
* Add copyright & license info
* Change rgblight_config.enable to rgblight_is_enabled()
* Update keyboards/dz60/keymaps/jdelkins/keymap.c
Co-authored-by: Drashna Jaelre <drashna@live.com>
* Update keyboards/dz60/keymaps/jdelkins/keymap.c
Co-authored-by: Drashna Jaelre <drashna@live.com>
* Update keyboards/dz60/keymaps/jdelkins/keymap.c
Co-authored-by: Drashna Jaelre <drashna@live.com>
* Remove superfluous includes
* Change EXTRAFLAGS+=-flto to LTO_ENABLE=yes
* Remove unnecessary jdelkins_ss symlink in users
* Add copyright and license notices
* Use preferred way to determine capslock / numlock state
Co-authored-by: Drashna Jaelre <drashna@live.com>
* Add #pragma once to a header
Co-authored-by: Drashna Jaelre <drashna@live.com>
* Include QMK_KEYBOARD_H only once, in userspace header
* Remove unnecessary initialization in matrix_init_keymap
* Do process_record_keymap before cases handled in process_record_user
* Reorganize & simplify secrets feature enablement
* Use tap_code16
Co-authored-by: Ryan <fauxpark@gmail.com>
* Remove superfluous break
Co-authored-by: Ryan <fauxpark@gmail.com>
* Remove copyright from rules.mk
Co-authored-by: Ryan <fauxpark@gmail.com>
* Remove copyright from rules.mk
Co-authored-by: Ryan <fauxpark@gmail.com>
* Use tap_code16
Co-authored-by: Ryan <fauxpark@gmail.com>
* include "print.h" instead of <print.h>
Co-authored-by: Ryan <fauxpark@gmail.com>
* Use tap_cod16
Co-authored-by: Ryan <fauxpark@gmail.com>
* Use tap_code16
Co-authored-by: Ryan <fauxpark@gmail.com>
* Use tap_code16
Co-authored-by: Ryan <fauxpark@gmail.com>
* Use tap_code16
Co-authored-by: Ryan <fauxpark@gmail.com>
* Remove copyright from rules.mk
Co-authored-by: Ryan <fauxpark@gmail.com>
* add #pragma once to a header
Co-authored-by: Ryan <fauxpark@gmail.com>
* include "print.h" instead of <print.h>
Co-authored-by: Ryan <fauxpark@gmail.com>
* Remove copyright from rules.mk
Co-authored-by: Ryan <fauxpark@gmail.com>
* Remove copyright from rules.mk
Co-authored-by: Ryan <fauxpark@gmail.com>
* Remove copyright from rules.mk
Co-authored-by: Ryan <fauxpark@gmail.com>
* Use tap_code16
Co-authored-by: Ryan <fauxpark@gmail.com>
* Use tap_code16
Co-authored-by: Ryan <fauxpark@gmail.com>
* Use :flash target where possible
* Remove special case flash target and use PROGRAM_CMD
* dz60/jdelkins_ss: use tap_code16
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
* Add Per Key functionality for AutoShift (#11536)
* LED Matrix: Reactive effect buffers & advanced indicators (#12588)
* [Keyboard] kint36: switch to sym_eager_pk debouncing (#12626)
* [Keyboard] kint2pp: reduce input latency by ≈10ms (#12625)
* LED Matrix: Split (#12633)
* [CI] Format code according to conventions (#12650)
* feat: infinite timeout for leader key (#6580)
* feat: implement leader_no_timeout logic
* docs(leader_key): infinite leader timeout docs
* Format code according to conventions (#12680)
* Update ADC driver for STM32F1xx, STM32F3xx, STM32F4xx (#12403)
* Fix default ADC_RESOLUTION for ADCv3 (and ADCv4)
Recent ChibiOS update removed ADC_CFGR1_RES_10BIT from the ADCv3 headers
(that macro should not have been there, because ADCv3 has CFGR instead of
CFGR1). Fix the default value for ADC_RESOLUTION to use ADC_CFGR_RES_10BITS
if it is defined (that name is used for ADCv3 and ADCv4).
* Update ADC docs to match the actually used resolution
ADC driver for ChibiOS actually uses the 10-bit resolution by default
(probably to match AVR); fix the documentation accordingly. Also add
both ADC_CFGR_RES_10BITS and ADC_CFGR1_RES_10BIT constants (these names
differ according to the ADC implementation in the particular MCU).
* Fix pinToMux() for B12 and B13 on STM32F3xx
Testing on STM32F303CCT6 revealed that the ADC mux values for B12 and
B13 pins were wrong.
* Add support for all possible analog pins on STM32F1xx
Added ADC mux values for pins A0...A7, B0, B1, C0...C5 on STM32F1xx
(they are the same at least for STM32F103x8 and larger F103 devices, and
also F102, F105, F107 families). Actually tested on STM32F103C8T6
(therefore pins C0...C5 were not tested).
Pins F6...F10, which are present on STM32F103x[C-G] in 144-pin packages,
cannot be supported at the moment, because those pins are connected only
to ADC3, but the ChibiOS ADC driver for STM32F1xx supports only ADC1.
* Add support for all possible analog pins on STM32F4xx
Added ADC mux values for pins A0...A7, B0, B1, C0...C5 and optionally
F3...F10 (if STM32_ADC_USE_ADC3 is enabled). These mux values are
apparently the same for all F4xx devices, except some smaller devices may
not have ADC3.
Actually tested on STM32F401CCU6, STM32F401CEU6, STM32F411CEU6 (using
various WeAct “Blackpill” boards); only pins A0...A7, B0, B1 were tested.
Pins F3...F10 are inside `#if STM32_ADC_USE_ADC3` because some devices
which don't have ADC3 also don't have the GPIOF port, therefore the code
which refers to Fx pins does not compile.
* Fix STM32F3xx ADC mux table in documentation
The ADC driver documentation had some errors in the mux table for STM32F3xx.
Fix this table to match the datasheet and the actual code (mux settings for
B12 and B13 were also tested on a real STM32F303CCT6 chip).
* Add STM32F1xx ADC pins to the documentation
* Add STM32F4xx ADC pins to the documentation
* Add initial support for tinyuf2 bootloader (when hosted on F411 blackpill) (#12600)
* Add support for jumping to tinyuf2 bootloader. Adds blackpill UF2 example.
* Update flashing.md
* Update chconf.h
* Update config.h
* Update halconf.h
* Update mcuconf.h
* eeprom driver: Refactor where eeprom driver initialisation (and EEPROM emulation initialisation) occurs to make it non-target-specific. (#12671)
* Add support for MCU = STM32F446 (#12619)
* Add support for MCU = STM32F446
* Update platforms/chibios/GENERIC_STM32_F446XE/configs/config.h
* Restore mcuconf.h to the one used by RT-STM32F446RE-NUCLEO64
* stm32f446: update mcuconf.h and board.h for 16MHz operation, with USB enabled, and other peripherals disabled.
* Format code according to conventions (#12682)
* Format code according to conventions (#12687)
* Add STM32L433 and L443 support (#12063)
* initial L433 commit
* change to XC
* fix L433
* disable all peripherals
* update system and peripheral clocks
* 433 change
* use its own board files
* revert its own board files
* l433 specific change
* fix stm32l432xx define
* remove duplicate #define
* fix bootloader jump
* move to L443xx and add i2c2, spi2, usart3 to mcuconf.h
* move to L443
* move to L443
* fix sdmmc in mcuconf.h
* include STM32L443
* add L443
* Include L443 in compatible microcontrollers
* Include L443 in compatible microcontrollers
* Update config bootloader jump description
* Update ChibiOS define reasoning
* Update quantum/mcu_selection.mk
* fix git conflict
* Updated Function96 with V2 files and removed chconf.h and halconf.h (#12613)
* Fix bad PR merge for #6580. (#12721)
* Change RGB/LED Matrix to use a simple define for USB suspend (#12697)
* [CI] Format code according to conventions (#12731)
* Fixing transport's led/rgb matrix suspend state logic (#12770)
* [CI] Format code according to conventions (#12772)
* Fix comment parsing (#12750)
* Added OLED fade out support (#12086)
* fix some references to bin/qmk that slipped in (#12832)
* Resolve a number of warnings in `qmk generate-api` (#12833)
* New command: qmk console (#12828)
* stash poc
* stash
* tidy up implementation
* Tidy up slightly for review
* Tidy up slightly for review
* Bodge environment to make tests pass
* Refactor away from asyncio due to windows issues
* Filter devices
* align vid/pid printing
* Add hidapi to the installers
* start preparing for multiple hid_listeners
* udev rules for hid_listen
* refactor to move closer to end state
* very basic implementation of the threaded model
* refactor how vid/pid/index are supplied and parsed
* windows improvements
* read the report directly when usage page isn't available
* add per-device colors, the choice to show names or numbers, and refactor
* add timestamps
* Add support for showing bootloaders
* tweak the color for bootloaders
* Align bootloader disconnect with connect color
* add support for showing all bootloaders
* fix the pyusb check
* tweaks
* fix exception
* hide a stack trace behind -v
* add --no-bootloaders option
* add documentation for qmk console
* Apply suggestions from code review
* pyformat
* clean up and flesh out KNOWN_BOOTLOADERS
* Remove pointless SERIAL_LINK_ENABLE rules (#12846)
* Make Swap Hands use PROGMEM (#12284)
This converts the array that the Swap Hands feature uses to use PROGMEM,
and to read from that array, as such. Since this array never changes at
runtime, there is no reason to keep it in memory. Especially for AVR
boards, as memory is a precious resource.
* Fix another bin/qmk reference (#12856)
* [Keymap] Turn OLED off on suspend in soundmonster keymap (#10419)
* Fixup build errors on `develop` branch. (#12723)
* LED Matrix: Effects! (#12651)
* Fix syntax error when compiling for ARM (#12866)
* Remove KEYMAP and LAYOUT_kc (#12160)
* alias KEYMAP to LAYOUT
* remove KEYMAP and LAYOUT_kc
* Add setup, clone, and env to the list of commands we allow even with broken modules (#12868)
* Rename `point_t` -> `led_point_t` (#12864)
* [Keyboard] updated a vendor name / fixed minor keymap issues (#12881)
* Add missing LED Matrix suspend code to suspend.c (#12878)
* LED Matrix: Documentation (#12685)
* Deprecate `send_unicode_hex_string()` (#12602)
* Fix spelling mistake regarding LED Matrix in split_common. (#12888)
* [Keymap] Fix QWERTY/DVORAK status output for kzar keymap (#12895)
* Use milc.subcommand.config instead of qmk.cli.config (#12915)
* Use milc.subcommand.config instead
* pyformat
* remove the config test
* Add function to allow repeated blinking of one layer (#12237)
* Implement function rgblight_blink_layer_repeat to allow repeated blinking of one layer at a time
* Update doc
* Rework rgblight blinking according to requested change
* optimize storage
* Fixup housekeeping from being invoked twice per loop. (#12933)
* matrix: wait for row signal to go HIGH for every row (#12945)
I noticed this discrepancy (last row of the matrix treated differently than the
others) when optimizing the input latency of my keyboard controller, see also
https://michael.stapelberg.ch/posts/2021-05-08-keyboard-input-latency-qmk-kinesis/
Before this commit, when tuning the delays I noticed ghost key presses when
pressing the F2 key, which is on the last row of the keyboard matrix: the
dead_grave key, which is on the first row of the keyboard matrix, would be
incorrectly detected as pressed.
After this commit, all keyboard matrix rows are interpreted correctly.
I suspect that my setup is more susceptible to this nuance than others because I
use GPIO_INPUT_PIN_DELAY=0 and hence don’t have another delay that might mask
the problem.
* ensure we do not conflict with existing keymap aliases (#12976)
* Add support for up to 4 IS31FL3733 drivers (#12342)
* Convert Encoder callbacks to be boolean functions (#12805)
* [Keyboard] Fix Terrazzo build failure (#12977)
* Do not hard set config in CPTC files (#11864)
* [Keyboard] Corne - Remove legacy revision support (#12226)
* [Keymap] Update to Drashna keymap and user code (based on develop) (#12936)
* Add Full-duplex serial driver for ARM boards (#9842)
* Document LED_MATRIX_FRAMEBUFFER_EFFECTS (#12987)
* Backlight: add defines for default level and breathing state (#12560)
* Add dire message about LUFA mass storage bootloader (#13014)
* [Keyboard] Remove redundant legacy and common headers for crkbd (#13023)
Was causing compiler errors on some systems.
* Fix keyboards/keymaps for boolean encoder callback changes (#12985)
* `backlight.c`: include `eeprom.h` (#13024)
* Add changelog for 2021-05-29 Breaking Changes merge (#12939)
* Add ChangeLog for 2021-05-29 Breaking Changes Merge: initial version
* Add recent develop changes
* Sort recent develop changes
* Remove sections for ChibiOS changes per tzarc
No ChibiOS changes this round.
* Add and sort recent develop changes
* add notes about keyboard moves/deletions
* import changelog for PR 12172
Documents the change to BOOTMAGIC_ENABLE.
* update section headings
* re-sort changelog
* add additional note regarding Bootmagic changes
* remove changelog timestamp
* update dates in main Breaking Changes docs
* fix broken section anchors in previous changelogs
* add link to backlight/eeprom patch to changelog
* highlight some more changes
* link PRs from section headers
* Restore standard readme
* run: qmk cformat --core-only
* Initial userspace
* DZ60 map
* Quefrency map
* Sinc map
* Set up MAKE key for all personal maps
* Light userspace cleanup
* Formatting and comments zzz...
* Licensing and userspace README
* Swap: EXTRAFLAGS -> LTO_ENABLE in userspace rules.mk
Co-authored-by: Ryan <fauxpark@gmail.com>
* Improve KC_MAKE: KC_ENT -> \n
Co-authored-by: Ryan <fauxpark@gmail.com>
* Swap left grouping on _FN for pairs
* Add '?' -> backslash on _FN
* Remove commented code
* Organize lines in rules.mk
* Add left hand scroll keys
* Move configs to config.h
* License blitz
Co-authored-by: Ryan <fauxpark@gmail.com>
* initial keymap commit
* Keymap for coppertop commit
* removed define for layers/kc_no/kc_trns
* Modified keymap to remove definitions and add layer enum
* initial keymap commit
* Keymap for coppertop commit
* removed define for layers/kc_no/kc_trns
* Modified keymap to remove definitions and add layer enum
* Changed KC_NO and KC_TRNS to 7X and 7_
* Fixed spacing on keymaps
* TMO50: use layer_state_set_kb at keyboard level (#10150)
* Change TMO to use layer_state_set_kb as is customary at the keyboard level.
This also factors out `process_indicator_led` to a separate method.
* [Keymap] update dz60:mrsendyyk (#10160)
Update DZ60 Personal readme.md and keymap.c
* Update readme.md
* Update keymap.c
* Update keymap.c
* Update readme.md
* Update readme.md
* Update readme.md
* Update keymap.c
* Update readme.md
* Update
* Update readme.md
* Update keymap.c
* Update readme.md
* [Keyboard] YMDK NP21 refactor (#10181)
* [Keyboard] 1upkeyboards/1up60rgb: fix broken Enter (#10188)
The recent change to unnest macros put the enter on the wrong matrix key. On the 1uprgb, the ANSI and ISO enters share the same cell as does the ANSI and ISO backslash.
* no idea what this is
* Update keyboards/dz60/keymaps/coppertop/keymap.c
* Update keyboards/dz60/keymaps/coppertop/keymap.c
* Update keyboards/dz60/keymaps/coppertop/keymap.c
* Update keyboards/dz60/keymaps/spotpuff/keymap.c
* Update keyboards/dz60/keymaps/spotpuff/keymap.c
* Update keyboards/dz60/keymaps/spotpuff/keymap.c
* Added Trns labels to keymap comments.
* Revert "no idea what this is"
This reverts commit dd950f9eb3bad365961d2aa6c97c9dfbdd6219db.
* Reverted dd950f9eb3bad365961d2aa6c97c9dfbdd6219db
* fix vusb submodule
* Update keyboards/dz60/keymaps/coppertop/rules.mk
* Update keyboards/dz60/keymaps/spotpuff/rules.mk
* Update users/spotpuff/rules.mk
* Added GNU copyright license text
* Better handle LTO_ENABLE
Especially when calling from command line
* Replace LINK_TIME_OPTIMIZATION_ENABLE with LTO_ENABLE
* Remove long for LTO from show_options.mk
* KBDfans DZ60 ANSI with Arrow also RGB Underglow as a Caps Lock Indicator
* Change all the KC_NOs to _______ (seven underscores)
* change all the KC_NOs to _______ (seven underscores)
* Update keymap.c
* Update readme.md
Update build environment setup link, make instructions link, and make instructions link.
* README cleanup
* replaced "normal" numbers with "keypad" numbers:
KC_P4 replaced by KC_KP_P4
* replaced "normal" keys on Numpad Layer with the "KeyPad" keys
KC_1 replaced by KC_P1 etc.
* mpstewart dz60 layout
* Remove macro aliases from keymap
* Remove macro aliases from keymap
* Update keyboards/dz60/keymaps/mpstewart/keymap.c
* Remove macro aliases from keymap
* use AG_TOGG instead of AG_SWAP
Also some commentary changes, and a change to one of the layout graphics
* Removed reference to firmware size in 0-9,a-f board-level and default keymap 'rules.mk' files
* Correct some 'rules.mk' in boards buried under vendor folders
* PR8027 patch
Co-authored-by: GeorgeKoenig <35542036+GeorgeKoenig@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
* Add DZ60 to VIA
* Changed vendor id from 'KF' to 'DZ'
* Capitalize hex
* Fix Via_layout_options size setting
* Update keyboards/dz60/keymaps/via/rules.mk
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
* Initial commit
* Modified keymap and updated readme.
* fixed numbering in readme
* Update README.md
* Update README.md
* Update README.md
* Update README.md
* Update README.md
* Update README.md
* Made requested changes in PR.
* Rename README.md to readme.md
* swapped media control keys
* updated right alt key to apply shift key for emacs
* updated R_Alt to remove shift
* Updated readme
* add layout 2 and rename existing folder to layout 4
- renamed existing folder with directional layout to layout 4
- udpated existing readme
- Added layout_60_2
* update flash script per pull request review
* Added keymap profile to space65
- This keymap profile is for MacOS with VIM key bindings
- See readme for more information
* Update keyboards/gray_studio/space65/keymaps/billiams/readme.md
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
* Update keyboards/gray_studio/space65/keymaps/billiams/readme.md
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
* Update keyboards/gray_studio/space65/keymaps/billiams/readme.md
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
* Update keyboards/gray_studio/space65/keymaps/billiams/readme.md
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
* Update keyboards/gray_studio/space65/keymaps/billiams/keymap.c
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
* remove unnecessary code from keymap
* updated keys and cleaned up readme
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
* I don't know if this is how my keyboard is laid out or not
* testing, still broken
* name change
* I think this is the layout I will try to use to start
* it compiles!
* added norman layout!
* media keys
* Moved backlight functions to KEYB
Moved Delete off of Backspace and to the < key
* more changes to layout, move Norman to 1 so it was moddable by FCTN
* swapped volume and media, I use volume a lot more than media
* Eh, it's still all in flux.
* I don't want the entire function layer full of dead keys, after all...
* moves escape to the caps lock key and caps lock to the functions layer
* update my readme for posterity
* Updates bonfire dz60 for better escape control
* WIP commit -- this is not working yet
* updates keymap for GAME layer
adds info to README
adds visual keyboard layout map in json and jpg for reference
* updates readme for visual keymap insertion
* removes my layout from the parent folder and keeps it localized
* updates the C code to be more readable
* finished the HELD_ESCAPE code
* finishes v6.1.0
* updates layout names to match repo code style per @mechmerlin
Apply suggestions from code review
* updates to code style per suggestions by @mechmerlin
* Update global-functions.c
updates some personal documentation
* updates hold time for escape on gaming layer
* updates several aspects of the code based on PR requests
* moves a variable
* Adds layout for DZ60rev2 plate B, options 4 and 10
* Use KC_TRANS for layer keys
* Format layer0 with visual key size layout
* Add RGB controls; add start description; add KC_LOCK
* Update comments on rules.mk for DZ60
* Gets keymap compiling
* Fix wiring for shift on row 3
* Hold a with other key to send Ctrl-A before other key
* Adds compile-time defined mac-compatability media keycodes
* Adds logic in place for capturing taps (w/ timeout)
* Add send_keys(...) which can send up to 64 nested keycodes
* Implement send_keys callable with n repeats
* Tweaks some of the keymap
* Add reset keycode; add disable to custom shortcuts
* Adds a special "off" layer where bonus mod goes to layer 0, every other key KC_NO
* Adjust timeout; mousekey settings
* Changes layout of Home,End,PgUp/Dn on the dedicated arrow keys L1/L2
* PoC on rgb lighted layer indication
* Refactors color table defines
* Adds logic for controlling layer lights
* Only change state on one side of the event lol
* Switch back to Tapping Toggle for layer 4
* Add custom config file for keyboard; TT and mousekey settings
* Code cleanup; starting to refactor special ctrl tapping keys functions
* Move defines and reak out functions
* Remove debugging light
* Adjust keymaps; add enter
* Adds a couple custom macros
* Add simplified version of keymap to help debug issues
* Adds basi numpad configuration for levinson keyboard half
* Use ANSI ctrl key as layer 1 for better one hand (`)
* Adapt to new 8bit hue from #5547; layer enum use everywhere
* Move custom code out to users/ space
* Flip col pins, move key assignments to "left hand"
* Update readme
* Implement placeholder macros
* Notes
* Reduce tapping time for SFT_T(/)
* Adds vim features; refactors things
* Adds fork of the vim features written by xton
* Use correct backspace keycode
* Add VIM_ESC
* Add "OFF" to the RGB/HSV definitions
* Clean up rules, use new "OFF" definition
* Add windows KC_CALCULATOR key to numpad
* Reformat layers with better guide; change layer names
* Add sleep key
* Change timeout delay
* Add a "code paste" which surrounds a ^V with ```
* Try removing shift tap on rshift /
* Update macros
* Update the "code paste" macro
* Update keymap with reset, calc, equals
* Update keyboards/dz60/keymaps/twschum_b_4_10_simple/keymap.c
Co-Authored-By: Drashna Jaelre <drashna@live.com>
* Update keyboards/dz60/keymaps/twschum_b_4_10/keymap.c
Co-Authored-By: Drashna Jaelre <drashna@live.com>
* Update users/twschum/twschum.c
Co-Authored-By: Drashna Jaelre <drashna@live.com>
* Update users/twschum/twschum.c
Co-Authored-By: Drashna Jaelre <drashna@live.com>
* Revert quantum/rgblight_list.h
* Better name for split space layout; rename KEYMAP->LAYOUT
* Rename KEYMAP->LAYOUT
* Use simpler :flash command
* Clean up layout files
* Use qmk's MOD_MASK_CTRL
* Sync lufa submodule
* Cleanup from noroadsleft's PR comments
* Modernize vim layer code
* Add Community Layout: 60_abnt2
Add a 60% version of the standard keyboard layout used in Brazil.
* Enable 60_abnt2 support for DZ60
* fix the indenting in the Community Layout keymap
* New custom ISO keymap for DZ60
* New custom ISO keymap for DZ60
* Adding relative path for keymap image
* Removed reference to PNG and updated the README accordingly.
* Improving on the README some more after reading up on the guidelines for
keymaps
Xelus22
QMK Bot
Oliver Granlund
Ryan
Nic Lake
Joel Elkins
James Young
kb-elmo
Sendy YK
Joel Challis
Draevin
Žan Pevec
Sendy YK
spotpuff
Drashna Jaelre
Chris Alves
Sendy YK
mcginnisa
Pablo Ovelleiro Corral
mcarni
mpstewart
Joshua Rubin
madhogs
ridingqwerty
Dmitrijs Minajevs
Ethan Beyer
William Chang
Tim Schumacher
moyi4681
Daniel Barber
Luiz Correia
Calvin Moody
tarnjotsingh