andrejl
/
qmk-dactyl-manuform-a
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix qmk doctor 'bytes-like object is required' on linux 

This fixes the following issue related to encoding on linux systems. Add
`universal_newlines=True` to subprocess.

<class 'TypeError'>
☒ a bytes-like object is required, not 'str'
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/milc.py", line 564, in __call__
    return self.__call__()
  File "/usr/local/lib/python3.7/site-packages/milc.py", line 569, in __call__
    return self._entrypoint(self)
  File "$HOME/qmk_firmware/lib/python/qmk/cli/doctor.py", line 56, in doctor
    for line in mm_check.stdout.split('\n'):
TypeError: a bytes-like object is required, not 'str'
master
Ayman Bagabas 2019-10-01 20:56:16 -04:00 committed by skullydazed
parent afb93b7f48
commit 9067dc817a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/python/qmk/cli/doctor.py
View File

@ -50,7 +50,7 @@ def doctor(cli):
elif OS == "Linux": elif OS == "Linux":
cli.log.info("Detected {fg_cyan}Linux.") cli.log.info("Detected {fg_cyan}Linux.")
if shutil.which('systemctl'): if shutil.which('systemctl'):
mm_check = subprocess.run(['systemctl', 'list-unit-files'], stdout=subprocess.PIPE, stderr=subprocess.PIPE, timeout=10) mm_check = subprocess.run(['systemctl', 'list-unit-files'], stdout=subprocess.PIPE, stderr=subprocess.PIPE, timeout=10, universal_newlines=True)
if mm_check.returncode == 0: if mm_check.returncode == 0:
mm = True mm = True
for line in mm_check.stdout.split('\n'): for line in mm_check.stdout.split('\n'):