Commit Graph

979 Commits (d08ba534a24e19bf5c6d8b4f05b6253ec4202120)

Author SHA1 Message Date
Joey Hess fcfbf252e2 respinse 2008-07-19 13:36:06 -04:00
Joey Hess b557ba7c46 close bug, add changelog 2008-07-19 13:24:58 -04:00
http://gmcmanus.myopenid.com/ c8995955df new bug and patch 2008-07-19 03:04:47 -04:00
http://smcv.pseudorandom.co.uk/ 1e6b38a335 2008-07-18 22:08:13 -04:00
http://www.cse.unsw.edu.au/~willu/ 15fb518cc2 New bug and patch - close stderr when forking a sub process to run git 2008-07-18 21:03:55 -04:00
Joey Hess 584f3e3061 Add a postscan hook.
* Add a postscan hook.
* search: Use postscan hook, avoid updating index when previewing.
2008-07-17 16:17:15 -04:00
Joey Hess 4bc6f6cb96 web commit by http://jcflack.myopenid.com/ 2008-07-17 10:46:03 -04:00
Joey Hess acb6f66fbe closures 2008-07-14 21:30:59 -04:00
Joey Hess 5d027102f5 fix link 2008-07-14 15:20:37 -04:00
Joey Hess a3c8465565 web commit by http://ptecza.myopenid.com/: * Broken URL 2008-07-14 10:15:37 -04:00
Simon McVittie 30b3b00f4f Mark bug "clear: both for .page*?" as [[done]] 2008-07-13 15:33:44 +01:00
Joey Hess 2d6263b991 web commit by http://smcv.pseudorandom.co.uk/: Patched 2008-07-13 10:31:09 -04:00
Joey Hess 74bc4af998 web commit by http://smcv.pseudorandom.co.uk/: on second thoughts, more changes are desirable 2008-07-13 09:50:33 -04:00
Joey Hess 4ad9680d52 web commit by http://smcv.pseudorandom.co.uk/: suggest solution 2008-07-13 09:45:59 -04:00
Joey Hess e3c0e49774 only htmlize errors when cgi is actually running 2008-07-12 23:23:25 -04:00
Joey Hess 71fba7791f add perlmagick to build deps
needed since the doc wiki is using an [[img]]
2008-07-12 20:20:26 -04:00
Simon McVittie 60dc17c39c Hopefully fix regression tests in non-English environments 2008-07-12 23:00:57 +01:00
Simon McVittie ac8a862a06 Merge branch 'master' of git://git.ikiwiki.info into bugs 2008-07-12 22:56:55 +01:00
Joey Hess 44e42209a8 web commit by http://smcv.pseudorandom.co.uk/: I think I know what's wrong here too 2008-07-12 17:56:38 -04:00
Simon McVittie bed1f1037a Add missing requirement of IkiWiki::render before starting to render things 2008-07-12 22:52:46 +01:00
Joey Hess 99523151a8 web commit by http://smcv.pseudorandom.co.uk/ 2008-07-12 17:48:41 -04:00
Joey Hess 40975cd29d web commit by intrigeri: initial bug submission 2008-07-12 17:47:51 -04:00
Joey Hess ce4c5142b0 web commit by intrigeri: update, found a possible (random) fix 2008-07-12 17:40:25 -04:00
Joey Hess 299fd7fa2e web commit by intrigeri: bug submission 2008-07-12 17:32:13 -04:00
Joey Hess 4f51703fea web commit by intrigeri: bug submission 2008-07-12 17:25:43 -04:00
Joey Hess 52cccc6fd4 remove example (which was lacking escaping) 2008-07-12 12:04:47 -04:00
Joey Hess 6255c88e89 fixed 2008-07-12 12:04:10 -04:00
Joey Hess d36361b010 web commit by http://smcv.pseudorandom.co.uk/ 2008-07-12 12:01:05 -04:00
Joey Hess a0f596b6ed Change deb dependencies to list Text::Markdown before markdown, since the former, while slower, has a much better html parser that avoids numerous bugs. 2008-07-12 10:40:31 -04:00
Joey Hess 0a09638f96 greatly simplified test case 2008-07-12 10:33:41 -04:00
Joey Hess 32a8bf4c36 bug 2008-07-11 06:24:25 -04:00
Joey Hess 76b963deb5 web commit by intrigeri: thanks + note about git collaborative work 2008-07-11 03:16:06 -04:00
Joey Hess 7e29cbfc27 web commit by intrigeri: answer + fix escaping in example wiki page 2008-07-11 03:09:59 -04:00
Joey Hess 0073775dc3 question 2008-07-10 15:39:08 -04:00
Joey Hess 8ba2497a23 escape 2008-07-10 15:38:08 -04:00
Joey Hess 3879c56e71 Fixes creation of pages when clicking on WikiLinks starting with "/". 2008-07-10 15:36:18 -04:00
Joey Hess c52493422b web commit by intrigeri: initial bug submission 2008-07-10 15:02:25 -04:00
Joey Hess ac4a11ba50 web commit by intrigeri: added opinion + patch 2008-07-10 14:56:52 -04:00
Joey Hess 8c48db5be2 web commit by http://ptecza.myopenid.com/: * Confirmation and thanks 2008-07-09 04:27:10 -04:00
Joey Hess 3c82db72c4 remove patch tag 2008-07-09 02:05:57 -04:00
Joey Hess ee5585f7d9 close 2008-07-09 02:02:26 -04:00
Joey Hess 79ffb09ca2 close 2008-07-09 02:02:03 -04:00
Joey Hess 7541622fe9 response 2008-07-08 19:28:20 -04:00
Joey Hess 61479665b4 web commit by AndrewGreenberg: bad formatting on bug report, sorry. 2008-07-08 19:15:40 -04:00
Joey Hess ae4d377946 web commit by AndrewGreenberg: Added nasty URL edit bug in 2.52. 2008-07-08 19:14:11 -04:00
Joey Hess 03d7f84f28 Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
Conflicts:

	doc/bugs/attachment:_failed_to_get_filehandle.mdwn
2008-07-08 18:12:33 -04:00
Joey Hess ad02f69836 attachment: Support perl 5.8's buggy version of CGI.pm.
This is truely horribly disgusting. CGI::tmpFileName, in current perls, is
an undocumented function (which should be a clue..) that takes the original
filename of an uploaded attachment, and returns the name of the tempfile
that CGI has stored it in.

In old perls, though, CGI::tmpFileName does not take a filename. It takes
a key from the object's {'.tmpfiles'} hash. This key is something
crazy like '*Fh::fh00001group' -- apparently the stringification of a
filehandle object.

Just to add to the fun, tmpFileName doesn't take the key, it expects a
refernce to the key. Argh?!

But the fun doesn't stop there, because in perl 5.8, CGI.pm is also broken
in two other ways. The upload() method is supposed to return a filehandle
to the temp file. It doesn't. The param() method is supposed to return
a filehandle to the temp file, that stringifies to the original filename.
It returns just the original filename, no filehandle.

Combine all these bugs, and you end up with this disgusting commit. Since
I have no way to get the filehandle, I *need* to get the tempfile name.
If I had the filehandle, I could probably pass it into tmpFileName, and
it might strigify to the right key name. But I don't, so the only way to
determine the key is to grub through the .tmpfiles hash ourselves.

And finally, one the temp file name is discovered, a filehandle can finally
be obtained by (re)opening it.

I recommend that this commit be reverted when perl 5.8 is a mercifully
faded memory.

I'm really, really, really glad I'm actually being paid for working on
this right now!
2008-07-08 18:10:53 -04:00
Joey Hess 9e51b2ccb5 web commit by http://ptecza.myopenid.com/: * Thanks! 2008-07-08 17:05:33 -04:00
Joey Hess 905d99e248 web commit by HenrikBrixAndersen: This happens on FreeBSD as well 2008-07-08 17:04:28 -04:00
Joey Hess 4a86457750 reproduced 2008-07-08 16:59:21 -04:00