03d7f84f28
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
...
Conflicts:
doc/bugs/attachment:_failed_to_get_filehandle.mdwn
2008-07-08 18:12:33 -04:00
ad02f69836
attachment: Support perl 5.8's buggy version of CGI.pm.
...
This is truely horribly disgusting. CGI::tmpFileName, in current perls, is
an undocumented function (which should be a clue..) that takes the original
filename of an uploaded attachment, and returns the name of the tempfile
that CGI has stored it in.
In old perls, though, CGI::tmpFileName does not take a filename. It takes
a key from the object's {'.tmpfiles'} hash. This key is something
crazy like '*Fh::fh00001group' -- apparently the stringification of a
filehandle object.
Just to add to the fun, tmpFileName doesn't take the key, it expects a
refernce to the key. Argh?!
But the fun doesn't stop there, because in perl 5.8, CGI.pm is also broken
in two other ways. The upload() method is supposed to return a filehandle
to the temp file. It doesn't. The param() method is supposed to return
a filehandle to the temp file, that stringifies to the original filename.
It returns just the original filename, no filehandle.
Combine all these bugs, and you end up with this disgusting commit. Since
I have no way to get the filehandle, I *need* to get the tempfile name.
If I had the filehandle, I could probably pass it into tmpFileName, and
it might strigify to the right key name. But I don't, so the only way to
determine the key is to grub through the .tmpfiles hash ourselves.
And finally, one the temp file name is discovered, a filehandle can finally
be obtained by (re)opening it.
I recommend that this commit be reverted when perl 5.8 is a mercifully
faded memory.
I'm really, really, really glad I'm actually being paid for working on
this right now!
2008-07-08 18:10:53 -04:00
9e51b2ccb5
web commit by http://ptecza.myopenid.com/ : * Thanks!
2008-07-08 17:05:33 -04:00
905d99e248
web commit by HenrikBrixAndersen: This happens on FreeBSD as well
2008-07-08 17:04:28 -04:00
4a86457750
reproduced
2008-07-08 16:59:21 -04:00
f529518948
response
2008-07-08 16:21:17 -04:00
5a9faa0aff
rm
2008-07-08 16:18:11 -04:00
8cac2ac23e
web commit by http://ptecza.myopenid.com/ : * The bug still occurs
2008-07-08 16:11:18 -04:00
ac69ab522c
add dist-bugs
2008-07-08 14:18:09 -04:00
dd8be0ab32
merge
2008-07-08 13:47:02 -04:00
e0855f84d3
response
2008-07-08 13:46:01 -04:00
b2d983c670
web commit by mrled
2008-07-08 13:16:11 -04:00
23e95143b8
web commit by mrled
2008-07-08 13:08:46 -04:00
d7380c1afa
web commit by mrled
2008-07-08 13:04:23 -04:00
03639ff4d0
web commit by mrled
2008-07-08 13:03:46 -04:00
1f192b330e
web commit by mrled
2008-07-08 13:02:25 -04:00
6f3c980e2b
undef $fh before opening
2008-07-08 12:16:36 -04:00
6fc21e9d3d
web commit by http://ptecza.myopenid.com/ : * Still no success
2008-07-08 11:56:31 -04:00
bae7306828
response
2008-07-08 11:47:03 -04:00
66f35e30dc
another try at dealing with CGI.pm problem
...
open the temp file if all attempts to get a fd fail
2008-07-08 11:25:30 -04:00
5ccd0cb518
web commit by http://ptecza.myopenid.com/ : * Debugging again
2008-07-08 11:15:48 -04:00
fd6ebaeee7
possible fix
2008-07-08 10:43:45 -04:00
0ffe0872c1
web commit by http://ptecza.myopenid.com/ : * Next debbuging
2008-07-08 10:24:24 -04:00
fac6743cad
new thing to try
2008-07-08 10:16:29 -04:00
0c9a504948
fix fix
2008-07-08 10:05:57 -04:00
f8a86765d2
close
2008-07-08 10:04:43 -04:00
42dcf37016
web commit by http://ptecza.myopenid.com/ : * Missing Apache2 version
2008-07-08 10:00:48 -04:00
99113e50ef
web commit by http://ptecza.myopenid.com/ : * Response
2008-07-08 09:58:33 -04:00
04319b030c
split out separate bug
2008-07-08 09:49:29 -04:00
7e16fa3a1e
response
2008-07-08 09:46:29 -04:00
f156308aef
attachment: Fix an uninitialised value warning when editing a page that currently has no attachments.
2008-07-08 09:40:46 -04:00
eb4a6fb01a
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
2008-07-08 09:37:58 -04:00
67e4a21bd6
web commit by http://jcflack.myopenid.com/
2008-07-08 09:29:19 -04:00
db77e342fa
web commit by http://ptecza.myopenid.com/ : * Problem with colon in report page name
2008-07-08 06:42:33 -04:00
7977fe382a
web commit by http://ptecza.myopenid.com/ : * Problem with uploading attachments
2008-07-08 06:29:20 -04:00
a3f6385448
web commit by http://ptecza.myopenid.com/ : * Thanks!
2008-07-08 04:27:12 -04:00
d1d0c6667d
add an interesting ikiwiki site I stumbled across
2008-07-08 02:42:12 -04:00
ff5ebd4b8d
test
2008-07-07 19:15:14 -04:00
611bf8edb6
response
2008-07-07 16:41:52 -04:00
9de2ebb983
move to todo
2008-07-07 16:40:48 -04:00
488f92426d
clarify how an item is wishlisted
2008-07-07 16:40:28 -04:00
b5eaf7bff5
undo wishlist changes
...
You don't want to post new wishlist items, really, as they're lower
priority than just todo items. :-) Anyway, I want to keep wishlist and
todos both under todo/ so that they can easily be changed from one state to
another. And the inline caused items to be created under wishlist/ , but
didn't actually inline them.
2008-07-07 16:38:19 -04:00
d5ad2c6522
web commit by http://dmarti.myopenid.com/
2008-07-07 15:15:35 -04:00
b37a98c207
web commit by http://www.openidfrance.fr/beaufils
2008-07-07 15:11:57 -04:00
dd8712fe2a
web commit by http://dmarti.myopenid.com/
2008-07-07 15:03:57 -04:00
9205e0ff82
resp
2008-07-07 14:46:15 -04:00
8d81dee411
web commit by http://jcflack.myopenid.com/
2008-07-07 14:00:46 -04:00
9a61666a35
testing
2008-07-07 13:32:18 -04:00
aa67a17336
example of how to limit to specific directory
2008-07-07 12:12:48 -04:00
ea7c1374fb
new idea
2008-07-07 12:11:49 -04:00
f4f3063aca
typo the second
2008-07-07 12:08:45 -04:00
f1b86d1016
response
2008-07-07 12:07:47 -04:00
d657aa8a9e
typo
2008-07-07 12:07:12 -04:00
14d959b246
web commit by http://ptecza.myopenid.com/ : * Enabling attachment plugin
2008-07-07 08:44:43 -04:00
43e0691a50
search: generate configuration files once only when rebuilding (Gabriel McManus)
2008-07-07 01:55:06 -04:00
2aac9cdb30
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
2008-07-07 01:51:49 -04:00
85c75c8f9d
web commit by http://gmcmanus.myopenid.com/ : search: create configuration once only on rebuild
2008-07-07 00:57:39 -04:00
7ff928b721
wishlist
2008-07-06 19:27:57 -04:00
474f51a7a2
add news item for ikiwiki 2.52
2008-07-06 19:24:48 -04:00
2f3a279f68
add virus checking to attachments plugin
2008-07-06 17:36:26 -04:00
05124f9a86
editpage escaping fixes
...
* The editpage form now uses the raw page name, not the page title, in its
'page' cgi parameter. Using the title was ambiguous and made it
impossible to tell between some pages, like "foo/bar" and "foo__47__bar",
sometimes causing the wrong page to be edited.
* This change means that some edit links need to be updated.
Force a rebuild on upgrade to this version.
* Above change also allowed really fixing escaped slashes from the blogpost
form.
2008-07-06 15:52:04 -04:00
f6b86bfa5b
delete duplicate page, move comment to correct place
2008-07-06 14:10:31 -04:00
4bf7785760
response
2008-07-06 14:07:33 -04:00
674ed7e706
response
2008-07-06 14:05:01 -04:00
3ec9621734
remove; user also has a bbb page
2008-07-06 13:59:35 -04:00
17bb3cec42
rm
2008-07-06 13:58:47 -04:00
33e9442f4a
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
2008-07-06 13:58:47 -04:00
c1687b1f1e
typo
2008-07-06 12:27:57 -04:00
bb3036317d
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 22:18:04 -04:00
f0ff71af55
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 22:04:12 -04:00
50c813c715
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 22:03:05 -04:00
2d17c87fd9
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 22:01:49 -04:00
2f8e4500f9
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 22:00:39 -04:00
c2937e14ed
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 21:55:55 -04:00
316bee3786
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 21:52:57 -04:00
8b59050ea7
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 21:52:03 -04:00
f9ddfe56b9
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 21:51:23 -04:00
f5dca442fe
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 21:50:47 -04:00
6a863b58a6
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 21:49:46 -04:00
4db44caf06
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 21:45:21 -04:00
4d7ccdc8e5
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 21:44:03 -04:00
69108f446f
web commit by http://tychoish.livejournal.com/ : further clarification.
2008-07-04 08:03:54 -04:00
560372bf94
web commit by http://subvert.org.uk/~bma/
2008-07-04 03:21:16 -04:00
df736d3089
web commit by http://subvert.org.uk/~bma/
2008-07-04 03:14:29 -04:00
d426894c99
web commit by http://tychoish.livejournal.com/
2008-07-03 23:14:47 -04:00
2d64fdd22e
web commit by http://tychoish.livejournal.com/
2008-07-03 23:00:37 -04:00
cb06a01b75
web commit by http://jcflack.myopenid.com/
2008-07-03 18:21:07 -04:00
f7755e5e01
web commit by http://jcflack.myopenid.com/
2008-07-03 18:20:25 -04:00
f4e06ba343
web commit by http://jcflack.myopenid.com/
2008-07-03 18:12:01 -04:00
bb7ef14a2b
update
2008-07-03 13:42:49 -04:00
3e11f8b6aa
argh
2008-07-03 13:42:25 -04:00
77ebc0ad8c
web commit by http://jcflack.myopenid.com/
2008-07-03 13:40:30 -04:00
8526fd8293
web commit by http://alcopop.org/me/openid/ : nudge headers down to h2
2008-07-03 11:41:36 -04:00
f0d9bf00dc
web commit by bremner: mention mnemosyne-blog
2008-07-03 03:40:56 -04:00
ca6d9da279
link to pagespec/attachment
2008-07-02 18:22:49 -04:00
2888b03556
move attachment pagespec extensions docs to its own page
...
in the basewiki, so I can link to it there
2008-07-02 18:22:49 -04:00
84e6c4fa66
add mimetype checking
2008-07-02 18:22:49 -04:00
190d328e40
web commit by Petteri: Added debian.fi
2008-07-02 17:48:16 -04:00
cea18902a1
test 2
2008-07-02 17:45:29 -04:00
fc95aab71c
test commit
2008-07-02 17:39:33 -04:00
Joey Hess
Joey Hess