9f141841ef
don't rely on $@
...
A malformed pagespec will cause $@ to be set when translated, but if
it is used a second time, the memoization will defeat that check. Better to
check for the result not being defined.
2008-12-17 18:56:32 -05:00
140c0bacba
change around comments pagespecs
...
I think it is clearer to have one pagespec that controls all pages with
comments, and a separate pagespec that can be used to close new comments on
a subset of those pages.
2008-12-17 18:50:04 -05:00
9b837fd5ed
fix default values for config settings
...
defaults cannot be set in getsetup, do it in checkconfig to avoid
uninitialized value warnings.
2008-12-17 17:05:49 -05:00
60142db48e
clarification
2008-12-17 15:29:22 -05:00
bb93fccf06
Coding style change: Remove explcit vim folding markers.
2008-12-17 15:22:16 -05:00
985b229be6
checksessionexpiry: rework
...
This function as factored out was a bit confusing, I think this makes more
sense.
2008-12-17 14:26:08 -05:00
fdd994fb73
more comments doc updates
...
Moved todo items to a todo page, mark the old todo item about comments as
done, etc.
2008-12-17 14:15:52 -05:00
613a54a3cb
Merge branch 'master' into comments
2008-12-17 14:06:57 -05:00
f9b87a9f8b
monotone: When getting the log, tell monotone how many entries we want, rather than closing the pipe, which it dislikes. (thm)
2008-12-17 13:59:12 -05:00
b2366f764b
rename: Fix double-escaping of page name in edit box.
...
titlepage normally escapes, but so does formbuilder.
2008-12-17 13:56:10 -05:00
8621e52e09
rename bugs/bugfix_for:___38____35__34__59__mtn:_operation_canceled:_Broken_pipe__38____35__34__59_____40__patch__41__.mdwn to bugs/bugfix_for:___34__mtn:_operation_canceled:_Broken_pipe__34_____40__patch__41__.mdwn
2008-12-17 05:54:16 -05:00
4e97a8d915
rename bugs/bugfix_for:___34__mtn:_operation_canceled:_Broken_pipe__34__.mdwn to bugs/bugfix_for:___38____35__34__59__mtn:_operation_canceled:_Broken_pipe__38____35__34__59_____40__patch__41__.mdwn
2008-12-17 05:52:10 -05:00
e0061660c9
2008-12-16 06:56:19 -05:00
df59b3e3cd
2008-12-16 06:54:55 -05:00
f6562fb186
add a meta title
2008-12-15 16:09:26 +00:00
6307f5381f
not putting cgi in destdir
2008-12-15 15:39:07 +00:00
15ec55eff5
elide unnecessary variables
2008-12-12 15:38:23 -05:00
ef972a871b
remove fixme
...
sessioncgi hooks are always called with the wiki locked
2008-12-12 15:25:12 -05:00
928f6938d2
fix redefinition of $author
2008-12-12 15:22:43 -05:00
9557c7c890
move related code together
2008-12-12 15:19:01 -05:00
f3735891ca
whitespace
2008-12-12 15:13:07 -05:00
18eeb068a6
don't explicitly use inline
...
loadplugin("inline") should take care of that
2008-12-12 15:10:17 -05:00
2a7849b838
avoid unnecessary variable
2008-12-12 15:08:06 -05:00
0ced5995d5
get rid of the [postcomment] hack
...
I think that using a flag variable is sorta cleaner.
(This is untested.)
2008-12-12 15:05:26 -05:00
e9797ee086
improve documentation of postcomment
2008-12-12 15:02:40 -05:00
38c92e63bb
move getsetup to usual place
2008-12-12 14:59:23 -05:00
9d5075ab52
first pass through comments documentation
...
Moved documentation out of contrib.
Mostly tweaked some wording. Moved documentation of various bits to other
pages (pagespec, etc), and linked to those.
Documented the new templates in wikitemplates.
Small quantities of documentation were removed. Particularly the list of
template variables, which I think is fairly obvious when editing the
template.
2008-12-12 14:52:05 -05:00
be3579fd70
update changelog
2008-12-12 14:29:42 -05:00
40a6496817
update copyright
2008-12-12 14:27:56 -05:00
07c9cddb50
Merge branch 'master' into comments
2008-12-12 14:24:35 -05:00
1f43a4fccc
add log entry
2008-12-12 14:23:33 -05:00
473160c947
htmlbalance: don't compact whitespace, and set misc other options
...
Not compacting whitespace is the most important one: now that we run
sanitize hooks on individual posted comments in the comments plugin,
whitespace that is significant to Markdown (but not HTML) is lost.
(cherry picked from commit cb5aaa3cee
2008-12-12 14:23:12 -05:00
41efa5ac92
Merge branch 'master' into comments
2008-12-12 14:21:08 -05:00
88e8d4bf8d
meta: Pass info to htmlscrubber so htmlscrubber_skip can take effect.
2008-12-12 14:06:45 -05:00
5625be3bcd
Another TODO item
2008-12-12 06:34:51 -05:00
b8c1670500
update with some more code improvements
2008-12-12 06:29:02 -05:00
1942fc3bd6
comments: Store dates in GMT and in ISO-8601
...
The [[!_comment]] directive is a serialization format, not something for
presentation to users, so we should use the least ambiguous possible
representation.
2008-12-12 11:02:41 +00:00
53c122b3bb
2008-12-12 05:22:53 -05:00
35dcd53cf4
adding setup note
2008-12-12 00:40:00 -05:00
0983f4c81e
Fix too much quoting.
2008-12-11 19:38:53 -05:00
574640b069
Fix cut'n'past-o.
2008-12-11 19:36:36 -05:00
8d3a3c6a1e
simplifiy logic
2008-12-11 17:31:57 -05:00
f2d5ead6af
comments: Change internal-use-only directive from [[!comment]] to [[!_comment]]
2008-12-11 21:23:55 +00:00
dd1fa13bce
comments: Use new feedfile, emptyfeeds options to inline
2008-12-11 21:19:50 +00:00
3560460eb6
comments: don't interpolate IP into anonymous user's "name"
...
If an admin wants the IP in the comment display template they can still
get it (the default template shows it).
2008-12-11 21:14:05 +00:00
c038734986
comments_display.tmpl: use less nice formatting to avoid whitespace in output
2008-12-11 21:14:05 +00:00
370c1b87c9
comments_display.tmpl: preferentially use confirmed username, but fall back to claimed author if unauthenticated
...
This still isn't quite right (it displays the IP address twice if the user
doesn't specify a name).
2008-12-11 21:14:05 +00:00
1698364da0
comments: fix invocation of possibly_foolish_untaint
2008-12-11 21:14:05 +00:00
f29a607025
comments_form.tmpl: show labels for name, website
2008-12-11 21:14:05 +00:00
fbf145ca3f
comments: avoid warning if there's no subject
2008-12-11 21:14:05 +00:00
Joey Hess
http://thm.id.fedoraproject.org/
Jon Dowland
Joey Hess
Simon McVittie
http://smcv.pseudorandom.co.uk/
http://john.choffee.co.uk/
justin
tschwinge