ac4a11ba50
web commit by intrigeri: added opinion + patch
2008-07-10 14:56:52 -04:00
8c48db5be2
web commit by http://ptecza.myopenid.com/ : * Confirmation and thanks
2008-07-09 04:27:10 -04:00
3c82db72c4
remove patch tag
2008-07-09 02:05:57 -04:00
ee5585f7d9
close
2008-07-09 02:02:26 -04:00
79ffb09ca2
close
2008-07-09 02:02:03 -04:00
7541622fe9
response
2008-07-08 19:28:20 -04:00
61479665b4
web commit by AndrewGreenberg: bad formatting on bug report, sorry.
2008-07-08 19:15:40 -04:00
ae4d377946
web commit by AndrewGreenberg: Added nasty URL edit bug in 2.52.
2008-07-08 19:14:11 -04:00
03d7f84f28
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
...
Conflicts:
doc/bugs/attachment:_failed_to_get_filehandle.mdwn
2008-07-08 18:12:33 -04:00
ad02f69836
attachment: Support perl 5.8's buggy version of CGI.pm.
...
This is truely horribly disgusting. CGI::tmpFileName, in current perls, is
an undocumented function (which should be a clue..) that takes the original
filename of an uploaded attachment, and returns the name of the tempfile
that CGI has stored it in.
In old perls, though, CGI::tmpFileName does not take a filename. It takes
a key from the object's {'.tmpfiles'} hash. This key is something
crazy like '*Fh::fh00001group' -- apparently the stringification of a
filehandle object.
Just to add to the fun, tmpFileName doesn't take the key, it expects a
refernce to the key. Argh?!
But the fun doesn't stop there, because in perl 5.8, CGI.pm is also broken
in two other ways. The upload() method is supposed to return a filehandle
to the temp file. It doesn't. The param() method is supposed to return
a filehandle to the temp file, that stringifies to the original filename.
It returns just the original filename, no filehandle.
Combine all these bugs, and you end up with this disgusting commit. Since
I have no way to get the filehandle, I *need* to get the tempfile name.
If I had the filehandle, I could probably pass it into tmpFileName, and
it might strigify to the right key name. But I don't, so the only way to
determine the key is to grub through the .tmpfiles hash ourselves.
And finally, one the temp file name is discovered, a filehandle can finally
be obtained by (re)opening it.
I recommend that this commit be reverted when perl 5.8 is a mercifully
faded memory.
I'm really, really, really glad I'm actually being paid for working on
this right now!
2008-07-08 18:10:53 -04:00
9e51b2ccb5
web commit by http://ptecza.myopenid.com/ : * Thanks!
2008-07-08 17:05:33 -04:00
905d99e248
web commit by HenrikBrixAndersen: This happens on FreeBSD as well
2008-07-08 17:04:28 -04:00
4a86457750
reproduced
2008-07-08 16:59:21 -04:00
f529518948
response
2008-07-08 16:21:17 -04:00
8cac2ac23e
web commit by http://ptecza.myopenid.com/ : * The bug still occurs
2008-07-08 16:11:18 -04:00
6f3c980e2b
undef $fh before opening
2008-07-08 12:16:36 -04:00
6fc21e9d3d
web commit by http://ptecza.myopenid.com/ : * Still no success
2008-07-08 11:56:31 -04:00
bae7306828
response
2008-07-08 11:47:03 -04:00
66f35e30dc
another try at dealing with CGI.pm problem
...
open the temp file if all attempts to get a fd fail
2008-07-08 11:25:30 -04:00
5ccd0cb518
web commit by http://ptecza.myopenid.com/ : * Debugging again
2008-07-08 11:15:48 -04:00
fd6ebaeee7
possible fix
2008-07-08 10:43:45 -04:00
0ffe0872c1
web commit by http://ptecza.myopenid.com/ : * Next debbuging
2008-07-08 10:24:24 -04:00
fac6743cad
new thing to try
2008-07-08 10:16:29 -04:00
0c9a504948
fix fix
2008-07-08 10:05:57 -04:00
f8a86765d2
close
2008-07-08 10:04:43 -04:00
42dcf37016
web commit by http://ptecza.myopenid.com/ : * Missing Apache2 version
2008-07-08 10:00:48 -04:00
99113e50ef
web commit by http://ptecza.myopenid.com/ : * Response
2008-07-08 09:58:33 -04:00
04319b030c
split out separate bug
2008-07-08 09:49:29 -04:00
7e16fa3a1e
response
2008-07-08 09:46:29 -04:00
f156308aef
attachment: Fix an uninitialised value warning when editing a page that currently has no attachments.
2008-07-08 09:40:46 -04:00
db77e342fa
web commit by http://ptecza.myopenid.com/ : * Problem with colon in report page name
2008-07-08 06:42:33 -04:00
7977fe382a
web commit by http://ptecza.myopenid.com/ : * Problem with uploading attachments
2008-07-08 06:29:20 -04:00
a3f6385448
web commit by http://ptecza.myopenid.com/ : * Thanks!
2008-07-08 04:27:12 -04:00
b37a98c207
web commit by http://www.openidfrance.fr/beaufils
2008-07-07 15:11:57 -04:00
f1b86d1016
response
2008-07-07 12:07:47 -04:00
14d959b246
web commit by http://ptecza.myopenid.com/ : * Enabling attachment plugin
2008-07-07 08:44:43 -04:00
43e0691a50
search: generate configuration files once only when rebuilding (Gabriel McManus)
2008-07-07 01:55:06 -04:00
85c75c8f9d
web commit by http://gmcmanus.myopenid.com/ : search: create configuration once only on rebuild
2008-07-07 00:57:39 -04:00
05124f9a86
editpage escaping fixes
...
* The editpage form now uses the raw page name, not the page title, in its
'page' cgi parameter. Using the title was ambiguous and made it
impossible to tell between some pages, like "foo/bar" and "foo__47__bar",
sometimes causing the wrong page to be edited.
* This change means that some edit links need to be updated.
Force a rebuild on upgrade to this version.
* Above change also allowed really fixing escaped slashes from the blogpost
form.
2008-07-06 15:52:04 -04:00
4bf7785760
response
2008-07-06 14:07:33 -04:00
674ed7e706
response
2008-07-06 14:05:01 -04:00
17bb3cec42
rm
2008-07-06 13:58:47 -04:00
bb3036317d
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 22:18:04 -04:00
f0ff71af55
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 22:04:12 -04:00
8b59050ea7
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 21:52:03 -04:00
f9ddfe56b9
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 21:51:23 -04:00
f5dca442fe
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 21:50:47 -04:00
6a863b58a6
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 21:49:46 -04:00
4db44caf06
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 21:45:21 -04:00
4d7ccdc8e5
web commit by http://www.openidfrance.fr/beaufils
2008-07-05 21:44:03 -04:00
69108f446f
web commit by http://tychoish.livejournal.com/ : further clarification.
2008-07-04 08:03:54 -04:00
560372bf94
web commit by http://subvert.org.uk/~bma/
2008-07-04 03:21:16 -04:00
df736d3089
web commit by http://subvert.org.uk/~bma/
2008-07-04 03:14:29 -04:00
2d64fdd22e
web commit by http://tychoish.livejournal.com/
2008-07-03 23:00:37 -04:00
cb06a01b75
web commit by http://jcflack.myopenid.com/
2008-07-03 18:21:07 -04:00
f7755e5e01
web commit by http://jcflack.myopenid.com/
2008-07-03 18:20:25 -04:00
77ebc0ad8c
web commit by http://jcflack.myopenid.com/
2008-07-03 13:40:30 -04:00
2354613391
response; move to bug report
2008-07-02 16:43:13 -04:00
19749d0c5b
web commit by http://liw.fi/ : commented on ü and ikiwiki 2.50
2008-07-01 14:29:35 -04:00
524ee496e3
remove bad link
2008-06-29 14:18:00 -04:00
8ab0d60271
web commit by http://ptecza.myopenid.com/ : * Plural
2008-06-29 11:15:38 -04:00
c44ae04702
web commit by http://ptecza.myopenid.com/ : * Thanks!
2008-06-29 11:02:55 -04:00
b66f9a1981
call format hooks when generating page previews
...
* toc: Revert change in 2.45 that made it run at sanitize time. This breaks
use of toc in a sidebar.
* Call format hooks when generating page previews, thus fixing toc display
there, as well as fixing inlins to again display in page previews, since
it's started using format hooks. This also allows several other things,
like embed, that use format hooks, to work during page preview time.
* Format hooks should not rely on getting an entire html document, as they
will only get the body during page preview.
* toggle: Deal with preview mode when adding javascript.
2008-06-28 23:08:24 -04:00
f8fe1247bd
bug
2008-06-28 22:46:12 -04:00
00503f25cd
smiley: Generate links relative to the destpage. (Fixes a reversion from 2.41.)
2008-06-28 16:58:43 -04:00
5356790ece
web commit by http://ptecza.myopenid.com/ : * Fixed example
2008-06-27 10:24:22 -04:00
6880183131
web commit by http://ptecza.myopenid.com/ : * Bug report
2008-06-27 10:16:37 -04:00
38a2b13b6a
add bug link
2008-06-24 17:25:26 -04:00
bd7edfd9ca
textile: The Text::Textile perl module has some regexps that fail if input is flagged as utf-8, but contains invalid characters such as 0x92. To prevent it from crashing, re-encode the content before calling it, which will ensure that it's really utf-8.
2008-06-16 15:43:37 -04:00
0053217488
web commit by http://alcopop.org/me/openid/ : ikiwiki version is 2.50
2008-06-16 15:19:37 -04:00
2db2e35a05
web commit by http://alcopop.org/me/openid/ : bug with bad input text
2008-06-16 15:13:27 -04:00
99c96480c0
web commit by http://ptecza.myopenid.com/ : * Thanks!
2008-06-16 03:36:03 -04:00
524c21ffbd
web commit by http://sabr.myopenid.com/
2008-06-15 17:32:13 -04:00
0f83e169e0
close as dup
2008-06-15 15:35:09 -04:00
878e74238e
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
2008-06-14 11:39:34 -04:00
5e1b31fad6
web commit by http://telemachos.myopenid.com/
2008-06-14 09:25:30 -04:00
751706b7a5
response
2008-06-13 16:42:06 -04:00
aad18ffc51
web commit by http://ptecza.myopenid.com/ : * Thanks and question about Xapian
2008-06-13 16:02:47 -04:00
5807f1de04
fix two build bugs
...
* ikiwiki-mass-rebuild: Make group list comparison more robust.
* search: Work around xapian bug #486138 by only stemming locales
in a whitelist.
2008-06-13 13:05:44 -04:00
340f219818
response
2008-06-13 13:04:59 -04:00
eab909095b
response
2008-06-13 12:26:59 -04:00
6fe6857f7e
web commit by http://alcopop.org/me/openid/ : maybe for some future backwards-compatibility killing release?
2008-06-13 11:49:22 -04:00
cdd48716be
web commit by http://ptecza.myopenid.com/ : * Bug report
2008-06-13 10:41:25 -04:00
d59b565b53
web commit by buo: libdir does have an effect
2008-06-13 10:34:55 -04:00
332e0b4e3c
question
2008-06-12 14:14:07 -04:00
a65dd073cf
this problem makes less sense the more information I get
2008-06-12 14:10:24 -04:00
8afa1e2304
web commit by http://telemachos.myopenid.com/
2008-06-11 10:09:52 -04:00
3d4859262d
web commit by http://telemachos.myopenid.com/
2008-06-11 10:08:35 -04:00
fc79199ccd
response
2008-06-10 14:35:52 -04:00
3b82819049
web commit by buo: strace run
2008-06-10 14:31:03 -04:00
e6a6893117
followup
2008-06-10 13:55:24 -04:00
c48efcf8a4
not done
2008-06-10 13:49:43 -04:00
3a76a58e1e
fix link
2008-06-10 13:36:21 -04:00
2fc11033f5
web commit by buo: Possible workaround
2008-06-10 09:11:42 -04:00
3c4ac2727b
web commit by http://telemachos.myopenid.com/
2008-06-10 07:44:26 -04:00
970e1a571e
not reproducible on unstable
2008-06-04 21:00:24 -04:00
47b5417ac0
already fixed
2008-06-04 01:58:52 -04:00
811c76f85e
already fixed
2008-06-04 01:57:59 -04:00
7d87bf9e78
fix
2008-06-04 01:54:58 -04:00
81719b40a4
closing, fixed in documentation
2008-06-04 01:54:23 -04:00
Joey Hess
Joey Hess