Commit Graph

16351 Commits (5b9005a8dd33feba93d0c85a7fdeaa2194af5d1a)

Author SHA1 Message Date
Amitai Schlair 19280af182 pull request (no functional change, just worried I broke easy merging) 2012-01-22 20:48:40 -05:00
Amitai Schlair c7c43cccba Merge branch 'master' into cvs 2012-01-22 20:42:00 -05:00
Amitai Schlair 0d0b87be58 pull request (no functional change, just worried I broke easy merging) 2012-01-22 20:39:12 -05:00
test f9ff7c7aae 2012-01-22 14:55:54 -04:00
Amitai Schlair a64b224f52 Merge branch 'master' into cvs 2012-01-22 11:18:07 -05:00
Amitai Schlair 662d256c82 ignore a file that always clutters status on OS X (no known fix) 2012-01-22 11:17:19 -05:00
Amitai Schlair ad0e56cdca Define required programs and modules at top for easy spotting. 2012-01-22 11:07:58 -05:00
Amitai Schlair c74571c758 Merge branch 'cvs' of github.com:schmonz/ikiwiki into cvs
Conflicts:
	TODO.cvs
	t/cvs.t
2012-01-22 10:53:45 -05:00
Amitai Schlair c1bbff4bfb update 2012-01-22 10:45:17 -05:00
Amitai Schlair 8e99750545 No functional change: sort sub definitions.
In the code:
* general plugin API calls (in plugins/write order),
* VCS plugin API calls (in plugins/write order), then
* internal support routines (in alphabetical order).

In the tests:
* general meta-behavior (in no particular order, yet),
* general plugin API calls (in plugins/write order),
* VCS plugin API calls (in plugins/write order), then
* internal support routines (in semi-logical order).
2012-01-22 10:44:50 -05:00
Amitai Schlair ea04eb4102 Test::Class runs test subs in alphabetical order, so we do too. 2012-01-22 10:44:50 -05:00
Amitai Schlair 88b08b5835 Ape xUnit more closely to remove ordering constraints on test subs:
* Add setup and teardown methods, called before and after every test sub.
* In setup, make a fresh repo; in teardown, throw it out.
* Extract runtests method and define default test methods at top.
* Move reflection routines near the xUnit-style subs they support.

Adapt existing test subs to run independently:
* In test_manual_add_and_commit(), assume a fresh repo.

While here, plan a bit better:
* Check for all modules used by cvs.pm.
* Check for program existence more generally.
* Check that we can rmdir after mkdir.
2012-01-22 10:44:50 -05:00
Amitai Schlair 1ea4949257 Describe the needed test cases, and implement a couple Test::Class features.
* Run all subs matching /^test_*/ (for which we can plan)...
* Unless TEST_METHOD is set, in which case run matching subs (sans plan).
* Define total number of tests very near 'use Test::More', where expected.
* Define test tempdir where it's declared, no longer any reason why not.
* Move most comments from TODO.cvs into t/cvs.t.
* Add a whole bunch more comments describing the needed test cases.

XXX existing tests are order-dependent, but currently happen to pass
2012-01-22 10:44:49 -05:00
Amitai Schlair 3497f49f35 Fix regression: failing to make the temp dir should nix the test plan.
While here, nitpick style and wrap long lines.
2012-01-22 10:44:49 -05:00
Amitai Schlair 0b7d5aeeb6 Use config parameters directly and shorten long lines. 2012-01-22 10:44:49 -05:00
Amitai Schlair d760df3821 * Define expected number of tests near the top.
* Call readfile() directly from writefile().
* Parameterize commit message for the web-commit case.
* Describe intent of test cases.
* Rename test subs to match what they actually do.
* To prove extra path slashes don't cause trouble, instead of running
  the same tests a second time, just assert that checkconfig()
  strips the slashes.
2012-01-22 10:44:49 -05:00
Amitai Schlair b77da0bb3b Fix a typo in the web commit test. 2012-01-22 10:44:49 -05:00
Amitai Schlair f18160b95d Simplify startup: use Test::More unconditionally, then determine
the test plan at runtime. Use IkiWiki unconditionally too (as that's
not what I'm testing here) to avoid the TAP error of printing a
test result before having printed the plan.
2012-01-22 10:44:49 -05:00
Amitai Schlair f98c4c5b72 Extract subs: startup/shutdown, and tests for web and manual commits.
No functional change intended.
2012-01-22 10:44:49 -05:00
Amitai Schlair 2677b73207 add TODO notes 2012-01-22 10:44:48 -05:00
Amitai Schlair af29b004d5 point to my branch, wrap lines, working on test coverage now 2012-01-22 10:42:01 -05:00
Amitai Schlair 0b22579368 Merge branch 'cvs' of github.com:schmonz/ikiwiki into cvs
Conflicts:
	TODO.cvs
2012-01-22 02:40:38 -05:00
Amitai Schlair 97016a0061 Describe the needed test cases, and implement a couple Test::Class features.
* Run all subs matching /^test_*/ (for which we can plan)...
* Unless TEST_METHOD is set, in which case run matching subs (sans plan).
* Define total number of tests very near 'use Test::More', where expected.
* Define test tempdir where it's declared, no longer any reason why not.
* Move most comments from TODO.cvs into t/cvs.t.
* Add a whole bunch more comments describing the needed test cases.

XXX existing tests are order-dependent, but currently happen to pass
2012-01-22 02:40:06 -05:00
Amitai Schlair fe1c7ea126 Fix regression: failing to make the temp dir should nix the test plan.
While here, nitpick style and wrap long lines.
2012-01-22 02:40:06 -05:00
Amitai Schlair 302643fb4e Use config parameters directly and shorten long lines. 2012-01-22 02:40:06 -05:00
Amitai Schlair 9e5ee1475a * Define expected number of tests near the top.
* Call readfile() directly from writefile().
* Parameterize commit message for the web-commit case.
* Describe intent of test cases.
* Rename test subs to match what they actually do.
* To prove extra path slashes don't cause trouble, instead of running
  the same tests a second time, just assert that checkconfig()
  strips the slashes.
2012-01-22 02:40:06 -05:00
Amitai Schlair 2586346231 Fix a typo in the web commit test. 2012-01-22 02:40:06 -05:00
Amitai Schlair bcb69f8fed Simplify startup: use Test::More unconditionally, then determine
the test plan at runtime. Use IkiWiki unconditionally too (as that's
not what I'm testing here) to avoid the TAP error of printing a
test result before having printed the plan.
2012-01-22 02:40:06 -05:00
Amitai Schlair 94c1f3bd33 Extract subs: startup/shutdown, and tests for web and manual commits.
No functional change intended.
2012-01-22 02:40:06 -05:00
Amitai Schlair 700d39d765 add TODO notes 2012-01-22 02:40:05 -05:00
https://www.google.com/accounts/o8/id?id=AItOawnxp2XU8gIribhhGhGuYtU6eMMwHv5gUGI 4ddcd8a0b7 for rcs_remove(), there's no new file 2012-01-22 02:19:19 -04:00
Javier Rojas 5034d7f456 comment - index attachments 2012-01-21 16:47:16 -05:00
Amitai Schlair 12fd902fb1 Merge branch 'master' into cvs 2012-01-20 22:33:27 -05:00
https://www.google.com/accounts/o8/id?id=AItOawk_MMtLPS7osC5MjX00q2ATjvvXPWqm0ik 74880397d0 2012-01-20 13:12:28 -04:00
http://smcv.pseudorandom.co.uk/ 55de24cb64 clean example blog
This reverts commit 1d14473234
2012-01-20 10:00:50 -04:00
https://launchpad.net/~vanyok 493a228e5b oops!
This reverts commit efbae4b0f9
2012-01-20 08:44:44 -04:00
https://launchpad.net/~vanyok efbae4b0f9 some test records 2012-01-20 08:42:51 -04:00
http://jno.homeip.net/owncloud/?jno 1d14473234 тест 2012-01-20 06:54:14 -04:00
https://www.google.com/accounts/o8/id?id=AItOawndsaC4GaIBw49WNdbk2Faqfm_mrtQgul8 0973205034 2012-01-18 12:44:32 -04:00
https://www.google.com/accounts/o8/id?id=AItOawndsaC4GaIBw49WNdbk2Faqfm_mrtQgul8 8d239aa363 Added a comment: apache module? 2012-01-18 11:40:57 -04:00
https://www.google.com/accounts/o8/id?id=AItOawndsaC4GaIBw49WNdbk2Faqfm_mrtQgul8 b1a0647814 removed 2012-01-18 11:39:36 -04:00
https://www.google.com/accounts/o8/id?id=AItOawndsaC4GaIBw49WNdbk2Faqfm_mrtQgul8 eb7992de16 Added a comment: apache module? 2012-01-18 11:39:18 -04:00
https://www.google.com/accounts/o8/id?id=AItOawndsaC4GaIBw49WNdbk2Faqfm_mrtQgul8 7408689f5b 2012-01-18 07:02:04 -04:00
Joey Hess 17c2bf1778 response 2012-01-17 23:26:55 -04:00
https://www.google.com/accounts/o8/id?id=AItOawljSQThLsc4vHz0jw1aSR74Dj9K5J_NKqk 42b06a462f Added a comment 2012-01-17 12:45:38 -04:00
https://openid.stackexchange.com/user/bd7676f7-83b5-4a71-82a6-d4df0fab61ca 99e644967c can the 'add comment' form be generated and returned even if the srcdir is locked? 2012-01-17 08:13:48 -04:00
https://www.google.com/accounts/o8/id?id=AItOawndsaC4GaIBw49WNdbk2Faqfm_mrtQgul8 bbed2a9eff Added a comment: just my 2 cents 2012-01-17 07:10:09 -04:00
http://hands.com/~phil/ bf47f70678 fix underlay link 2012-01-17 04:49:43 -04:00
https://www.google.com/accounts/o8/id?id=AItOawndsaC4GaIBw49WNdbk2Faqfm_mrtQgul8 5643428d7d Added a comment: updating setup file 2012-01-16 21:30:32 -04:00
https://www.google.com/accounts/o8/id?id=AItOawndsaC4GaIBw49WNdbk2Faqfm_mrtQgul8 f7c366eeab Added a comment: Great! It worked! 2012-01-16 21:18:07 -04:00