4ad9680d52
web commit by http://smcv.pseudorandom.co.uk/ : suggest solution
2008-07-13 09:45:59 -04:00
e3c0e49774
only htmlize errors when cgi is actually running
2008-07-12 23:23:25 -04:00
71fba7791f
add perlmagick to build deps
...
needed since the doc wiki is using an [[img]]
2008-07-12 20:20:26 -04:00
60dc17c39c
Hopefully fix regression tests in non-English environments
2008-07-12 23:00:57 +01:00
ac8a862a06
Merge branch 'master' of git://git.ikiwiki.info into bugs
2008-07-12 22:56:55 +01:00
44e42209a8
web commit by http://smcv.pseudorandom.co.uk/ : I think I know what's wrong here too
2008-07-12 17:56:38 -04:00
bed1f1037a
Add missing requirement of IkiWiki::render before starting to render things
2008-07-12 22:52:46 +01:00
99523151a8
web commit by http://smcv.pseudorandom.co.uk/
2008-07-12 17:48:41 -04:00
40975cd29d
web commit by intrigeri: initial bug submission
2008-07-12 17:47:51 -04:00
ce4c5142b0
web commit by intrigeri: update, found a possible (random) fix
2008-07-12 17:40:25 -04:00
299fd7fa2e
web commit by intrigeri: bug submission
2008-07-12 17:32:13 -04:00
4f51703fea
web commit by intrigeri: bug submission
2008-07-12 17:25:43 -04:00
52cccc6fd4
remove example (which was lacking escaping)
2008-07-12 12:04:47 -04:00
6255c88e89
fixed
2008-07-12 12:04:10 -04:00
d36361b010
web commit by http://smcv.pseudorandom.co.uk/
2008-07-12 12:01:05 -04:00
a0f596b6ed
Change deb dependencies to list Text::Markdown before markdown, since the former, while slower, has a much better html parser that avoids numerous bugs.
2008-07-12 10:40:31 -04:00
0a09638f96
greatly simplified test case
2008-07-12 10:33:41 -04:00
32a8bf4c36
bug
2008-07-11 06:24:25 -04:00
76b963deb5
web commit by intrigeri: thanks + note about git collaborative work
2008-07-11 03:16:06 -04:00
7e29cbfc27
web commit by intrigeri: answer + fix escaping in example wiki page
2008-07-11 03:09:59 -04:00
0073775dc3
question
2008-07-10 15:39:08 -04:00
8ba2497a23
escape
2008-07-10 15:38:08 -04:00
3879c56e71
Fixes creation of pages when clicking on WikiLinks starting with "/".
2008-07-10 15:36:18 -04:00
c52493422b
web commit by intrigeri: initial bug submission
2008-07-10 15:02:25 -04:00
ac4a11ba50
web commit by intrigeri: added opinion + patch
2008-07-10 14:56:52 -04:00
8c48db5be2
web commit by http://ptecza.myopenid.com/ : * Confirmation and thanks
2008-07-09 04:27:10 -04:00
3c82db72c4
remove patch tag
2008-07-09 02:05:57 -04:00
ee5585f7d9
close
2008-07-09 02:02:26 -04:00
79ffb09ca2
close
2008-07-09 02:02:03 -04:00
7541622fe9
response
2008-07-08 19:28:20 -04:00
61479665b4
web commit by AndrewGreenberg: bad formatting on bug report, sorry.
2008-07-08 19:15:40 -04:00
ae4d377946
web commit by AndrewGreenberg: Added nasty URL edit bug in 2.52.
2008-07-08 19:14:11 -04:00
03d7f84f28
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
...
Conflicts:
doc/bugs/attachment:_failed_to_get_filehandle.mdwn
2008-07-08 18:12:33 -04:00
ad02f69836
attachment: Support perl 5.8's buggy version of CGI.pm.
...
This is truely horribly disgusting. CGI::tmpFileName, in current perls, is
an undocumented function (which should be a clue..) that takes the original
filename of an uploaded attachment, and returns the name of the tempfile
that CGI has stored it in.
In old perls, though, CGI::tmpFileName does not take a filename. It takes
a key from the object's {'.tmpfiles'} hash. This key is something
crazy like '*Fh::fh00001group' -- apparently the stringification of a
filehandle object.
Just to add to the fun, tmpFileName doesn't take the key, it expects a
refernce to the key. Argh?!
But the fun doesn't stop there, because in perl 5.8, CGI.pm is also broken
in two other ways. The upload() method is supposed to return a filehandle
to the temp file. It doesn't. The param() method is supposed to return
a filehandle to the temp file, that stringifies to the original filename.
It returns just the original filename, no filehandle.
Combine all these bugs, and you end up with this disgusting commit. Since
I have no way to get the filehandle, I *need* to get the tempfile name.
If I had the filehandle, I could probably pass it into tmpFileName, and
it might strigify to the right key name. But I don't, so the only way to
determine the key is to grub through the .tmpfiles hash ourselves.
And finally, one the temp file name is discovered, a filehandle can finally
be obtained by (re)opening it.
I recommend that this commit be reverted when perl 5.8 is a mercifully
faded memory.
I'm really, really, really glad I'm actually being paid for working on
this right now!
2008-07-08 18:10:53 -04:00
9e51b2ccb5
web commit by http://ptecza.myopenid.com/ : * Thanks!
2008-07-08 17:05:33 -04:00
905d99e248
web commit by HenrikBrixAndersen: This happens on FreeBSD as well
2008-07-08 17:04:28 -04:00
4a86457750
reproduced
2008-07-08 16:59:21 -04:00
f529518948
response
2008-07-08 16:21:17 -04:00
8cac2ac23e
web commit by http://ptecza.myopenid.com/ : * The bug still occurs
2008-07-08 16:11:18 -04:00
6f3c980e2b
undef $fh before opening
2008-07-08 12:16:36 -04:00
6fc21e9d3d
web commit by http://ptecza.myopenid.com/ : * Still no success
2008-07-08 11:56:31 -04:00
bae7306828
response
2008-07-08 11:47:03 -04:00
66f35e30dc
another try at dealing with CGI.pm problem
...
open the temp file if all attempts to get a fd fail
2008-07-08 11:25:30 -04:00
5ccd0cb518
web commit by http://ptecza.myopenid.com/ : * Debugging again
2008-07-08 11:15:48 -04:00
fd6ebaeee7
possible fix
2008-07-08 10:43:45 -04:00
0ffe0872c1
web commit by http://ptecza.myopenid.com/ : * Next debbuging
2008-07-08 10:24:24 -04:00
fac6743cad
new thing to try
2008-07-08 10:16:29 -04:00
0c9a504948
fix fix
2008-07-08 10:05:57 -04:00
f8a86765d2
close
2008-07-08 10:04:43 -04:00
42dcf37016
web commit by http://ptecza.myopenid.com/ : * Missing Apache2 version
2008-07-08 10:00:48 -04:00
Joey Hess
Joey Hess
Simon McVittie