7521dd6c75
jump to comment after posting
...
Jumping to the just posted comment was the imputus, but I killed a number
of birds here.
Added a INLINEPAGE template variable, which can be used to add anchors to
any inline template.
To keep that sufficiently general, it is the full page name, so the
comment anchors and links changed form.
Got rid of the FIXMEd hardcoded html anchor div.
More importantly, the anchor is now to the very top of the comment, not the
text below. So you can see the title, and how it attributes you.
Avoid changing the permalink of pages that are not really comments, but
happen to contain the _comment directive. I think that behavior was a bug,
though not a likely one to occur since _comment should only really be used
on comment pages.
2008-12-18 20:58:16 -05:00
d7855474fd
document how to make a global comments feed
2008-12-18 20:20:42 -05:00
1d82ac40d4
responses
2008-12-18 20:10:42 -05:00
7fc83fbd15
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
2008-12-18 18:00:03 -05:00
a115ff254d
Update todo/comments with today's fixes, and thoughts about the remaining items
2008-12-18 21:10:08 +00:00
65c4ae1ac1
clarify
2008-12-18 14:49:24 -05:00
8414a62e7f
2008-12-18 14:20:59 -05:00
b2439a3e51
pagespec thoughts
2008-12-18 12:53:47 -05:00
835801a6ff
note about comments feed
2008-12-18 12:32:23 -05:00
f3bec255e4
aggregate: If a feed fails to be downloaded, try again immediatly next time aggregation is run, even if the usual time has not passed. Closes : #508622 (Michael Gold)
2008-12-17 21:27:28 -05:00
385123006e
close
2008-12-17 21:17:42 -05:00
1074d38f0d
deletion
2008-12-17 20:40:46 -05:00
81165dd2e0
jump to comments anchor after post
...
Not ideal, it would be nicer to jump to the actual comment posted, but no
anchor is available.
2008-12-17 20:29:55 -05:00
339bfbd44a
typo
2008-12-17 20:22:42 -05:00
3e2f75af6b
fix
2008-12-17 20:19:12 -05:00
d647ca286a
simplify pagespec
2008-12-17 20:10:22 -05:00
8614abce09
two comments ui suggestions
2008-12-17 19:47:54 -05:00
cd7ac8f72a
add Comments link when displaying a page inline
...
This link will supplant the usual Discussion link for pages
that have comments enabled.
2008-12-17 19:38:02 -05:00
5feffc8b0b
fix test when comments_closed_pagespec is empty
2008-12-17 19:06:29 -05:00
9f141841ef
don't rely on $@
...
A malformed pagespec will cause $@ to be set when translated, but if
it is used a second time, the memoization will defeat that check. Better to
check for the result not being defined.
2008-12-17 18:56:32 -05:00
140c0bacba
change around comments pagespecs
...
I think it is clearer to have one pagespec that controls all pages with
comments, and a separate pagespec that can be used to close new comments on
a subset of those pages.
2008-12-17 18:50:04 -05:00
9b837fd5ed
fix default values for config settings
...
defaults cannot be set in getsetup, do it in checkconfig to avoid
uninitialized value warnings.
2008-12-17 17:05:49 -05:00
60142db48e
clarification
2008-12-17 15:29:22 -05:00
bb93fccf06
Coding style change: Remove explcit vim folding markers.
2008-12-17 15:22:16 -05:00
985b229be6
checksessionexpiry: rework
...
This function as factored out was a bit confusing, I think this makes more
sense.
2008-12-17 14:26:08 -05:00
fdd994fb73
more comments doc updates
...
Moved todo items to a todo page, mark the old todo item about comments as
done, etc.
2008-12-17 14:15:52 -05:00
613a54a3cb
Merge branch 'master' into comments
2008-12-17 14:06:57 -05:00
f9b87a9f8b
monotone: When getting the log, tell monotone how many entries we want, rather than closing the pipe, which it dislikes. (thm)
2008-12-17 13:59:12 -05:00
b2366f764b
rename: Fix double-escaping of page name in edit box.
...
titlepage normally escapes, but so does formbuilder.
2008-12-17 13:56:10 -05:00
8621e52e09
rename bugs/bugfix_for:___38____35__34__59__mtn:_operation_canceled:_Broken_pipe__38____35__34__59_____40__patch__41__.mdwn to bugs/bugfix_for:___34__mtn:_operation_canceled:_Broken_pipe__34_____40__patch__41__.mdwn
2008-12-17 05:54:16 -05:00
4e97a8d915
rename bugs/bugfix_for:___34__mtn:_operation_canceled:_Broken_pipe__34__.mdwn to bugs/bugfix_for:___38____35__34__59__mtn:_operation_canceled:_Broken_pipe__38____35__34__59_____40__patch__41__.mdwn
2008-12-17 05:52:10 -05:00
e0061660c9
2008-12-16 06:56:19 -05:00
df59b3e3cd
2008-12-16 06:54:55 -05:00
f6562fb186
add a meta title
2008-12-15 16:09:26 +00:00
6307f5381f
not putting cgi in destdir
2008-12-15 15:39:07 +00:00
15ec55eff5
elide unnecessary variables
2008-12-12 15:38:23 -05:00
ef972a871b
remove fixme
...
sessioncgi hooks are always called with the wiki locked
2008-12-12 15:25:12 -05:00
928f6938d2
fix redefinition of $author
2008-12-12 15:22:43 -05:00
9557c7c890
move related code together
2008-12-12 15:19:01 -05:00
f3735891ca
whitespace
2008-12-12 15:13:07 -05:00
18eeb068a6
don't explicitly use inline
...
loadplugin("inline") should take care of that
2008-12-12 15:10:17 -05:00
2a7849b838
avoid unnecessary variable
2008-12-12 15:08:06 -05:00
0ced5995d5
get rid of the [postcomment] hack
...
I think that using a flag variable is sorta cleaner.
(This is untested.)
2008-12-12 15:05:26 -05:00
e9797ee086
improve documentation of postcomment
2008-12-12 15:02:40 -05:00
38c92e63bb
move getsetup to usual place
2008-12-12 14:59:23 -05:00
9d5075ab52
first pass through comments documentation
...
Moved documentation out of contrib.
Mostly tweaked some wording. Moved documentation of various bits to other
pages (pagespec, etc), and linked to those.
Documented the new templates in wikitemplates.
Small quantities of documentation were removed. Particularly the list of
template variables, which I think is fairly obvious when editing the
template.
2008-12-12 14:52:05 -05:00
be3579fd70
update changelog
2008-12-12 14:29:42 -05:00
40a6496817
update copyright
2008-12-12 14:27:56 -05:00
07c9cddb50
Merge branch 'master' into comments
2008-12-12 14:24:35 -05:00
1f43a4fccc
add log entry
2008-12-12 14:23:33 -05:00
Joey Hess
smcv@
justin
http://thm.id.fedoraproject.org/
Jon Dowland
Joey Hess