Commit Graph

6759 Commits (3032909090711c86c5056987043eeff5a1f6aec2)

Author SHA1 Message Date
http://blog.mithis.net/ 3032909090 2008-12-29 02:01:49 -05:00
http://blog.mithis.net/ 1ac4637d4f 2008-12-29 01:26:34 -05:00
Joey Hess 00e55ed171 1st comment spam 2008-12-28 22:31:22 -05:00
Joey Hess f982a620f2 formatting 2008-12-28 22:23:15 -05:00
Joey Hess d8f16c4d95 clarify cgiurl setting 2008-12-28 22:03:34 -05:00
Joey Hess 82d94d4d4a add news item for ikiwiki 2.72 2008-12-28 15:05:33 -05:00
Joey Hess 7da319efc6 inline: Run format hook first
inline has a format hook that is an optimisation hack. Until this hook
runs, the inlined content is not present on the page. This can prevent
other format hooks, that process that content, from acting on inlined
content. In bug ##509710, we discovered this happened commonly for the
embed plugin, but it could in theory happen for many other plugins (color,
cutpaste, etc) that use format to fill in special html after sanitization.

The ordering was essentially random (hash key order). That's kinda a good
thing, because hooks should be independent of other hooks and able to run
in any order. But for things like inline, that just doesn't work.

To fix the immediate problem, let's make hooks able to be registered as
running "first". There was already the ability to make them run "last".

Now, this simple first/middle/last ordering is obviously not going to work
if a lot of things need to run first, or last, since then we'll be back to
being unable to specify ordering inside those sets. But before worrying about
that too much, and considering dependency ordering, etc, observe how few
plugins use last ordering: Exactly one needs it. And, so far, exactly one
needs first ordering. So for now, KISS.

Another implementation note: I could have sorted the plugins with
first/last/middle as the primary key, and plugin name secondary, to get a
guaranteed stable order. Instead, I chose to preserve hash order. Two
opposing things pulled me toward that decision:

1. Since has order is randomish, it will ensure that no accidental
   ordering assumptions are made.
2. Assume for a minute that ordering matters a lot more than expected.
   Drastically changing the order a particular configuration uses could
   result in a lot of subtle bugs cropping up. (I hope this assumption is
   false, partly due to #1, but can't rule it out.)
2008-12-26 16:09:23 -05:00
Joey Hess e3b7d18929 close 2008-12-23 20:08:01 -05:00
http://puck.openid.org/ 20731f761f 2008-12-23 18:05:38 -05:00
http://puck.openid.org/ 4d1d4db927 2008-12-23 17:48:05 -05:00
Joey Hess ecf2408bf6 fix a few directives using the old syntax
I'm turning on prefix_directives for the live wiki now.
2008-12-23 16:25:52 -05:00
Joey Hess 276798fbca response 2008-12-23 13:27:16 -05:00
Joey Hess 29c8db4c7f fix popcon graph link 2008-12-23 13:19:47 -05:00
http://hendry.iki.fi/ f1f6c5601f Any other schools? 2008-12-23 09:29:02 -05:00
intrigeri 298c16eda9 po: make the dev timing clearer 2008-12-23 11:08:00 +01:00
intrigeri e81c59748e httpauth_feature_parity_with_passwordauth: a bit more thinking
Signed-off-by: intrigeri <intrigeri@boum.org>
2008-12-23 11:08:00 +01:00
http://puck.openid.org/ 02da7ec599 2008-12-22 23:14:15 -05:00
Joey Hess 8dc052a1ce merge recentchanges comments fix 2008-12-22 19:04:02 -05:00
Joey Hess 62c0ba3619 Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info 2008-12-22 19:00:38 -05:00
http://smcv.pseudorandom.co.uk/ 143c437106 reference my recentchanges branch 2008-12-22 18:09:15 -05:00
Joey Hess 09af90e775 update 2008-12-22 16:41:29 -05:00
Joey Hess 7f1992cbe1 add news item for ikiwiki 2.71 2008-12-22 00:03:15 -05:00
Joey Hess d70f3d6271 unify pagespecs 2008-12-21 16:50:50 -05:00
Joey Hess 63b919b230 fix links 2008-12-21 16:48:15 -05:00
Joey Hess 836bf625c9 formatting 2008-12-21 16:45:59 -05:00
Joey Hess a0eee761f7 mention comments plugin 2008-12-21 16:44:02 -05:00
Joey Hess 4b66a8d00a openid branch merged 2008-12-21 13:14:31 -05:00
Joey Hess 041f8e3774 more reorg 2008-12-21 13:08:26 -05:00
Joey Hess f3512450fd close merged bugs 2008-12-21 13:00:03 -05:00
Joey Hess b2842b8838 Merge branch 'comments' 2008-12-21 12:48:14 -05:00
http://smcv.pseudorandom.co.uk/ 3b0aa2fcba Another fixed bug in beautify_urlpath 2008-12-21 12:25:55 -05:00
http://smcv.pseudorandom.co.uk/ 94cdf076ed trivial bug with patch 2008-12-21 12:23:34 -05:00
Simon McVittie ca1437c9e1 Another comments improvement 2008-12-21 17:18:43 +00:00
http://smcv.pseudorandom.co.uk/ bd376db3a8 Mention a patch to improve OpenID display 2008-12-21 11:43:43 -05:00
Simon McVittie 7bdeee2032 Record another couple of pending bugfixes 2008-12-21 15:39:40 +00:00
Simon McVittie bd80ca37d5 todo/comments: Properly escape inline HTML 2008-12-21 10:17:23 +00:00
Simon McVittie 2884d20950 todo/comments: reorganise by status 2008-12-21 10:11:48 +00:00
Simon McVittie ee24feece0 comments: note fixed things and recommend merging origin/comments 2008-12-21 10:08:53 +00:00
http://smcv.pseudorandom.co.uk/ c85e7c1bf4 fix markdown 2008-12-21 04:31:49 -05:00
Joey Hess c84fcdd32a meta: Process meta date during scan pass so that the date will always affect sorting in inlines. 2008-12-21 01:52:08 -05:00
Joey Hess da947bea4b analysis 2008-12-21 01:41:00 -05:00
Joey Hess 5c669ab226 comment layout change
I saw a layout similar to this on blogger, and I sorta like it

The dash avoids parens sitting next to each other in some cases.
2008-12-21 01:04:19 -05:00
Joey Hess 7304d6bd72 Merge branch 'master' into comments 2008-12-21 01:04:03 -05:00
http://dtrt.org/ fc077f6956 Response; added shell code and html formating to reproduction steps 2008-12-20 22:28:20 -05:00
Joey Hess 155ebc3dbd response 2008-12-20 20:27:42 -05:00
http://dtrt.org/ faa01bd432 Sort paramater not a problem; Revised steps to reprodce 2008-12-20 19:36:15 -05:00
Joey Hess 6042e607f3 alternate idea 2008-12-20 18:51:09 -05:00
Joey Hess f8cc87e8ee remove signin icons, use title 2008-12-20 18:46:56 -05:00
Joey Hess 8dbb30d346 my try at improving comment styling
Makes it look more like a blog, but not enough to be confusing, and with
nothing as large as in a blog. Removal of the vertical line under the
subject imho makes it easier to scan through comments as each box is a new
one. Bolding the subject seems to make it stand out enough, especially as
its a link now. (Also considered increasing its font size to 110%.)
2008-12-20 18:30:14 -05:00
Joey Hess 7bf121889b note new bug 2008-12-20 18:18:19 -05:00