af26398c14
avoid tempfile warning
...
Allow tempfile to open the file, so it doesn't warn about possible
insecurity. This probably fixes a real, but unlikely security hole too.
2009-09-13 20:20:21 -04:00
1846bd3061
Whoops, copyright 2009. /usr/bin/perl for the interpreter like other plugins.
...
(cherry picked from commit a69d628b2c
2009-09-11 14:46:38 -04:00
9ef4b5e677
Merge commit 'schmonz/master'
2009-09-10 17:04:20 -04:00
fb6c6895c6
Add NetBSD-style 2-clause BSD license.
2009-09-10 17:03:06 -04:00
60111384a9
formatting
2009-09-10 16:21:03 -04:00
73224daf2c
minor simplification
2009-09-10 16:20:21 -04:00
1365ebf12f
Merge commit 'schmonz/master' into cvs
2009-09-10 16:18:27 -04:00
8063bc3402
Catch up to the new genwrapper hook.
2009-09-10 15:12:45 -04:00
c22b938631
Merge commit 'schmonz/master' into cvs
2009-09-10 13:44:31 -04:00
98553d1537
CVS operations generally need to be within CVS checkouts, so these chdir()
...
calls are warranted. They shouldn't modify the caller's working directory,
though. Use File::chdir to keep the scope of the changes subroutine-local.
The tests now pass without resetting the working directory.
2009-09-10 00:51:34 -04:00
aafd267ee0
Abstract out CVS's involvement in the wrapper:
...
* In Wrapper.pm, add a new hook "wrapperargcheck" to examine argc/argv
and return success or failure. In the failure case, the wrapper
terminates.
* In cvs.pm, implement the new hook to return failure if a directory is
being cvs added.
2009-09-09 21:58:42 -04:00
8c55424b11
Merge commit 'schmonz/master' into cvs
...
Conflicts:
IkiWiki/Plugin/cvs.pm
2009-09-04 17:16:28 -04:00
d79cf3728d
It's STDOUT we have to shut up for cvs, and $savedout has to be
...
restored just so.
2009-09-04 14:56:55 -05:00
9de742bb00
Stop using IPC::Cmd and String::ShellQuote, since quoting (and
...
having to quote, and the possible use of the shell) sucks. Stop
passing args to cvs_runcvs() as an arrayref, since that also sucks
(and was a sop to IPC::Cmd). Instead, use Joey's construction for
temporarily redirecting stderr to /dev/null. Much much simpler and
better. Works on my laptop with bozohttpd, now to test on the NetBSD
wiki.
2009-09-04 12:40:04 -05:00
de7c3aa16b
minor formatting
2009-09-02 16:08:18 -04:00
85844b8494
whitespace
2009-08-30 21:03:18 -04:00
1af7d7d842
On some systems the commit message gets quoted properly already. Don't
...
requote in such cases, do quote in all others.
2009-08-30 16:13:17 -04:00
e972cadf78
Fix uninitialized value when editing a page being vivified from the
...
basewiki. Makes the filetype-testing logic more explicit anyway.
2009-08-30 13:49:38 -04:00
968c6c93b4
Remove debug statement.
2009-08-30 01:45:09 -04:00
2d1ff30e13
Knock off another to-do item: "Don't slurp the entire cvsps output
...
into memory (!)."
2009-08-30 01:14:22 -04:00
b493f9b6d8
Knock off a to-do item: "If the argument to cvs add smells like a
...
binary file, cvs add -kb it (for attachment support)."
2009-08-30 00:17:42 -04:00
6191f3fbb9
Remove getopt() hook (it's a dead end, unsafe to pass wrapper args to
...
ikiwiki). Crunch on-demand module loads into one-liners. Comment why
cvsps output is getting read in its entirety and reversed.
2009-08-29 21:35:54 -04:00
5bdcd4d57b
Oops, use the more recent (and less brittle) directory test.
2009-08-22 02:22:36 -04:00
524de4db26
Pass along wrapper args to ikiwiki, then handle the "cvs add dir"
...
case with a getopt hook directly in my plugin. If the wrapper change
is safe, we won't need a wrapper wrapper.
2009-08-22 01:25:41 -04:00
2b7a003794
Add my CVS plugin and related patches.
2009-08-13 16:56:26 -04:00
Joey Hess
Amitai Schlair
Amitai Schlair