urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

change cherry-picked; move to discussion

master
Joey Hess 2009-08-27 15:49:12 -04:00
parent 33b18e12c7
commit ffcd97ce52
2 changed files with 25 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
doc/plugins/po.mdwn
View File

@ -289,30 +289,6 @@ order, as `po_slave_languages` is a hash. It would need to be converted
to an array to support this. (If twere done, twere best done quickly.)
--[[Joey]]
Duplicate %links ?
------------------
I notice code in the scan hook that seems to assume
that %links will accumulate duplicate links for a page.
That used to be so, but the bug was fixed. Does this mean
that po might be replacing the only link on a page, in error?
--[[Joey]]
> It would replace it. The only problematic case is when another
> plugin has its own reasons, in its `scan` hook, to add a page
> that is already there to `$links{$page}`. This other plugin's
> effect might then be changed by po's `scan` hook... which could
> be either good (better overall l10n) or bad (break the other
> plugin's goal). --[[intrigeri]]
>> Right.. well, the cases where links are added is very small.
>> Grepping for `add_link`, it's just done by link, camelcase, meta, and
>> tag. All of these are supposed to work just link regular links
>> so I'd think that is ok. We could probably remove the currently scary
>> comment about only wanting to change the first link. --[[Joey]]
>>> Commit 3c2bffe21b91684 in my po branch does this. --[[intrigeri]]
Name of toplevel index page
---------------------------

25
doc/plugins/po/discussion.mdwn
View File

@ -699,3 +699,28 @@ and via CGI, have been tested.
* general test with `indexpages` enabled: **not OK**
* general test with `po_link_to=default` with `userdirs` enabled: **OK**
* general test with `po_link_to=default` with `userdirs` disabled: **OK**
Duplicate %links ?
------------------
I notice code in the scan hook that seems to assume
that %links will accumulate duplicate links for a page.
That used to be so, but the bug was fixed. Does this mean
that po might be replacing the only link on a page, in error?
--[[Joey]]
> It would replace it. The only problematic case is when another
> plugin has its own reasons, in its `scan` hook, to add a page
> that is already there to `$links{$page}`. This other plugin's
> effect might then be changed by po's `scan` hook... which could
> be either good (better overall l10n) or bad (break the other
> plugin's goal). --[[intrigeri]]
>> Right.. well, the cases where links are added is very small.
>> Grepping for `add_link`, it's just done by link, camelcase, meta, and
>> tag. All of these are supposed to work just link regular links
>> so I'd think that is ok. We could probably remove the currently scary
>> comment about only wanting to change the first link. --[[Joey]]
>>> Commit 3c2bffe21b91684 in my po branch does this. --[[intrigeri]]
>>>> Cherry-picked --[[Joey]]