Try to help with some code review
parent
f07bb9b48b
commit
fe88c81562
|
@ -1,5 +1,8 @@
|
||||||
This patch adds function bestdir() which returns best directory from the directory structure. This is in addition to the bestlink() function which is there in IkiWiki.pm
|
This patch adds function bestdir() which returns best directory from the directory structure. This is in addition to the bestlink() function which is there in IkiWiki.pm
|
||||||
|
|
||||||
|
> Um, what is this for? :-) It would probably be a lot easier to review if it
|
||||||
|
> had documentation, and/or a plugin that used it. --[[smcv]]
|
||||||
|
|
||||||
-------
|
-------
|
||||||
|
|
||||||
Index: IkiWiki.pm
|
Index: IkiWiki.pm
|
||||||
|
|
|
@ -4,6 +4,11 @@ How about a direct link from the page header to the source of the latest version
|
||||||
|
|
||||||
I just implemented this. There is one [[patch]] to the default page template, and a new plugin. -- [[Will]]
|
I just implemented this. There is one [[patch]] to the default page template, and a new plugin. -- [[Will]]
|
||||||
|
|
||||||
|
> The use of sessioncgi here seems undesirable: on wikis where anonymity is
|
||||||
|
> not allowed, you'll be asked to log in. Couldn't you achieve the same thing
|
||||||
|
> by loading the index with IkiWiki::loadindex, like [[plugins/goto]] does?
|
||||||
|
> --[[smcv]]
|
||||||
|
|
||||||
----
|
----
|
||||||
|
|
||||||
diff --git a/templates/page.tmpl b/templates/page.tmpl
|
diff --git a/templates/page.tmpl b/templates/page.tmpl
|
||||||
|
|
|
@ -33,6 +33,12 @@ ManojSrivastava
|
||||||
> > directory, which is not very easy for a plain ol' user. Not everyone is the
|
> > directory, which is not very easy for a plain ol' user. Not everyone is the
|
||||||
> > sysadmin of their own machines with access to system dirs. --ManojSrivastava
|
> > sysadmin of their own machines with access to system dirs. --ManojSrivastava
|
||||||
|
|
||||||
|
>>> It seems worth mentioning here that the `libdir` configuration parameter
|
||||||
|
>>> lets you install additional plugins in a user-controlled directory
|
||||||
|
>>> (*libdir*`/IkiWiki/Plugin`), avoiding needing root; indeed, a full local
|
||||||
|
>>> ikiwiki installation without any involvement from the sysadmin is
|
||||||
|
>>> [[possible|tips/DreamHost]]. --[[smcv]]
|
||||||
|
|
||||||
<pre>
|
<pre>
|
||||||
varioki => {'motto' => '"Manoj\'s musings"',
|
varioki => {'motto' => '"Manoj\'s musings"',
|
||||||
'arrayvar' => '[0, 1, 2, 3]',
|
'arrayvar' => '[0, 1, 2, 3]',
|
||||||
|
|
Loading…
Reference in New Issue