more comments doc updates

Moved todo items to a todo page, mark the old todo item about comments as
done, etc.
master
Joey Hess 2008-12-17 14:15:52 -05:00
parent 613a54a3cb
commit fdd994fb73
4 changed files with 14 additions and 12 deletions

View File

@ -37,15 +37,3 @@ There are some global options for the setup file:
specify a name for themselves, and the \[[!meta author]] and specify a name for themselves, and the \[[!meta author]] and
\[[!meta authorurl]] directives will not be overridden by the comments \[[!meta authorurl]] directives will not be overridden by the comments
plugin plugin
Known issues:
* Needs code review
* The access control via postcomment() is rather strange (see [[discussion]] for more details)
* There is some common code cargo-culted from other plugins (notably inline and editpage) which
should probably be shared
* Joey doesn't think it should necessarily use internal pages (see [[discussion]])
* Previews always say "unknown IP address"
* Add `COMMENTOPENID`: the authenticated/verified user name, if and only if it was an OpenID
* The default template should have a (?) icon next to unauthenticated users (with the IP address
as title) and an OpenID icon next to OpenIDs

View File

@ -63,6 +63,9 @@ spam problems. So, use `check_canedit` as at least a first-level check?
> This is why `anonok_pages => 'postcomment(*)'` and `locked_pages => '!postcomment(*)'` > This is why `anonok_pages => 'postcomment(*)'` and `locked_pages => '!postcomment(*)'`
> are necessary to allow anonymous and logged-in editing (respectively). > are necessary to allow anonymous and logged-in editing (respectively).
> >
>> I changed that to move the flag out of the page name, and into a variable that the `match_postcomment`
>> function checks for. Other ugliness still applies. :-) --[[Joey]]
>
> This is ugly - one alternative would be to add `check_permission()` that takes a > This is ugly - one alternative would be to add `check_permission()` that takes a
> page and a verb (create, edit, rename, remove and maybe comment are the ones I > page and a verb (create, edit, rename, remove and maybe comment are the ones I
> can think of so far), use that, and port the plugins you mentioned to use that > can think of so far), use that, and port the plugins you mentioned to use that

View File

@ -0,0 +1,8 @@
Known issues with the [[plugins/comments]] plugin:
* There is some common code cargo-culted from other plugins (notably inline and editpage) which
should probably be shared
* Previews always say "unknown IP address"
* Add `COMMENTOPENID`: the authenticated/verified user name, if and only if it was an OpenID
* The default template should have a (?) icon next to unauthenticated users (with the IP address
as title) and an OpenID icon next to OpenIDs

View File

@ -215,3 +215,6 @@ do you think so far? Known issues include:
--[[smcv]] --[[smcv]]
I've updated smcvpostcomment and publicised it as [[plugins/contrib/comments]]. --[[smcv]] I've updated smcvpostcomment and publicised it as [[plugins/contrib/comments]]. --[[smcv]]
> While there is still room for improvement and entirely other approaches,
> I am calling this done since smcv's comments plugin is ready. --[[Joey]]