urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

master
guilhem 2015-06-06 12:51:08 -04:00 committed by admin
parent 508bda2059
commit f99850b5d3
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
doc/bugs/Colons___8216__:__8217___should_not_be_allowed_in_image_filenames.mdwn 100644
View File

@ -0,0 +1,12 @@
`IkiWiki::Plugin::img` appends `[$pagenumber]` to the filename to deal with multipage documents such as PDFs.
However, `Image::Magick` doesn't seem to like page selection for filenames containing a colon. This is also the case for imagemagick binaries:
$ identify 'screenshot_2015-06-06_18:37:53.png'
screenshot_2015-06-06_18:37:53.png PNG 453x122 453x122+0+0 8-bit sRGB 11.2KB 0.000u 0:00.000
$ identify 'screenshot_2015-06-06_18:37:53.png[0]'
identify: no decode delegate for this image format `37' @ error/constitute.c/ReadImage/501.
$ mv 'screenshot_2015-06-06_18:37:53.png' 'screenshot_2015-06-06_18-37-53.png'
$ identify 'screenshot_2015-06-06_18-37-53.png[0]'
screenshot_2015-06-06_18-37-53.png[0]=>screenshot_2015-06-06_18-37-53.png PNG 453x122 453x122+0+0 8-bit sRGB 11.2KB 0.000u 0:00.000
This might be an imagemagick bug, but it's also possible that colons are interpreted somehow. Anyway, to render such images properly in ikiwiki I had to remove the colons. An easy fix is to remove ‘:’ from `wiki_file_chars`, but this can break existing installations. A better solution would be to make `IkiWiki::Plugin::img` croak on such image filenames (which anyway are currently not rendered, but `Image::Magick`'s error message is quite cryptic).