po: answered Joey, at last

Signed-off-by: intrigeri <intrigeri@boum.org>
master
intrigeri 2009-04-20 11:52:16 +02:00
parent 2cc3f5d057
commit f632cb2f8f
1 changed files with 20 additions and 0 deletions

View File

@ -360,12 +360,30 @@ daring a timid "please pull"... or rather, please review again :)
> * What's the reasoning behind checking that the link plugin
> is enabled? AFAICS, the same code in the scan hook should
> also work when other link plugins like camelcase are used.
>>
>> That's right, fixed.
>>
> * In `pagetemplate` there is a comment that claims the code
> relies on `genpage`, but I don't see how it does; it seems
> to always add a discussion link?
>>
>> It relies on IkiWiki::Render's `genpage` as this function sets the
>> `discussionlink` template param iff it considers a discussion link
>> should appear on the current page. That's why I'm testing
>> `$template->param('discussionlink')`.
>>
> * Is there any real reason not to allow removing a translation?
> I'm imagining a spammy translation, which an admin might not
> be able to fix, but could remove.
>>
>> On the other hand, allowing one to "remove" a translation would
>> probably lead to misunderstandings, as such a "removed" translation
>> page would appear back as soon as it is "removed" (with no strings
>> translated, though). I think an admin would be in a position to
>> delete the spammy `.po` file by hand using whatever VCS is in use.
>> Not that I'd really care, but I am slightly in favour of the way
>> it currently works.
>>
> * Re the meta title escaping issue worked around by `change`.
> I suppose this does not only affect meta, but other things
> at scan time too. Also, handling it only on rebuild feels
@ -383,4 +401,6 @@ daring a timid "please pull"... or rather, please review again :)
>
> --[[Joey]]
>>
>> I'll think about it soon.
>>
>> --[[intrigeri]]