From f065a2608c91361b02758835485af1d5f7d8c4dd Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Thu, 3 Jan 2008 05:32:21 -0500 Subject: [PATCH 1/9] web commit by http://stefano.zacchiroli.myopenid.com/ --- doc/ikiwikiusers.mdwn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/ikiwikiusers.mdwn b/doc/ikiwikiusers.mdwn index b2f64ca59..bf2ade883 100644 --- a/doc/ikiwikiusers.mdwn +++ b/doc/ikiwikiusers.mdwn @@ -48,7 +48,7 @@ Personal sites and blogs * [Adam Shand's homepage](http://adam.shand.net/iki/) * [Recai Oktaş's homepage](http://kirkambar.net/) (uses [[rcs/Git]] backend, Turkish language only). * [Hess family wiki](http://kitenet.net/~family/) -* [Stefano Zacchiroli's blog](http://www.bononia.it/~zack/blog/) +* [Zack](http://upsilon.cc/~zack)'s homepage, including [his weblog](http://upsilon.cc/~zack/blog/) * [Taquiones: Victor Moral's personal website in Spanish](http://taquiones.net) * [Venexma Europa, S.L.](http://www.venexma.net): It's a small company dedicated to the distribution of shoe accessories. We use ikiwiki for development of internal applications (some areas are password protected). In spanish, of course. * [betacantrips, the personal website of Ethan Glasser-Camp](http://www.betacantrips.com/) From c4373aa487ea8206abecb64c4ba5fbbcc90690f7 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 4 Jan 2008 04:26:50 -0500 Subject: [PATCH 2/9] web commit by http://weakish.int.eu.org/ --- doc/bugs/pages_under_templates_are_invalid.mdwn | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 doc/bugs/pages_under_templates_are_invalid.mdwn diff --git a/doc/bugs/pages_under_templates_are_invalid.mdwn b/doc/bugs/pages_under_templates_are_invalid.mdwn new file mode 100644 index 000000000..9a363a76d --- /dev/null +++ b/doc/bugs/pages_under_templates_are_invalid.mdwn @@ -0,0 +1,5 @@ +ages under templates/ are invalid (in fact, not only invalid, but also not well-formed) xhtml pages. + +This problem is especially serious when you change extension from .html to .xhtml in ikiwiki.setup and use Firefox. Since Firefox will display a error message only for not well-formed application/xhtml+xml pages. + +It seems that HTML::Template also support syntax instead of . Chaning to this syntax will solve this problem, I guess. From 78e3f5a657f2e207fc49c501f6522ec3c4065e00 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 4 Jan 2008 04:33:26 -0500 Subject: [PATCH 3/9] web commit by http://weakish.int.eu.org/ --- ...matched_tags_won__39__t_get_converted.mdwn | 34 +++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 doc/bugs/undefined_tags_or_mismatched_tags_won__39__t_get_converted.mdwn diff --git a/doc/bugs/undefined_tags_or_mismatched_tags_won__39__t_get_converted.mdwn b/doc/bugs/undefined_tags_or_mismatched_tags_won__39__t_get_converted.mdwn new file mode 100644 index 000000000..1928d04f2 --- /dev/null +++ b/doc/bugs/undefined_tags_or_mismatched_tags_won__39__t_get_converted.mdwn @@ -0,0 +1,34 @@ +If you put in something such as undefined tags or mismatched tags in .mdwn file, ikiwiki will put

around them. But ikiwiki will NOT convert < and > to &lt; and &gt;! + +
+ + some text + +
+ + +the output html + +

some text

+ +And another example of mismatched tags: + + + +
+ + some text + +
+ + + + The out put becomes: + +
+ + some text + +
+ +

From ce3b55de42502dfb2ec099990d74c38ce82bac7b Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 4 Jan 2008 04:34:58 -0500 Subject: [PATCH 4/9] web commit by http://weakish.int.eu.org/: minor --- ...matched_tags_won__39__t_get_converted.mdwn | 32 +++++++++---------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/doc/bugs/undefined_tags_or_mismatched_tags_won__39__t_get_converted.mdwn b/doc/bugs/undefined_tags_or_mismatched_tags_won__39__t_get_converted.mdwn index 1928d04f2..9289759f1 100644 --- a/doc/bugs/undefined_tags_or_mismatched_tags_won__39__t_get_converted.mdwn +++ b/doc/bugs/undefined_tags_or_mismatched_tags_won__39__t_get_converted.mdwn @@ -1,34 +1,34 @@ If you put in something such as undefined tags or mismatched tags in .mdwn file, ikiwiki will put

around them. But ikiwiki will NOT convert < and > to &lt; and &gt;! -
+
- some text + some text -
+
the output html -

some text

+

some text

And another example of mismatched tags: +
+ + some text + +
+ + + +The out put is: +
- some text + some text
- - - The out put becomes: - -
- - some text - -
- -

+

From c9ea796b39e0d83aa54652250789bd7e246b13f0 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 4 Jan 2008 04:38:18 -0500 Subject: [PATCH 5/9] web commit by http://weakish.int.eu.org/: minor --- ...efined_tags_or_mismatched_tags_won__39__t_get_converted.mdwn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/bugs/undefined_tags_or_mismatched_tags_won__39__t_get_converted.mdwn b/doc/bugs/undefined_tags_or_mismatched_tags_won__39__t_get_converted.mdwn index 9289759f1..9463cfb1b 100644 --- a/doc/bugs/undefined_tags_or_mismatched_tags_won__39__t_get_converted.mdwn +++ b/doc/bugs/undefined_tags_or_mismatched_tags_won__39__t_get_converted.mdwn @@ -1,4 +1,4 @@ -If you put in something such as undefined tags or mismatched tags in .mdwn file, ikiwiki will put

around them. But ikiwiki will NOT convert < and > to &lt; and &gt;! +If you put in something such as undefined tags or mismatched tags in .mdwn file, ikiwiki will put <p></p> around them. But ikiwiki will NOT convert < and > to &lt; and &gt;!
From d1f88ee75bc70956716669ca68653c29439d6661 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 4 Jan 2008 07:09:14 -0500 Subject: [PATCH 6/9] web commit by tschwinge: Patch. --- doc/todo/passwordauth:_sendmail_interface.mdwn | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/doc/todo/passwordauth:_sendmail_interface.mdwn b/doc/todo/passwordauth:_sendmail_interface.mdwn index 68b9b47ee..4714a7a09 100644 --- a/doc/todo/passwordauth:_sendmail_interface.mdwn +++ b/doc/todo/passwordauth:_sendmail_interface.mdwn @@ -34,6 +34,18 @@ in the ikiwiki source code, where emailing is done. OK, so I'll have a look at replacing all email handling with *Email::Send*. +[[tag patch]] +** + +Remaining TODOs: + + * Resolve TODOs as denoted inside the patch. + * Is it worthwhile to use and depend on [[cpan Return::Value]] + just for this bit of functionality? + * Debian news file. + * ikiwiki news file. + * Are commit emails still working? + --[[tschwinge]] From 250e3789fee4fb2539e954f52ab356ff6d3a3978 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 4 Jan 2008 09:16:55 -0500 Subject: [PATCH 7/9] web commit by tschwinge: Suggest syntax for creating anchors via a to-be-written plugin. --- doc/ikiwiki/wikilink/discussion.mdwn | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/ikiwiki/wikilink/discussion.mdwn b/doc/ikiwiki/wikilink/discussion.mdwn index d81163670..66b5eae06 100644 --- a/doc/ikiwiki/wikilink/discussion.mdwn +++ b/doc/ikiwiki/wikilink/discussion.mdwn @@ -15,7 +15,13 @@ BTW, ikiwiki doesn't displays the #foo anchor in the example > No such syntax exists in markdown. ikiwiki could certainly have a > [[preprocessor_directive|preprocessordirective]] for it, though. -> +> --[[JoshTriplett]] + +>> [[tag wishlist]] +>> I'd like to implement such a thing. Joey, what is this supposed to look like? +>> `\[[anchor WHATEVER]]`? --[[tschwinge]] + + > The lack of the `#foo` anchor in the anchor example on [[wikilink]] > definitely looks like a bug. --[[JoshTriplett]] @@ -27,3 +33,4 @@ Considering a hierarchy like `foo/bar/bar`, I had the need to link from the `foo/bar/bar` page to the `foo/bar` one. It would have been convenient to simply write [[wikilink]]s like `\[[../bar]]` (or even just `\[[..]]`?), but this doesn't work, so I had to resort to using `\[[foo/bar]]` instead. +--[[tschwinge]] From f22558faedd71f4c29ff7c7b5a9a5e0d7371e339 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 4 Jan 2008 12:20:41 -0500 Subject: [PATCH 8/9] web commit by http://weakish.int.eu.org/: some more thought --- doc/bugs/pages_under_templates_are_invalid.mdwn | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/doc/bugs/pages_under_templates_are_invalid.mdwn b/doc/bugs/pages_under_templates_are_invalid.mdwn index 9a363a76d..da4ffb295 100644 --- a/doc/bugs/pages_under_templates_are_invalid.mdwn +++ b/doc/bugs/pages_under_templates_are_invalid.mdwn @@ -3,3 +3,8 @@ ages under templates/ are invalid (in fact, not only invalid, but also not well- This problem is especially serious when you change extension from .html to .xhtml in ikiwiki.setup and use Firefox. Since Firefox will display a error message only for not well-formed application/xhtml+xml pages. It seems that HTML::Template also support syntax instead of . Chaning to this syntax will solve this problem, I guess. + + +Even if changed to style, the problem may still exist if the template contains if else block. + +Maybe just encode all < and > when compling pages within the templates folder will solve this problem. From f9fa96ded77418851da8b094f73c25dbde8a9714 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Sat, 5 Jan 2008 01:01:11 -0500 Subject: [PATCH 9/9] web commit by adb --- doc/bugs/taint_issue_with_regular_expressions.mdwn | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 doc/bugs/taint_issue_with_regular_expressions.mdwn diff --git a/doc/bugs/taint_issue_with_regular_expressions.mdwn b/doc/bugs/taint_issue_with_regular_expressions.mdwn new file mode 100644 index 000000000..174b4f1c5 --- /dev/null +++ b/doc/bugs/taint_issue_with_regular_expressions.mdwn @@ -0,0 +1,9 @@ +Built from 2.1.17 source, works fine on commandline, but not working from CGI wrapper. Traced problem to regular expressions failing to match, specifically in contexts like the following in Render.pm: + + my ($f)=/$config{wiki_file_regexp}/; # untaint + +It works if I replace it with: + + my ($f)=/(^[-[:alnum:]_.:\/+]+$)/; # untaint + +which is exactly the same regular expression drawn out as a constant. It appears that %config gets some tainted data and is itself being marked entirely tainted, which may prevent using regular expressions contained in it for untainting other data. I'm using Perl 5.8.8.