refreshing three pending patches

master
chrysn 2014-06-29 20:06:26 +02:00
parent ccc58d9773
commit eff5f02e24
3 changed files with 27 additions and 0 deletions

View File

@ -19,3 +19,5 @@ the output will look much better (at least in my wikis) with the "[[bugs/pagetit
the patch is stored in [[the patch.pl]] as created by git-format-patch, and can
be pulled from the abovementioned branch.
> update 2014-06-29: branch still merges cleanly and works. --[[chrysn]]

View File

@ -14,3 +14,23 @@ version, but i'm pretty sure it was already broken after the abovementioned
patch.
-- [[chrysn]]
> update 2014-06-29: the problem persists, but i found it is not trivial to
> reproduce. to demonstrate, use this test plugin:
>
> #!/usr/bin/env python
> # -*- coding: utf-8 -*-
>
> from proxy import IkiWikiProcedureProxy
>
> def preprocess(self, proxy, *args):
> return repr(self.rpc('pagetype', 'schön'))
>
> proxy = IkiWikiProcedureProxy(__name__)
> proxy.hook('preprocess', preprocess, id='testdirective')
> proxy.run()
>
> note that when the 'schön' is stored in a variable, the exception changes --
> it seems to me that the issue is related to the way exceptions are encoded.
>
> the suggested patch still applies and solves the issue. --[[chrysn]]

View File

@ -20,3 +20,8 @@ that needs special care or breaks something i don't use; this way, my patches
should be safe for inclusion.
--[[chrysn]]
> update 2014-06-29: the patch still applies and fixes the issue. in the
> meantime, i noticed that the desired effect doesn't happen when no explicit
> size is set. as scalable graphics don't necessarily have a natural size
> anyway, i don't consider that a showstopper. --[[chrysn]]