positive review

master
smcv 2014-07-04 04:11:48 -04:00 committed by admin
parent 6d90e56c8d
commit e740ff3a4b
1 changed files with 1 additions and 3 deletions

View File

@ -17,9 +17,7 @@ the attached [[!taglink patch]] fixes this; from its commit message:
the output will look much better (at least in my wikis) with the "[[bugs/pagetitle function does not respect meta titles]]" issue fixed. the output will look much better (at least in my wikis) with the "[[bugs/pagetitle function does not respect meta titles]]" issue fixed.
> I agree that it's (likely to be) a bug to not use `pagetitle()`. I > [[Looks good to me|users/smcv/yesplease]].
> haven't reviewed this particular implementation yet but I'll try to
> do that soon.
> >
> I don't think it's correct for `pagetitle()` to output `\[[!meta title]]` > I don't think it's correct for `pagetitle()` to output `\[[!meta title]]`
> though, as discussed on the linked bug: it appears in an assortment of > though, as discussed on the linked bug: it appears in an assortment of