From e35eb5a4184c9140e01422d0cb70c39cc1a8b969 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Mon, 7 Jan 2008 18:12:12 -0500 Subject: [PATCH] * Add a prereq on Data::Dumper 2.11 or better, needed to dump q// objects. --- IkiWiki/Wrapper.pm | 2 +- Makefile.PL | 1 + debian/changelog | 1 + doc/bugs/taint_issue_with_regular_expressions.mdwn | 4 ++++ 4 files changed, 7 insertions(+), 1 deletion(-) diff --git a/IkiWiki/Wrapper.pm b/IkiWiki/Wrapper.pm index 16e5bd350..2103ea53a 100644 --- a/IkiWiki/Wrapper.pm +++ b/IkiWiki/Wrapper.pm @@ -3,7 +3,7 @@ use warnings; use strict; use Cwd q{abs_path}; -use Data::Dumper; +use Data::Dumper ; use IkiWiki; package IkiWiki; diff --git a/Makefile.PL b/Makefile.PL index bd5bb7eee..49fac1ade 100755 --- a/Makefile.PL +++ b/Makefile.PL @@ -103,5 +103,6 @@ WriteMakefile( 'Mail::Sendmail' => 0, 'HTML::Parser' => 0, 'URI' => 0, + 'Data::Dumper' => 2.11, }, ); diff --git a/debian/changelog b/debian/changelog index 9bfdb6a58..84219d267 100644 --- a/debian/changelog +++ b/debian/changelog @@ -8,6 +8,7 @@ ikiwiki (2.19) UNRELEASED; urgency=low forcing a user to log in. * opendiscussion: allow editing of the toplevel discussion page, and, indirectly, allow creating new discussion pages. + * Add a prereq on Data::Dumper 2.11 or better, needed to dump q// objects. -- Joey Hess Mon, 07 Jan 2008 15:35:16 -0500 diff --git a/doc/bugs/taint_issue_with_regular_expressions.mdwn b/doc/bugs/taint_issue_with_regular_expressions.mdwn index 5ba9e19f6..6544c8aae 100644 --- a/doc/bugs/taint_issue_with_regular_expressions.mdwn +++ b/doc/bugs/taint_issue_with_regular_expressions.mdwn @@ -29,3 +29,7 @@ without any payload of the actual regexp, and that would also certainly also hav 'wiki_file_regexp' => qr/(?-xism:(^[-[:alnum:]_.:\/+]+$))/ This would call for at most an installation prerequisite of Data::Dumper >= 1.121. A look at the module's changelog shows that no intervening versions were actually released, so 1.121 would be the minimal good one. + +> You must have a very old version of perl there. This seems to be a bug in +> data dumper before 2.11, which didn't properly dump q// objects. Prereq +> added, [[done]] --[[Joey]]