fix the diff button location

master
https://id.koumbit.net/anarcat 2012-03-03 17:29:31 -04:00 committed by admin
parent 2e21e45f7d
commit dfc8fa9f8e
1 changed files with 1 additions and 1 deletions

View File

@ -13,7 +13,7 @@ It would rock if I could view diffs from the web without going via feeds. I envi
> > > >
> > 1. it assumes the toggle.js code is loaded somehow > > 1. it assumes the toggle.js code is loaded somehow
> > 2. if the toggle code isn't loaded the diffs are displayed (which is arguably better than showing nothing since we ship the diff to the UA anyways...) > > 2. if the toggle code isn't loaded the diffs are displayed (which is arguably better than showing nothing since we ship the diff to the UA anyways...)
> > 3. it will show only if there's a revert URL, which is backwards, but otherwise the display is weird, with each button on its own line > > 3. <del>it will show only if there's a revert URL, which is backwards, but otherwise the display is weird, with each button on its own line</del> fixed!
> > 4. if the diffurl parameter is set in the template, we'd actually see two sets of glasses, which is silly. > > 4. if the diffurl parameter is set in the template, we'd actually see two sets of glasses, which is silly.
> > > >
> > I feel this should nevertheless be implemented because if we're going to compile all this crap in the page anyways and send it to the client, why not allow the user to show it? I also feel that showing it by default is a lesser evil for non-javascript users. > > I feel this should nevertheless be implemented because if we're going to compile all this crap in the page anyways and send it to the client, why not allow the user to show it? I also feel that showing it by default is a lesser evil for non-javascript users.