master
joey 2007-07-25 02:27:23 +00:00
parent 42b1f27e5c
commit de9104d4e2
5 changed files with 28 additions and 77 deletions

View File

@ -1,74 +0,0 @@
I noticed when generating my wiki that all of my RSS feeds were
getting regenerated even when I edited only a page that did not affect
any feed.
I found that the problem only occurs in the presence of a file that
contains \[[inline pages="*"]].
> How is this unexpected? By inlining _every_ page in the wiki, you're
> making that page depend on every other page; any change to any page in
> the wiki will result in the inlining page and its rss feed needing to be
> updated to include the changed page.
> --[[Joey]]
Here's a short script for replicating the bug. Just cut and paste this
to a shell, (it will only muck in a new /tmp/ikiwiki-test directory
that it will create):
cd /tmp
mkdir ikiwiki-test; cd ikiwiki-test; mkdir src
echo '\[[inline pages="blog/*"]]' > src/myblog.mdwn
mkdir src/blog; echo "A blog entry" > src/blog/entry.mdwn
echo 'use IkiWiki::Setup::Standard {
srcdir => "src",
destdir => "output",
url => "http://example.com",
templatedir => "/dev/null",
underlaydir => "/dev/null",
rss => 1,
wrappers => [],
verbose => 1,
refresh => 1
}' > setup
ikiwiki --setup setup
ls -l --time-style=full-iso output/myblog/index.rss
echo "not a blog entry" > src/not-a-blog.mdwn
ikiwiki --setup setup
ls -l --time-style=full-iso output/myblog/index.rss
echo '\[[inline pages="*"]]' > src/archives.mdwn
ikiwiki --setup setup
ls -l --time-style=full-iso output/myblog/index.rss
echo "still not blogging" >> src/not-a-blog.mdwn
ikiwiki --setup setup
ls -l --time-style=full-iso output/myblog/index.rss
Here's the tail of the output that I see for this command:
$ echo "not a blog entry" > src/not-a-blog.mdwn
$ ikiwiki --setup setup
refreshing wiki..
scanning not-a-blog.mdwn
rendering not-a-blog.mdwn
done
$ ls -l --time-style=full-iso output/myblog/index.rss
-rw-r--r-- 1 cworth cworth 459 2007-06-01 06:34:36.000000000 -0700 output/myblog/index.rss
$ echo '\[[inline pages="*"]]' > src/archives.mdwn
$ ikiwiki --setup setup
refreshing wiki..
scanning archives.mdwn
rendering archives.mdwn
done
$ ls -l --time-style=full-iso output/myblog/index.rss
-rw-r--r-- 1 cworth cworth 459 2007-06-01 06:34:37.000000000 -0700 output/myblog/index.rss
$ echo "still not blogging" >> src/not-a-blog.mdwn
$ ikiwiki --setup setup
refreshing wiki..
scanning not-a-blog.mdwn
rendering not-a-blog.mdwn
rendering archives.mdwn, which depends on not-a-blog
done
$ ls -l --time-style=full-iso output/myblog/index.rss
-rw-r--r-- 1 cworth cworth 459 2007-06-01 06:34:38.000000000 -0700 output/myblog/index.rss
It looks like the rendering of archives.mdwn is also silently
generating myblog/index.rss.

View File

@ -16,8 +16,13 @@ So two suggestions to fix this:
1. Make command-line arguments override settings in the setup file 1. Make command-line arguments override settings in the setup file
> This is difficult to do, since reading a setup file replaces values for
> config items with the values in the setup file.
2. Comment out all settings in the example setup file that are simply 2. Comment out all settings in the example setup file that are simply
setting options to their default values. That way, the file will setting options to their default values. That way, the file will
still be self-documenting, but command-line arguments will at least still be self-documenting, but command-line arguments will at least
work for these settings while they remain commented out. work for these settings while they remain commented out.
> I've done that, I also fixed some issues with --verbose handling earlier.
> --[[Joey]]

View File

@ -91,3 +91,8 @@ to break the code I distribute in my backport ;)
>> Maybe I found it at old ikiwiki home page? I don't remember it now. >> Maybe I found it at old ikiwiki home page? I don't remember it now.
>> >>
>> --[[Paweł|ptecza]] >> --[[Paweł|ptecza]]
----
I'm marking this [[done]] since it only affects sarge. Sarge users should
use the patch above. --[[Joey]]

View File

@ -10,4 +10,5 @@ My first reading (and second and third) of this was that backlinks would be disa
--[[KarlMW]] --[[KarlMW]]
> Yes, it only controls the number of backlinks that are shown at the > Yes, it only controls the number of backlinks that are shown at the
> bottom of the page vs how many are moved to the popup --[[Joey]] > bottom of the page vs how many are moved to the popup. I've tried to
> improve the documentation for this. [[done]] --[[Joey]]

View File

@ -1 +1,15 @@
After editing a page `pagename`, ikiwiki redirects to `pagename/index.html?updated`. Ignoring for the moment that ?updated seems like a bad idea to begin with, this should at least not introduce /index.html into the URL. After editing a page `pagename`, ikiwiki redirects to `pagename/index.html?updated`. Ignoring for the moment that ?updated seems like a bad idea to begin with, this should at least not introduce /index.html into the URL.
> The "?updated" works around caching issues with certain broken browsers,
> web proxys, and/or webservers. These assume that since the "?" is there,
> the page is not static, or is a different page, thus forcing the page to
> be reloaded and the edited version seen. So no, not a bad idea, really.
>
> Removing the index.html would probably break this workaround.
> http://foo/bar/?updated will redirect to http://foo/bar/index.html, and
> said broken software will then display its old out of date cached
> version.
>
> So, not changing this. [[tag done]]
>
> --[[Joey]]