urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bit of a design for how a post-receive hook could work

master
Joey Hess 2008-10-20 20:16:30 -04:00
parent 94797b66c4
commit dbf8358d68
1 changed files with 37 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
doc/todo/applydiff_plugin.mdwn
View File

@ -56,3 +56,40 @@ Implementation
============== ==============
Also see [[joey]]'s idea on [[users/xma/discussion]], to allow (filtered) anonymous push to this wiki's repository. Also see [[joey]]'s idea on [[users/xma/discussion]], to allow (filtered) anonymous push to this wiki's repository.
> Ideally the filtering should apply the same constraints on what's pushed
> as are applied to web edits. So locked pages can't be changed, etc.
>
> That could be accomplished by making the git pre-receive hook be a
> ikiwiki wrapper. A new `git_receive_wrapper` config setting could cause
> the wrapper to be generated, with `$config{receive}` set to true.
>
> When run that way, ikiwiki would call `rcs_receive`. In the case of git,
> that would look at the received changes as fed into the hook on stdin,
> and use `parse_diff_tree` to get a list of the files changed. Then it
> could determine if the changes were allowed.
>
> To do that, it should perhaps first look at what unix user received the
> commit. That could be mapped directly to an ikiwiki user. This would
> typically be an unprivelidged user, but you might also want to set up
> separate users who have fewer limits on what they can push. OTOH, I'm not
> sure how to get this info in an ikiwiki wrapper.. the real and effective
> gid are already trampled. So maybe leave this out and always treat it as
> an anonymous edit from a non-logged in user?
>
> Then it seems like it would want to call `check_canedit` to test if an
> edit to each changed page is allowed. Might also want to call
> `check_canattach` and `check_canremove` if the attach and remove plugins
> are enabled. All three expect to be passed a CGI and a CGI::Session
> object, which is a bit problimatic here. So dummy the objects up? (To call
> `check_canattach` the changed attachment would need to be extracted to a
> temp file for it to check..)
>
> If a change is disallowed, it would print out what was disallowed, and
> exit nonzero. I think that git then discards the pushed objects (or maybe
> they remain in the database until `git-gc` .. if so, that could be used
> to DOS by uploading junk, so need to check this point).
>
> Also, I've not verified that the objects have been recieved already when
> whe pre-receive hook is called. Although the docs seem to say that is the
> case. --[[Joey]]