From d0862bc7a1bde9d828579c63841cf32fc44bffae Mon Sep 17 00:00:00 2001 From: Amitai Schlair Date: Sun, 17 Feb 2013 10:52:23 -0500 Subject: [PATCH] Document that podcasts are text XOR enclosure. --- t/podcast.t | 53 ++++++++++++++++++++++++++++++---------- t/tinypodcast/index.mdwn | 2 +- t/tinypodcast/post.mdwn | 1 + 3 files changed, 42 insertions(+), 14 deletions(-) create mode 100644 t/tinypodcast/post.mdwn diff --git a/t/podcast.t b/t/podcast.t index 4a5bde6a9..da91b3446 100755 --- a/t/podcast.t +++ b/t/podcast.t @@ -8,7 +8,7 @@ BEGIN { eval q{use Test::More skip_all => "XML::Feed not available"}; } else { - eval q{use Test::More tests => 36}; + eval q{use Test::More tests => 72}; } } @@ -23,6 +23,7 @@ sub simple_podcast { ok(! system(@command)); my %media_types = ( + 'post' => undef, 'piano.mp3' => 'audio/mpeg', 'scroll.3gp' => 'video/3gpp', 'walter.ogg' => 'video/x-theora+ogg', @@ -31,27 +32,53 @@ sub simple_podcast { for my $format (qw(atom rss)) { my $feed = XML::Feed->parse("t/tmp/out/index.$format"); - is($feed->title, 'wiki', qq{$format feed title}); - is($feed->link, "$baseurl/", qq{$format feed link}); - is($feed->description, $feed->title, qq{$format feed description}); + is($feed->title, 'wiki', + qq{$format feed title}); + is($feed->link, "$baseurl/", + qq{$format feed link}); + is($feed->description, $feed->title, + qq{$format feed description}); if ('atom' eq $format) { - is($feed->author, $feed->title, qq{$format feed author}); - is($feed->id, "$baseurl/", qq{$format feed id}); - is($feed->generator, "ikiwiki", qq{$format feed generator}); + is($feed->author, $feed->title, + qq{$format feed author}); + is($feed->id, "$baseurl/", + qq{$format feed id}); + is($feed->generator, "ikiwiki", + qq{$format feed generator}); } for my $entry ($feed->entries) { my $title = $entry->title; my $url = $entry->id; + my $body = $entry->content->body; my $enclosure = $entry->enclosure; - is($url, "$baseurl/$title", qq{$format $title id}); is($entry->link, $url, qq{$format $title link}); - is($enclosure->url, $url, qq{$format $title enclosure url}); - is($enclosure->type, $media_types{$title}, qq{$format $title enclosure type}); - # is($enclosure->length, '12345', qq{$format $title enclosure length}); - # creation date - # modification date + isnt($entry->issued, undef, + qq{$format $title issued date}); + isnt($entry->modified, undef, + qq{$format $title modified date}); + + if (defined $media_types{$title}) { + is($url, "$baseurl/$title", + qq{$format $title id}); + is($body, undef, + qq{$format $title no body text}); + is($enclosure->url, $url, + qq{$format $title enclosure url}); + is($enclosure->type, $media_types{$title}, + qq{$format $title enclosure type}); + cmp_ok($enclosure->length, '>', 0, + qq{$format $title enclosure length}); + } + else { + is($url, "$baseurl/$title/", + qq{$format $title id}); + isnt($body, undef, + qq{$format $title body text}); + is($enclosure, undef, + qq{$format $title no enclosure}); + } } } diff --git a/t/tinypodcast/index.mdwn b/t/tinypodcast/index.mdwn index a5c6c9bd8..530f7516c 100644 --- a/t/tinypodcast/index.mdwn +++ b/t/tinypodcast/index.mdwn @@ -1 +1 @@ -[[!inline pages="*.3gp or *.mov or *.mp3 or *.ogg" rss=yes atom=yes]] +[[!inline pages="post or *.3gp or *.mov or *.mp3 or *.ogg" rss=yes atom=yes]] diff --git a/t/tinypodcast/post.mdwn b/t/tinypodcast/post.mdwn new file mode 100644 index 000000000..d28ddb524 --- /dev/null +++ b/t/tinypodcast/post.mdwn @@ -0,0 +1 @@ +this article has content but no enclosure