responses

master
joey 2006-12-28 20:44:48 +00:00
parent 85566ff3a3
commit c9e07b583b
4 changed files with 43 additions and 28 deletions

View File

@ -0,0 +1,7 @@
Any setting to disable having a discussion of a discussion?
The [[features]] page says every page, but I don't want every page.
I do want discussion subpage, but I don't want to have, for example: discussion/ discussion/ discussion.
-- [[JeremyReed]]
> Discussion pages should clearly be a special case that don't get Discussion
> links put at the top. --[[Joey]]

View File

@ -21,6 +21,10 @@ or "History".
> link needs to be different if the Discussion page doesn't yet exist. > link needs to be different if the Discussion page doesn't yet exist.
>> You can always use <tmpl_if> and <tmpl_else> construct in that place ;) --Pawel >> You can always use <tmpl_if> and <tmpl_else> construct in that place ;) --Pawel
>>> Not without duplicating the logic that constructs a link to an
>>> existing/nonexisting page in two places, one in code in ikiwiki and one
>>> in the template. Not good design. --[[Joey]]
> As noted in [[patchqueue/l10n]], there are some other places in ikiwiki > As noted in [[patchqueue/l10n]], there are some other places in ikiwiki
> that hard code English strings, and I feel that using standard gettext > that hard code English strings, and I feel that using standard gettext
@ -32,4 +36,7 @@ or "History".
>> >>
>> BTW, is there a chance for configurable name of Discussion page? >> BTW, is there a chance for configurable name of Discussion page?
>> In my wiki I use only Polish name of pages, so I would like to have >> In my wiki I use only Polish name of pages, so I would like to have
>> dyskusja.html page, instead of discussion.html page. --Pawel >> dyskusja.html page, instead of discussion.html page. --Pawel
>>> I have an incomplete i10n patch for such hardcoded strings in the code,
>>> which I hope to finish up eventually --[[Joey]]

View File

@ -232,21 +232,21 @@ editing a page. Is that an option that can be enabled?
Any setting for limiting how many kilobytes can be submitted via the "edit" form? Any setting for limiting how many kilobytes can be submitted via the "edit" form?
-- [[JeremyReed]] -- [[JeremyReed]]
> Not currently. Worried about abuse? -man -[[Joey]] > Not currently. Worried about abuse? --[[Joey]]
>> I didn't want it abused accidently or with malice. I was thinking that Perl's CGI.pm would handle this, but I don't see that. >> I didn't want it abused accidently or with malice. I was thinking that Perl's CGI.pm would handle this, but I don't see that.
>> I read that textarea max bytes may be 500 lines or 28000 characters or 30000 characters or 64kB. It seems like it >> I read that textarea max bytes may be 500 lines or 28000 characters or 30000 characters or 64kB. It seems like it
>> varies and I didn't test myself, because I guess it may depend on different clients and different HTTP servers. >> varies and I didn't test myself, because I guess it may depend on different clients and different HTTP servers.
>> This could be checked using javascript on the client side (before submitting) and by checking size on server side (before saving). --[[JeremyReed]] >> This could be checked using javascript on the client side (before submitting) and by checking size on server side (before saving). --[[JeremyReed]]
>>> The absolute limit varies by browser. If there are web servers that
>>> also limit it, I don't know of them. --[[Joey]]
---- ----
# Disable sub-discussion pages? # Disable sub-discussion pages?
Any setting to disable having a discussion of a discussion? > Moved to [[bugs]] -- [[Joey]]
The [[features]] page says every page, but I don't want every page.
I do want discussion subpage, but I don't want to have, for example: discussion/ discussion/ discussion.
-- [[JeremyReed]]
---- ----
@ -261,6 +261,10 @@ What is the correct way to include ,v RCS revision files in my source tree witho
-- [[JeremyReed]] -- [[JeremyReed]]
> Add the ,v to the $config{wiki_file_prune_regexps} array. This is how we
> skip equivilant files from other revision control systems too.
> --[[Joey]]]
---- ----
# Textile Plugin # Textile Plugin

View File

@ -2,32 +2,25 @@ I'm writing my own CSS for ikiwiki. During this effort I often found the need of
In this patch I plan to collect changes in this direction. In this patch I plan to collect changes in this direction.
The first, one-liner, patch is to use a "div" element with a class="actions" attribute for inline page as is done with non-inlined page. This way the same CSS formatting can be applied to div.actions in the CSS, while at the moment it must be duplicated for a span.actions (which I believe is also incorrect, since it will contain a "ul" element, not sure though). In case the markup should be differentiated it will still be possible relying on the fact that a div.actions is contained or not in a div.inlinepage. The first, one-liner, patch is to use a "div" element with a
class="actions" attribute for inline page as is done with non-inlined page.
This way the same CSS formatting can be applied to div.actions in the CSS,
while at the moment it must be duplicated for a span.actions (which I
believe is also incorrect, since it will contain a "ul" element, not sure
though). In case the markup should be differentiated it will still be
possible relying on the fact that a div.actions is contained or not in a
div.inlinepage.
Here's the one-liner: Here's the one-liner:
--- /usr/share/ikiwiki/templates/inlinepage.tmpl 2006-12-28 16:24:06.000000000 +0100 > applied --[[Joey]]
+++ inlinepage.tmpl.new 2006-12-28 16:24:04.000000000 +0100
@@ -31,7 +31,7 @@
</span>
<TMPL_IF NAME="HAVE_ACTIONS"> The following adds a div element with class="trailer" around the
-<span class="actions"> meta-information added after an inlined page (namely: the post date, the
+<div class="actions"> tags, and the actions):
<ul>
<TMPL_IF NAME="EDITURL">
<li><a href="<TMPL_VAR EDITURL>">Edit</a></li>
@@ -40,7 +40,7 @@
<li><TMPL_VAR DISCUSSIONLINK></li>
</TMPL_IF>
</ul>
-</span>
+</div>
</TMPL_IF>
</div> The following adds a div element with class="trailer" around the meta-informati
on added after an inlined page (namely: the post date, the tags, and the actions):
The following adds a div element with class="trailer" around the meta-information added after an inlined page (namely: the post date, the tags, and the actions):
--- inlinepage.tmpl.orig 2006-12-28 16:56:49.000000000 +0100 --- inlinepage.tmpl.orig 2006-12-28 16:56:49.000000000 +0100
+++ inlinepage.tmpl 2006-12-28 17:02:06.000000000 +0100 +++ inlinepage.tmpl 2006-12-28 17:02:06.000000000 +0100
@ -47,4 +40,8 @@ The following adds a div element with class="trailer" around the meta-informatio
+ +
+</div> +</div>
> Unfortunately, the inlinepage content passes through markdown, and markdown
> gets confused by these nested div's and puts p's around one of them, generating
> broken html. If you can come up with a way to put in the div that passes
> the test suite, or a fix to markdown, I will accept it, but the above patch
> fails the test suite. --[[Joey]]