urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

review, suggest a change

master
smcv 2014-06-30 05:49:44 -04:00 committed by admin
parent a4d3db605a
commit c10c6c1c4d
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
doc/bugs/pythonproxy-utf8_again.mdwn
View File

@ -34,3 +34,15 @@ patch.
> it seems to me that the issue is related to the way exceptions are encoded.
>
> the suggested patch still applies and solves the issue. --[[chrysn]]
>> In this patch band:
>>
>> - xml = _IkiWikiExtPluginXMLRPCHandler._read(in_fd).decode('utf8')
>> + response = _IkiWikiExtPluginXMLRPCHandler._read(in_fd)
>> + if isinstance(response, unicode):
>> + xml = response.encode('utf8')
>>
>> I think you mean `response.decode`, not `response.encode`.
>>
>> Other than that it looks good to me. I like the use of `repr` in debug
>> messages. --[[smcv]]