would you accept patches for this?

master
Jon Dowland 2009-10-05 15:27:03 +01:00
parent 204e733d79
commit bccea01c07
1 changed files with 17 additions and 0 deletions

View File

@ -75,3 +75,20 @@ I find CSS3 support still spotty... Here are some notes on how to do this in Ik
> [[rel_attribute|rel_attribute_for_links]] now that CSS can use.)
>
> --[[Joey]]
>> I had a little look at this, last weekend. I added a class definition to
>> the `htmllink` call in `linkify` in `link.pm`. It works pretty well, but
>> I'd also need to adjust other `htmllink` calls (map, inline, etc.). I found
>> other methods (CSS3 selectors, etc.) to be unreliable.
>>
>> Would you potentially accept a patch that added `class="internal"` to
>> various `htmllink` calls in ikiwiki?
>>
>> How configurable do you think this behaviour should be? I'm considering a
>> config switch to enable or disable this behaviour, or possibly a
>> configurable list of class names to append for internal links (defaulting
>> to an empty list for backwards compatibility)>
>>
>> As an alternative to patching the uses of `htmllink`, what do you think
>> about patching `htmllink` itself? Are there circumstances where it might be
>> used to generate a non-internal link? -- [[Jon]]